common: Drop linux/delay.h from common header
[oweals/u-boot.git] / drivers / mmc / omap_hsmmc.c
index b10d55ef6159cfbd41ec43c3494962910dd15210..0c21ec716e4042c38fa5dfb5051327594c528d27 100644 (file)
@@ -24,6 +24,8 @@
 
 #include <config.h>
 #include <common.h>
+#include <cpu_func.h>
+#include <log.h>
 #include <malloc.h>
 #include <memalign.h>
 #include <mmc.h>
@@ -32,6 +34,7 @@
 #if defined(CONFIG_OMAP54XX) || defined(CONFIG_OMAP44XX)
 #include <palmas.h>
 #endif
+#include <asm/cache.h>
 #include <asm/io.h>
 #include <asm/arch/mmc_host_def.h>
 #ifdef CONFIG_OMAP54XX
 #include <asm/arch/mux.h>
 #endif
 #include <dm.h>
+#include <dm/devres.h>
+#include <linux/delay.h>
+#include <linux/err.h>
+#include <power/regulator.h>
+#include <thermal.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -77,26 +85,27 @@ struct omap_hsmmc_data {
 #endif
        uint bus_width;
        uint clock;
+       ushort last_cmd;
 #ifdef OMAP_HSMMC_USE_GPIO
 #if CONFIG_IS_ENABLED(DM_MMC)
        struct gpio_desc cd_gpio;       /* Change Detect GPIO */
        struct gpio_desc wp_gpio;       /* Write Protect GPIO */
-       bool cd_inverted;
 #else
        int cd_gpio;
        int wp_gpio;
 #endif
 #endif
 #if CONFIG_IS_ENABLED(DM_MMC)
-       uint iov;
        enum bus_mode mode;
 #endif
        u8 controller_flags;
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
        struct omap_hsmmc_adma_desc *adma_desc_table;
        uint desc_slot;
 #endif
        const char *hw_rev;
+       struct udevice *pbias_supply;
+       uint signal_voltage;
 #ifdef CONFIG_IODELAY_RECALIBRATION
        struct omap_hsmmc_pinctrl_state *default_pinctrl_state;
        struct omap_hsmmc_pinctrl_state *hs_pinctrl_state;
@@ -114,7 +123,7 @@ struct omap_mmc_of_data {
        u8 controller_flags;
 };
 
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
 struct omap_hsmmc_adma_desc {
        u8 attr;
        u8 reserved;
@@ -180,7 +189,7 @@ static int omap_mmc_setup_gpio_in(int gpio, const char *label)
 {
        int ret;
 
-#ifndef CONFIG_DM_GPIO
+#if !CONFIG_IS_ENABLED(DM_GPIO)
        if (!gpio_is_valid(gpio))
                return -1;
 #endif
@@ -213,6 +222,10 @@ static unsigned char mmc_board_init(struct mmc *mmc)
        /* for cairo board, we need to set up 1.8 Volt bias level on MMC1 */
        pbias_lite &= ~PBIASLITEVMODE0;
 #endif
+#ifdef CONFIG_TARGET_OMAP3_LOGIC
+       /* For Logic PD board, 1.8V bias to go enable gpio127 for mmc_cd */
+       pbias_lite &= ~PBIASLITEVMODE1;
+#endif
 #ifdef CONFIG_MMC_OMAP36XX_PINS
        if (get_cpu_family() == CPU_OMAP36XX) {
                /* Disable extended drain IO before changing PBIAS */
@@ -253,10 +266,11 @@ static unsigned char mmc_board_init(struct mmc *mmc)
                &prcm_base->iclken1_core);
 #endif
 
-#if defined(CONFIG_OMAP54XX) || defined(CONFIG_OMAP44XX)
+#if (defined(CONFIG_OMAP54XX) || defined(CONFIG_OMAP44XX)) &&\
+       !CONFIG_IS_ENABLED(DM_REGULATOR)
        /* PBIAS config needed for MMC1 only */
        if (mmc_get_blk_desc(mmc)->devnum == 0)
-               vmmc_pbias_config(LDO_VOLT_3V0);
+               vmmc_pbias_config(LDO_VOLT_3V3);
 #endif
 
        return 0;
@@ -381,7 +395,6 @@ static void omap_hsmmc_set_timing(struct mmc *mmc)
                break;
        case MMC_LEGACY:
        case MMC_HS:
-       case SD_LEGACY:
        case UHS_SDR12:
                val |= AC12_UHSMC_SDR12;
                break;
@@ -397,32 +410,145 @@ static void omap_hsmmc_set_timing(struct mmc *mmc)
        omap_hsmmc_start_clock(mmc_base);
 }
 
-static void omap_hsmmc_conf_bus_power(struct mmc *mmc)
+static void omap_hsmmc_conf_bus_power(struct mmc *mmc, uint signal_voltage)
 {
        struct hsmmc *mmc_base;
        struct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);
-       u32 val;
+       u32 hctl, ac12;
 
        mmc_base = priv->base_addr;
 
-       val = readl(&mmc_base->hctl) & ~SDVS_MASK;
+       hctl = readl(&mmc_base->hctl) & ~SDVS_MASK;
+       ac12 = readl(&mmc_base->ac12) & ~AC12_V1V8_SIGEN;
 
-       switch (priv->iov) {
-       case IOV_3V3:
-               val |= SDVS_3V3;
-               break;
-       case IOV_3V0:
-               val |= SDVS_3V0;
+       switch (signal_voltage) {
+       case MMC_SIGNAL_VOLTAGE_330:
+               hctl |= SDVS_3V3;
                break;
-       case IOV_1V8:
-               val |= SDVS_1V8;
+       case MMC_SIGNAL_VOLTAGE_180:
+               hctl |= SDVS_1V8;
+               ac12 |= AC12_V1V8_SIGEN;
                break;
        }
 
-       writel(val, &mmc_base->hctl);
+       writel(hctl, &mmc_base->hctl);
+       writel(ac12, &mmc_base->ac12);
+}
+
+static int omap_hsmmc_wait_dat0(struct udevice *dev, int state, int timeout_us)
+{
+       int ret = -ETIMEDOUT;
+       u32 con;
+       bool dat0_high;
+       bool target_dat0_high = !!state;
+       struct omap_hsmmc_data *priv = dev_get_priv(dev);
+       struct hsmmc *mmc_base = priv->base_addr;
+
+       con = readl(&mmc_base->con);
+       writel(con | CON_CLKEXTFREE | CON_PADEN, &mmc_base->con);
+
+       timeout_us = DIV_ROUND_UP(timeout_us, 10); /* check every 10 us. */
+       while (timeout_us--) {
+               dat0_high = !!(readl(&mmc_base->pstate) & PSTATE_DLEV_DAT0);
+               if (dat0_high == target_dat0_high) {
+                       ret = 0;
+                       break;
+               }
+               udelay(10);
+       }
+       writel(con, &mmc_base->con);
+
+       return ret;
 }
 
-static void omap_hsmmc_set_capabilities(struct mmc *mmc)
+#if CONFIG_IS_ENABLED(MMC_IO_VOLTAGE)
+#if CONFIG_IS_ENABLED(DM_REGULATOR)
+static int omap_hsmmc_set_io_regulator(struct mmc *mmc, int mV)
+{
+       int ret = 0;
+       int uV = mV * 1000;
+
+       struct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);
+
+       if (!mmc->vqmmc_supply)
+               return 0;
+
+       /* Disable PBIAS */
+       ret = regulator_set_enable_if_allowed(priv->pbias_supply, false);
+       if (ret)
+               return ret;
+
+       /* Turn off IO voltage */
+       ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, false);
+       if (ret)
+               return ret;
+       /* Program a new IO voltage value */
+       ret = regulator_set_value(mmc->vqmmc_supply, uV);
+       if (ret)
+               return ret;
+       /* Turn on IO voltage */
+       ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, true);
+       if (ret)
+               return ret;
+
+       /* Program PBIAS voltage*/
+       ret = regulator_set_value(priv->pbias_supply, uV);
+       if (ret && ret != -ENOSYS)
+               return ret;
+       /* Enable PBIAS */
+       ret = regulator_set_enable_if_allowed(priv->pbias_supply, true);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+#endif
+
+static int omap_hsmmc_set_signal_voltage(struct mmc *mmc)
+{
+       struct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);
+       struct hsmmc *mmc_base = priv->base_addr;
+       int mv = mmc_voltage_to_mv(mmc->signal_voltage);
+       u32 capa_mask;
+       __maybe_unused u8 palmas_ldo_volt;
+       u32 val;
+
+       if (mv < 0)
+               return -EINVAL;
+
+       if (mmc->signal_voltage == MMC_SIGNAL_VOLTAGE_330) {
+               mv = 3300;
+               capa_mask = VS33_3V3SUP;
+               palmas_ldo_volt = LDO_VOLT_3V3;
+       } else if (mmc->signal_voltage == MMC_SIGNAL_VOLTAGE_180) {
+               capa_mask = VS18_1V8SUP;
+               palmas_ldo_volt = LDO_VOLT_1V8;
+       } else {
+               return -EOPNOTSUPP;
+       }
+
+       val = readl(&mmc_base->capa);
+       if (!(val & capa_mask))
+               return -EOPNOTSUPP;
+
+       priv->signal_voltage = mmc->signal_voltage;
+
+       omap_hsmmc_conf_bus_power(mmc, mmc->signal_voltage);
+
+#if CONFIG_IS_ENABLED(DM_REGULATOR)
+       return omap_hsmmc_set_io_regulator(mmc, mv);
+#elif (defined(CONFIG_OMAP54XX) || defined(CONFIG_OMAP44XX)) && \
+       defined(CONFIG_PALMAS_POWER)
+       if (mmc_get_blk_desc(mmc)->devnum == 0)
+               vmmc_pbias_config(palmas_ldo_volt);
+       return 0;
+#else
+       return 0;
+#endif
+}
+#endif
+
+static uint32_t omap_hsmmc_set_capabilities(struct mmc *mmc)
 {
        struct hsmmc *mmc_base;
        struct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);
@@ -432,19 +558,18 @@ static void omap_hsmmc_set_capabilities(struct mmc *mmc)
        val = readl(&mmc_base->capa);
 
        if (priv->controller_flags & OMAP_HSMMC_SUPPORTS_DUAL_VOLT) {
-               val |= (VS30_3V0SUP | VS18_1V8SUP);
-               priv->iov = IOV_3V0;
+               val |= (VS33_3V3SUP | VS18_1V8SUP);
        } else if (priv->controller_flags & OMAP_HSMMC_NO_1_8_V) {
-               val |= VS30_3V0SUP;
+               val |= VS33_3V3SUP;
                val &= ~VS18_1V8SUP;
-               priv->iov = IOV_3V0;
        } else {
                val |= VS18_1V8SUP;
-               val &= ~VS30_3V0SUP;
-               priv->iov = IOV_1V8;
+               val &= ~VS33_3V3SUP;
        }
 
        writel(val, &mmc_base->capa);
+
+       return val;
 }
 
 #ifdef MMC_SUPPORTS_TUNING
@@ -500,6 +625,10 @@ static int omap_hsmmc_execute_tuning(struct udevice *dev, uint opcode)
        u32 phase_delay = 0;
        u32 start_window = 0, max_window = 0;
        u32 length = 0, max_len = 0;
+       bool single_point_failure = false;
+       struct udevice *thermal_dev;
+       int temperature;
+       int i;
 
        mmc_base = priv->base_addr;
        val = readl(&mmc_base->capa2);
@@ -510,9 +639,25 @@ static int omap_hsmmc_execute_tuning(struct udevice *dev, uint opcode)
              ((mmc->selected_mode == UHS_SDR50) && (val & CAPA2_TSDR50))))
                return 0;
 
+       ret = uclass_first_device(UCLASS_THERMAL, &thermal_dev);
+       if (ret) {
+               printf("Couldn't get thermal device for tuning\n");
+               return ret;
+       }
+       ret = thermal_get_temp(thermal_dev, &temperature);
+       if (ret) {
+               printf("Couldn't get temperature for tuning\n");
+               return ret;
+       }
        val = readl(&mmc_base->dll);
        val |= DLL_SWT;
        writel(val, &mmc_base->dll);
+
+       /*
+        * Stage 1: Search for a maximum pass window ignoring any
+        * any single point failures. If the tuning value ends up
+        * near it, move away from it in stage 2 below
+        */
        while (phase_delay <= MAX_PHASE_DELAY) {
                omap_hsmmc_set_dll(mmc, phase_delay);
 
@@ -521,10 +666,16 @@ static int omap_hsmmc_execute_tuning(struct udevice *dev, uint opcode)
                if (cur_match) {
                        if (prev_match) {
                                length++;
+                       } else if (single_point_failure) {
+                               /* ignore single point failure */
+                               length++;
+                               single_point_failure = false;
                        } else {
                                start_window = phase_delay;
                                length = 1;
                        }
+               } else {
+                       single_point_failure = prev_match;
                }
 
                if (length > max_len) {
@@ -546,8 +697,71 @@ static int omap_hsmmc_execute_tuning(struct udevice *dev, uint opcode)
                ret = -EIO;
                goto tuning_error;
        }
+       /*
+        * Assign tuning value as a ratio of maximum pass window based
+        * on temperature
+        */
+       if (temperature < -20000)
+               phase_delay = min(max_window + 4 * max_len - 24,
+                                 max_window +
+                                 DIV_ROUND_UP(13 * max_len, 16) * 4);
+       else if (temperature < 20000)
+               phase_delay = max_window + DIV_ROUND_UP(9 * max_len, 16) * 4;
+       else if (temperature < 40000)
+               phase_delay = max_window + DIV_ROUND_UP(8 * max_len, 16) * 4;
+       else if (temperature < 70000)
+               phase_delay = max_window + DIV_ROUND_UP(7 * max_len, 16) * 4;
+       else if (temperature < 90000)
+               phase_delay = max_window + DIV_ROUND_UP(5 * max_len, 16) * 4;
+       else if (temperature < 120000)
+               phase_delay = max_window + DIV_ROUND_UP(4 * max_len, 16) * 4;
+       else
+               phase_delay = max_window + DIV_ROUND_UP(3 * max_len, 16) * 4;
+
+       /*
+        * Stage 2: Search for a single point failure near the chosen tuning
+        * value in two steps. First in the +3 to +10 range and then in the
+        * +2 to -10 range. If found, move away from it in the appropriate
+        * direction by the appropriate amount depending on the temperature.
+        */
+       for (i = 3; i <= 10; i++) {
+               omap_hsmmc_set_dll(mmc, phase_delay + i);
+               if (mmc_send_tuning(mmc, opcode, NULL)) {
+                       if (temperature < 10000)
+                               phase_delay += i + 6;
+                       else if (temperature < 20000)
+                               phase_delay += i - 12;
+                       else if (temperature < 70000)
+                               phase_delay += i - 8;
+                       else if (temperature < 90000)
+                               phase_delay += i - 6;
+                       else
+                               phase_delay += i - 6;
+
+                       goto single_failure_found;
+               }
+       }
+
+       for (i = 2; i >= -10; i--) {
+               omap_hsmmc_set_dll(mmc, phase_delay + i);
+               if (mmc_send_tuning(mmc, opcode, NULL)) {
+                       if (temperature < 10000)
+                               phase_delay += i + 12;
+                       else if (temperature < 20000)
+                               phase_delay += i + 8;
+                       else if (temperature < 70000)
+                               phase_delay += i + 8;
+                       else if (temperature < 90000)
+                               phase_delay += i + 10;
+                       else
+                               phase_delay += i + 12;
+
+                       goto single_failure_found;
+               }
+       }
+
+single_failure_found:
 
-       phase_delay = max_window + 4 * ((3 * max_len) >> 2);
        omap_hsmmc_set_dll(mmc, phase_delay);
 
        mmc_reset_controller_fsm(mmc_base, SYSCTL_SRD);
@@ -614,18 +828,19 @@ static int omap_hsmmc_init_setup(struct mmc *mmc)
                        return -ETIMEDOUT;
                }
        }
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
        reg_val = readl(&mmc_base->hl_hwinfo);
        if (reg_val & MADMA_EN)
                priv->controller_flags |= OMAP_HSMMC_USE_ADMA;
 #endif
 
 #if CONFIG_IS_ENABLED(DM_MMC)
-       omap_hsmmc_set_capabilities(mmc);
-       omap_hsmmc_conf_bus_power(mmc);
+       reg_val = omap_hsmmc_set_capabilities(mmc);
+       omap_hsmmc_conf_bus_power(mmc, (reg_val & VS33_3V3SUP) ?
+                         MMC_SIGNAL_VOLTAGE_330 : MMC_SIGNAL_VOLTAGE_180);
 #else
        writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V0, &mmc_base->hctl);
-       writel(readl(&mmc_base->capa) | VS30_3V0SUP | VS18_1V8SUP,
+       writel(readl(&mmc_base->capa) | VS33_3V3SUP | VS18_1V8SUP,
                &mmc_base->capa);
 #endif
 
@@ -652,7 +867,10 @@ static int omap_hsmmc_init_setup(struct mmc *mmc)
        writel(readl(&mmc_base->hctl) | SDBP_PWRON, &mmc_base->hctl);
 
        mmc_enable_irq(mmc, NULL);
+
+#if !CONFIG_IS_ENABLED(DM_MMC)
        mmc_init_stream(mmc_base);
+#endif
 
        return 0;
 }
@@ -703,7 +921,7 @@ static void mmc_reset_controller_fsm(struct hsmmc *mmc_base, u32 bit)
        }
 }
 
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
 static void omap_hsmmc_adma_desc(struct mmc *mmc, char *buf, u16 len, bool end)
 {
        struct omap_hsmmc_data *priv = omap_hsmmc_get_data(mmc);
@@ -830,6 +1048,7 @@ static int omap_hsmmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
        struct hsmmc *mmc_base;
        unsigned int flags, mmc_stat;
        ulong start;
+       priv->last_cmd = cmd->cmdidx;
 
        mmc_base = priv->base_addr;
 
@@ -841,18 +1060,17 @@ static int omap_hsmmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
                if (get_timer(0) - start > MAX_RETRY_MS) {
                        printf("%s: timedout waiting on cmd inhibit to clear\n",
                                        __func__);
+                       mmc_reset_controller_fsm(mmc_base, SYSCTL_SRD);
+                       mmc_reset_controller_fsm(mmc_base, SYSCTL_SRC);
                        return -ETIMEDOUT;
                }
        }
        writel(0xFFFFFFFF, &mmc_base->stat);
-       start = get_timer(0);
-       while (readl(&mmc_base->stat)) {
-               if (get_timer(0) - start > MAX_RETRY_MS) {
-                       printf("%s: timedout waiting for STAT (%x) to clear\n",
-                               __func__, readl(&mmc_base->stat));
-                       return -ETIMEDOUT;
-               }
+       if (readl(&mmc_base->stat)) {
+               mmc_reset_controller_fsm(mmc_base, SYSCTL_SRD);
+               mmc_reset_controller_fsm(mmc_base, SYSCTL_SRC);
        }
+
        /*
         * CMDREG
         * CMDIDX[13:8] : Command index
@@ -905,7 +1123,7 @@ static int omap_hsmmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
                else
                        flags |= (DP_DATA | DDIR_WRITE);
 
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
                if ((priv->controller_flags & OMAP_HSMMC_USE_ADMA) &&
                    !mmc_is_tuning_cmd(cmd->cmdidx)) {
                        omap_hsmmc_prepare_data(mmc, data);
@@ -950,7 +1168,7 @@ static int omap_hsmmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
                }
        }
 
-#ifndef CONFIG_OMAP34XX
+#ifdef CONFIG_MMC_OMAP_HS_ADMA
        if ((priv->controller_flags & OMAP_HSMMC_USE_ADMA) && data &&
            !mmc_is_tuning_cmd(cmd->cmdidx)) {
                u32 sz_mb, timeout;
@@ -1049,8 +1267,9 @@ static int mmc_read_data(struct hsmmc *mmc_base, char *buf, unsigned int size)
        return 0;
 }
 
+#if CONFIG_IS_ENABLED(MMC_WRITE)
 static int mmc_write_data(struct hsmmc *mmc_base, const char *buf,
-                               unsigned int size)
+                         unsigned int size)
 {
        unsigned int *input_buf = (unsigned int *)buf;
        unsigned int mmc_stat;
@@ -1103,7 +1322,13 @@ static int mmc_write_data(struct hsmmc *mmc_base, const char *buf,
        }
        return 0;
 }
-
+#else
+static int mmc_write_data(struct hsmmc *mmc_base, const char *buf,
+                         unsigned int size)
+{
+       return -ENOTSUPP;
+}
+#endif
 static void omap_hsmmc_stop_clock(struct hsmmc *mmc_base)
 {
        writel(readl(&mmc_base->sysctl) & ~CEN_ENABLE, &mmc_base->sysctl);
@@ -1195,6 +1420,8 @@ static int omap_hsmmc_set_ios(struct udevice *dev)
        struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
        struct mmc *mmc = upriv->mmc;
 #endif
+       struct hsmmc *mmc_base = priv->base_addr;
+       int ret = 0;
 
        if (priv->bus_width != mmc->bus_width)
                omap_hsmmc_set_bus_width(mmc);
@@ -1202,36 +1429,46 @@ static int omap_hsmmc_set_ios(struct udevice *dev)
        if (priv->clock != mmc->clock)
                omap_hsmmc_set_clock(mmc);
 
+       if (mmc->clk_disable)
+               omap_hsmmc_stop_clock(mmc_base);
+       else
+               omap_hsmmc_start_clock(mmc_base);
+
 #if CONFIG_IS_ENABLED(DM_MMC)
        if (priv->mode != mmc->selected_mode)
                omap_hsmmc_set_timing(mmc);
+
+#if CONFIG_IS_ENABLED(MMC_IO_VOLTAGE)
+       if (priv->signal_voltage != mmc->signal_voltage)
+               ret = omap_hsmmc_set_signal_voltage(mmc);
 #endif
-       return 0;
+#endif
+       return ret;
 }
 
 #ifdef OMAP_HSMMC_USE_GPIO
 #if CONFIG_IS_ENABLED(DM_MMC)
 static int omap_hsmmc_getcd(struct udevice *dev)
 {
+       int value = -1;
+#if CONFIG_IS_ENABLED(DM_GPIO)
        struct omap_hsmmc_data *priv = dev_get_priv(dev);
-       int value;
-
        value = dm_gpio_get_value(&priv->cd_gpio);
+#endif
        /* if no CD return as 1 */
        if (value < 0)
                return 1;
 
-       if (priv->cd_inverted)
-               return !value;
        return value;
 }
 
 static int omap_hsmmc_getwp(struct udevice *dev)
 {
+       int value = 0;
+#if CONFIG_IS_ENABLED(DM_GPIO)
        struct omap_hsmmc_data *priv = dev_get_priv(dev);
-       int value;
-
        value = dm_gpio_get_value(&priv->wp_gpio);
+#endif
        /* if no WP return as 0 */
        if (value < 0)
                return 0;
@@ -1279,6 +1516,7 @@ static const struct dm_mmc_ops omap_hsmmc_ops = {
 #ifdef MMC_SUPPORTS_TUNING
        .execute_tuning = omap_hsmmc_execute_tuning,
 #endif
+       .wait_dat0      = omap_hsmmc_wait_dat0,
 };
 #else
 static const struct mmc_ops omap_hsmmc_ops = {
@@ -1301,7 +1539,7 @@ int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
        struct mmc_config *cfg;
        uint host_caps_val;
 
-       priv = malloc(sizeof(*priv));
+       priv = calloc(1, sizeof(*priv));
        if (priv == NULL)
                return -1;
 
@@ -1677,6 +1915,8 @@ static int omap_hsmmc_ofdata_to_platdata(struct udevice *dev)
        if (ret < 0)
                return ret;
 
+       if (!cfg->f_max)
+               cfg->f_max = 52000000;
        cfg->host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS;
        cfg->f_min = 400000;
        cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
@@ -1697,10 +1937,6 @@ static int omap_hsmmc_ofdata_to_platdata(struct udevice *dev)
        }
 #endif
 
-#ifdef OMAP_HSMMC_USE_GPIO
-       plat->cd_inverted = fdtdec_get_bool(fdt, node, "cd-inverted");
-#endif
-
        return 0;
 }
 #endif
@@ -1710,8 +1946,8 @@ static int omap_hsmmc_ofdata_to_platdata(struct udevice *dev)
 static int omap_hsmmc_bind(struct udevice *dev)
 {
        struct omap_hsmmc_plat *plat = dev_get_platdata(dev);
-
-       return mmc_bind(dev, &plat->mmc, &plat->cfg);
+       plat->mmc = calloc(1, sizeof(struct mmc));
+       return mmc_bind(dev, plat->mmc, &plat->cfg);
 }
 #endif
 static int omap_hsmmc_probe(struct udevice *dev)
@@ -1729,21 +1965,23 @@ static int omap_hsmmc_probe(struct udevice *dev)
        priv->base_addr = plat->base_addr;
        priv->controller_flags = plat->controller_flags;
        priv->hw_rev = plat->hw_rev;
-#ifdef OMAP_HSMMC_USE_GPIO
-       priv->cd_inverted = plat->cd_inverted;
-#endif
 
 #ifdef CONFIG_BLK
-       mmc = &plat->mmc;
+       mmc = plat->mmc;
 #else
        mmc = mmc_create(cfg, priv);
        if (mmc == NULL)
                return -1;
 #endif
-
-#if defined(OMAP_HSMMC_USE_GPIO) && CONFIG_IS_ENABLED(OF_CONTROL)
+#if CONFIG_IS_ENABLED(DM_REGULATOR)
+       device_get_supply_regulator(dev, "pbias-supply",
+                                   &priv->pbias_supply);
+#endif
+#if defined(OMAP_HSMMC_USE_GPIO)
+#if CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(DM_GPIO)
        gpio_request_by_name(dev, "cd-gpios", 0, &priv->cd_gpio, GPIOD_IS_IN);
        gpio_request_by_name(dev, "wp-gpios", 0, &priv->wp_gpio, GPIOD_IS_IN);
+#endif
 #endif
 
        mmc->dev = dev;
@@ -1795,6 +2033,8 @@ U_BOOT_DRIVER(omap_hsmmc) = {
        .ops = &omap_hsmmc_ops,
        .probe  = omap_hsmmc_probe,
        .priv_auto_alloc_size = sizeof(struct omap_hsmmc_data),
+#if !CONFIG_IS_ENABLED(OF_CONTROL)
        .flags  = DM_FLAG_PRE_RELOC,
+#endif
 };
 #endif