Merge tag 'efi-2020-07-rc6' of https://gitlab.denx.de/u-boot/custodians/u-boot-efi
[oweals/u-boot.git] / cmd / ubi.c
index ac9a582437d603039ec722db30d32187dd1181c4..171377cc66b547f039e12217e9fd9be1f90bc323 100644 (file)
--- a/cmd/ubi.c
+++ b/cmd/ubi.c
 
 #include <common.h>
 #include <command.h>
+#include <env.h>
 #include <exports.h>
+#include <malloc.h>
 #include <memalign.h>
+#include <mtd.h>
 #include <nand.h>
 #include <onenand_uboot.h>
+#include <dm/devres.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>
 #include <linux/err.h>
 #undef ubi_msg
 #define ubi_msg(fmt, ...) printf("UBI: " fmt "\n", ##__VA_ARGS__)
 
-#define DEV_TYPE_NONE          0
-#define DEV_TYPE_NAND          1
-#define DEV_TYPE_ONENAND       2
-#define DEV_TYPE_NOR           3
-
 /* Private own data */
 static struct ubi_device *ubi;
-static char buffer[80];
-static int ubi_initialized;
-
-struct selected_dev {
-       char part_name[80];
-       int selected;
-       int nr;
-       struct mtd_info *mtd_info;
-};
-
-static struct selected_dev ubi_dev;
 
 #ifdef CONFIG_CMD_UBIFS
-int ubifs_is_mounted(void);
-void cmd_ubifs_umount(void);
+#include <ubifs_uboot.h>
 #endif
 
 static void display_volume_info(struct ubi_device *ubi)
@@ -117,7 +104,6 @@ static int ubi_check(char *name)
        return 1;
 }
 
-
 static int verify_mkvol_req(const struct ubi_device *ubi,
                            const struct ubi_mkvol_req *req)
 {
@@ -162,7 +148,8 @@ bad:
        return err;
 }
 
-static int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id)
+static int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id,
+                         bool skipcheck)
 {
        struct ubi_mkvol_req req;
        int err;
@@ -179,7 +166,10 @@ static int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id)
        strcpy(req.name, volume);
        req.name_len = strlen(volume);
        req.name[req.name_len] = '\0';
-       req.padding1 = 0;
+       req.flags = 0;
+       if (skipcheck)
+               req.flags |= UBI_VOL_SKIP_CRC_CHECK_FLG;
+
        /* It's duplicated at drivers/mtd/ubi/cdev.c */
        err = verify_mkvol_req(ubi, &req);
        if (err) {
@@ -261,6 +251,39 @@ out_err:
        return err;
 }
 
+static int ubi_rename_vol(char *oldname, char *newname)
+{
+       struct ubi_volume *vol;
+       struct ubi_rename_entry rename;
+       struct ubi_volume_desc desc;
+       struct list_head list;
+
+       vol = ubi_find_volume(oldname);
+       if (!vol) {
+               printf("%s: volume %s doesn't exist\n", __func__, oldname);
+               return ENODEV;
+       }
+
+       printf("Rename UBI volume %s to %s\n", oldname, newname);
+
+       if (ubi->ro_mode) {
+               printf("%s: ubi device is in read-only mode\n", __func__);
+               return EROFS;
+       }
+
+       rename.new_name_len = strlen(newname);
+       strcpy(rename.new_name, newname);
+       rename.remove = 0;
+       desc.vol = vol;
+       desc.mode = 0;
+       rename.desc = &desc;
+       INIT_LIST_HEAD(&rename.list);
+       INIT_LIST_HEAD(&list);
+       list_add(&rename.list, &list);
+
+       return ubi_rename_volumes(ubi, &list);
+}
+
 static int ubi_volume_continue_write(char *volume, void *buf, size_t size)
 {
        int err = 1;
@@ -356,6 +379,8 @@ int ubi_volume_read(char *volume, char *buf, size_t size)
                size = vol->used_bytes;
        }
 
+       printf("Read %zu bytes from volume %s to %p\n", size, volume, buf);
+
        if (vol->corrupted)
                printf("read from corrupted volume %d", vol->vol_id);
        if (offp + size > vol->used_bytes)
@@ -407,54 +432,54 @@ int ubi_volume_read(char *volume, char *buf, size_t size)
        return err;
 }
 
-static int ubi_dev_scan(struct mtd_info *info, char *ubidev,
-               const char *vid_header_offset)
+static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
 {
-       struct mtd_device *dev;
-       struct part_info *part;
-       struct mtd_partition mtd_part;
        char ubi_mtd_param_buffer[80];
-       u8 pnum;
        int err;
 
-       if (find_dev_and_part(ubidev, &dev, &pnum, &part) != 0)
-               return 1;
+       if (!vid_header_offset)
+               sprintf(ubi_mtd_param_buffer, "%s", info->name);
+       else
+               sprintf(ubi_mtd_param_buffer, "%s,%s", info->name,
+                       vid_header_offset);
 
-       sprintf(buffer, "mtd=%d", pnum);
-       memset(&mtd_part, 0, sizeof(mtd_part));
-       mtd_part.name = buffer;
-       mtd_part.size = part->size;
-       mtd_part.offset = part->offset;
-       add_mtd_partitions(info, &mtd_part, 1);
-
-       strcpy(ubi_mtd_param_buffer, buffer);
-       if (vid_header_offset)
-               sprintf(ubi_mtd_param_buffer, "mtd=%d,%s", pnum,
-                               vid_header_offset);
        err = ubi_mtd_param_parse(ubi_mtd_param_buffer, NULL);
-       if (err) {
-               del_mtd_partitions(info);
+       if (err)
                return -err;
-       }
 
        err = ubi_init();
-       if (err) {
-               del_mtd_partitions(info);
+       if (err)
                return -err;
-       }
-
-       ubi_initialized = 1;
 
        return 0;
 }
 
-int ubi_detach(void)
+static int ubi_set_skip_check(char *volume, bool skip_check)
 {
-       if (mtdparts_init() != 0) {
-               printf("Error initializing mtdparts!\n");
-               return 1;
+       struct ubi_vtbl_record vtbl_rec;
+       struct ubi_volume *vol;
+
+       vol = ubi_find_volume(volume);
+       if (!vol)
+               return ENODEV;
+
+       printf("%sing skip_check on volume %s\n",
+              skip_check ? "Sett" : "Clear", volume);
+
+       vtbl_rec = ubi->vtbl[vol->vol_id];
+       if (skip_check) {
+               vtbl_rec.flags |= UBI_VTBL_SKIP_CRC_CHECK_FLG;
+               vol->skip_check = 1;
+       } else {
+               vtbl_rec.flags &= ~UBI_VTBL_SKIP_CRC_CHECK_FLG;
+               vol->skip_check = 0;
        }
 
+       return ubi_change_vtbl_record(ubi, vol->vol_id, &vtbl_rec);
+}
+
+static int ubi_detach(void)
+{
 #ifdef CONFIG_CMD_UBIFS
        /*
         * Automatically unmount UBIFS partition when user
@@ -468,49 +493,33 @@ int ubi_detach(void)
        /*
         * Call ubi_exit() before re-initializing the UBI subsystem
         */
-       if (ubi_initialized) {
+       if (ubi)
                ubi_exit();
-               del_mtd_partitions(ubi_dev.mtd_info);
-               ubi_initialized = 0;
-       }
 
-       ubi_dev.selected = 0;
+       ubi = NULL;
+
        return 0;
 }
 
 int ubi_part(char *part_name, const char *vid_header_offset)
 {
+       struct mtd_info *mtd;
        int err = 0;
-       char mtd_dev[16];
-       struct mtd_device *dev;
-       struct part_info *part;
-       u8 pnum;
 
        ubi_detach();
-       /*
-        * Search the mtd device number where this partition
-        * is located
-        */
-       if (find_dev_and_part(part_name, &dev, &pnum, &part)) {
+
+       mtd_probe_devices();
+       mtd = get_mtd_device_nm(part_name);
+       if (IS_ERR(mtd)) {
                printf("Partition %s not found!\n", part_name);
                return 1;
        }
-       sprintf(mtd_dev, "%s%d", MTD_DEV_TYPE(dev->id->type), dev->id->num);
-       ubi_dev.mtd_info = get_mtd_device_nm(mtd_dev);
-       if (IS_ERR(ubi_dev.mtd_info)) {
-               printf("Partition %s not found on device %s!\n", part_name,
-                      mtd_dev);
-               return 1;
-       }
+       put_mtd_device(mtd);
 
-       ubi_dev.selected = 1;
-
-       strcpy(ubi_dev.part_name, part_name);
-       err = ubi_dev_scan(ubi_dev.mtd_info, ubi_dev.part_name,
-                       vid_header_offset);
+       err = ubi_dev_scan(mtd, vid_header_offset);
        if (err) {
                printf("UBI init error %d\n", err);
-               ubi_dev.selected = 0;
+               printf("Please check, if the correct MTD partition is used (size big enough?)\n");
                return err;
        }
 
@@ -519,35 +528,30 @@ int ubi_part(char *part_name, const char *vid_header_offset)
        return 0;
 }
 
-static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+static int do_ubi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 {
        int64_t size = 0;
        ulong addr = 0;
+       bool skipcheck = false;
 
        if (argc < 2)
                return CMD_RET_USAGE;
 
-
-       if (strcmp(argv[1], "detach") == 0) {
-               if (argc < 2)
-                       return CMD_RET_USAGE;
-
+       if (strcmp(argv[1], "detach") == 0)
                return ubi_detach();
-       }
-
 
        if (strcmp(argv[1], "part") == 0) {
                const char *vid_header_offset = NULL;
 
                /* Print current partition */
                if (argc == 2) {
-                       if (!ubi_dev.selected) {
-                               printf("Error, no UBI device/partition selected!\n");
+                       if (!ubi) {
+                               printf("Error, no UBI device selected!\n");
                                return 1;
                        }
 
-                       printf("Device %d: %s, partition %s\n",
-                              ubi_dev.nr, ubi_dev.mtd_info->name, ubi_dev.part_name);
+                       printf("Device %d: %s, MTD partition %s\n",
+                              ubi->ubi_num, ubi->ubi_name, ubi->mtd->name);
                        return 0;
                }
 
@@ -560,8 +564,8 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                return ubi_part(argv[2], vid_header_offset);
        }
 
-       if ((strcmp(argv[1], "part") != 0) && (!ubi_dev.selected)) {
-               printf("Error, no UBI device/partition selected!\n");
+       if ((strcmp(argv[1], "part") != 0) && !ubi) {
+               printf("Error, no UBI device selected!\n");
                return 1;
        }
 
@@ -587,6 +591,12 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                /* Use maximum available size */
                size = 0;
 
+               /* E.g., create volume with "skipcheck" bit set */
+               if (argc == 7) {
+                       skipcheck = strncmp(argv[6], "--skipcheck", 11) == 0;
+                       argc--;
+               }
+
                /* E.g., create volume size type vol_id */
                if (argc == 6) {
                        id = simple_strtoull(argv[5], NULL, 16);
@@ -615,8 +625,10 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                        printf("No size specified -> Using max size (%lld)\n", size);
                }
                /* E.g., create volume */
-               if (argc == 3)
-                       return ubi_create_vol(argv[2], size, dynamic, id);
+               if (argc == 3) {
+                       return ubi_create_vol(argv[2], size, dynamic, id,
+                                             skipcheck);
+               }
        }
 
        if (strncmp(argv[1], "remove", 6) == 0) {
@@ -625,6 +637,17 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                        return ubi_remove_vol(argv[2]);
        }
 
+       if (IS_ENABLED(CONFIG_CMD_UBI_RENAME) && !strncmp(argv[1], "rename", 6))
+               return ubi_rename_vol(argv[2], argv[3]);
+
+       if (strncmp(argv[1], "skipcheck", 9) == 0) {
+               /* E.g., change skip_check flag */
+               if (argc == 4) {
+                       skipcheck = strncmp(argv[3], "on", 2) == 0;
+                       return ubi_set_skip_check(argv[2], skipcheck);
+               }
+       }
+
        if (strncmp(argv[1], "write", 5) == 0) {
                int ret;
 
@@ -674,9 +697,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
                }
 
                if (argc == 3) {
-                       printf("Read %lld bytes from volume %s to %lx\n", size,
-                              argv[3], addr);
-
                        return ubi_volume_read(argv[3], (char *)addr, size);
                }
        }
@@ -686,7 +706,7 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 }
 
 U_BOOT_CMD(
-       ubi, 6, 1, do_ubi,
+       ubi, 7, 1, do_ubi,
        "ubi commands",
        "detach"
                " - detach ubi from a mtd partition\n"
@@ -697,7 +717,7 @@ U_BOOT_CMD(
                " - Display volume and ubi layout information\n"
        "ubi check volumename"
                " - check if volumename exists\n"
-       "ubi create[vol] volume [size] [type] [id]\n"
+       "ubi create[vol] volume [size] [type] [id] [--skipcheck]\n"
                " - create volume name with size ('-' for maximum"
                " available size)\n"
        "ubi write[vol] address volume size"
@@ -708,6 +728,10 @@ U_BOOT_CMD(
                " - Read volume to address with size\n"
        "ubi remove[vol] volume"
                " - Remove volume\n"
+#if IS_ENABLED(CONFIG_CMD_UBI_RENAME)
+       "ubi rename oldname newname\n"
+#endif
+       "ubi skipcheck volume on/off - Set or clear skip_check flag in volume header\n"
        "[Legends]\n"
        " volume: character name\n"
        " size: specified in bytes\n"