13 years agoDefine WINVER before including any other header file on Windows.
Guus Sliepen [Sat, 1 May 2010 13:37:11 +0000 (15:37 +0200)]
Define WINVER before including any other header file on Windows.

13 years agoFix reading configuration files that do not end with a newline. Again.
Guus Sliepen [Sat, 17 Apr 2010 10:01:38 +0000 (12:01 +0200)]
Fix reading configuration files that do not end with a newline. Again.

13 years agoReleasing 1.0.13. release-1.0.13
Guus Sliepen [Sun, 11 Apr 2010 18:40:20 +0000 (20:40 +0200)]
Releasing 1.0.13.

13 years agoMark Forwarding and DirectOnly options as being experimental.
Guus Sliepen [Sun, 11 Apr 2010 17:47:44 +0000 (19:47 +0200)]
Mark Forwarding and DirectOnly options as being experimental.

13 years agoDon't redefine MAX if it already exists.
Guus Sliepen [Sun, 11 Apr 2010 17:39:31 +0000 (19:39 +0200)]
Don't redefine MAX if it already exists.

13 years agoFixes for definitions under Windows.
Guus Sliepen [Sun, 11 Apr 2010 17:20:02 +0000 (19:20 +0200)]
Fixes for definitions under Windows.

13 years agoEnsure subnet-up/down scripts are called after HUP when necessary.
Guus Sliepen [Sun, 11 Apr 2010 16:34:50 +0000 (18:34 +0200)]
Ensure subnet-up/down scripts are called after HUP when necessary.

13 years agoFix reloading Subnets when StrictSubnets is set.
Guus Sliepen [Sun, 11 Apr 2010 02:35:16 +0000 (04:35 +0200)]
Fix reloading Subnets when StrictSubnets is set.

13 years agoReload Subnets when getting a HUP signal and StrictSubnets is used.
Guus Sliepen [Sat, 10 Apr 2010 22:50:42 +0000 (00:50 +0200)]
Reload Subnets when getting a HUP signal and StrictSubnets is used.

13 years agoEnsure ICMP_NET_ANO is defined.
Guus Sliepen [Sat, 10 Apr 2010 21:55:15 +0000 (23:55 +0200)]
Ensure ICMP_NET_ANO is defined.

13 years agoConvert Port to numeric form before sending it to other nodes.
Guus Sliepen [Sat, 3 Apr 2010 08:46:45 +0000 (09:46 +0100)]
Convert Port to numeric form before sending it to other nodes.

If one uses a symbolic name for the Port option, tinc will send that name
literally to other nodes.  However, it is not guaranteed that all nodes have
the same contents in /etc/services, or have such a file at all.

13 years agoNever delete Subnets when StrictSubnets is set
Sven-Haegar Koch [Wed, 10 Mar 2010 01:50:51 +0000 (02:50 +0100)]
Never delete Subnets when StrictSubnets is set

If a node is unreachable, and not connected to an edge anymore, it gets
deleted. When this happens its subnets are also removed, which should
not happen with StrictSubnets=yes.

- do not remove subnets in src/net.c::purge(), we know that all subnets
  in the list came from our hosts files.
  I think here you got the check wrong by looking at the tunnelserver
  code below it - with strictsubnets we still inform others but do not
  remove the subnet from our data.
- do not remove nodes in net.c::purge() that still have subnets

13 years agoFix typo.
Guus Sliepen [Wed, 10 Mar 2010 15:07:01 +0000 (16:07 +0100)]
Fix typo.

13 years agoLog unauthorized Subnets when StrictSubnets is set.
Guus Sliepen [Mon, 8 Mar 2010 20:44:32 +0000 (21:44 +0100)]
Log unauthorized Subnets when StrictSubnets is set.

13 years agoConnectTo does not mean tinc does not listen for incoming connections anymore.
Guus Sliepen [Mon, 8 Mar 2010 16:54:57 +0000 (17:54 +0100)]
ConnectTo does not mean tinc does not listen for incoming connections anymore.

13 years agoFixes for the Forwarding option.
Guus Sliepen [Tue, 2 Mar 2010 22:27:50 +0000 (23:27 +0100)]
Fixes for the Forwarding option.

13 years agoAdd the DirectOnly option.
Guus Sliepen [Tue, 2 Mar 2010 21:55:24 +0000 (22:55 +0100)]
Add the DirectOnly option.

When this option is enabled, packets that cannot be sent directly to the destination node,
but which would have to be forwarded by an intermediate node, are dropped instead.
When combined with the IndirectData option,
packets for nodes for which we do not have a meta connection with are also dropped.

13 years agoAdd the Forwarding option.
Guus Sliepen [Tue, 2 Mar 2010 21:34:26 +0000 (22:34 +0100)]
Add the Forwarding option.

This determines if and how incoming packets that are not meant for the local
node are forwarded.  It can either be off, internal (tinc forwards them itself,
as in previous versions), or kernel (packets are always sent to the TUN/TAP
device, letting the kernel sort them out).

13 years agoAdd the StrictSubnets option.
Guus Sliepen [Mon, 1 Mar 2010 23:18:44 +0000 (00:18 +0100)]
Add the StrictSubnets option.

When this option is enabled, tinc will not accept dynamic updates of Subnets
from other nodes, but will only use Subnets read from local host config files
to build its routing table.

13 years agoPreload all Subnets in TunnelServer mode.
Guus Sliepen [Mon, 1 Mar 2010 22:44:56 +0000 (23:44 +0100)]
Preload all Subnets in TunnelServer mode.

This simplifies the logic in protocol_subnet.c.

13 years agoCheck for dirent.h.
Guus Sliepen [Mon, 1 Mar 2010 22:44:46 +0000 (23:44 +0100)]
Check for dirent.h.

13 years agoSimplify reading lines from configuration files.
Guus Sliepen [Mon, 1 Mar 2010 22:35:02 +0000 (23:35 +0100)]
Simplify reading lines from configuration files.

Instead of allocating storage for each line read, we now read into fixed-size
buffers on the stack. This fixes a case where a malformed configuration file
could crash tinc.

13 years agoClamp MSS to miminum MTU in both directions.
Guus Sliepen [Sun, 28 Feb 2010 17:20:13 +0000 (18:20 +0100)]
Clamp MSS to miminum MTU in both directions.

Clamp MSS of both incoming and outgoing packets, and use the minimum of the
PMTU of both directions when clamping.

13 years agoAdd --disable-zlib configure option
Timothy Redaelli [Wed, 10 Feb 2010 13:52:15 +0000 (14:52 +0100)]
Add --disable-zlib configure option

13 years agoAdd --disable-lzo configure option
Timothy Redaelli [Wed, 10 Feb 2010 12:24:33 +0000 (13:24 +0100)]
Add --disable-lzo configure option

13 years agoReleasing 1.0.12. release-1.0.12
Guus Sliepen [Wed, 3 Feb 2010 21:49:48 +0000 (22:49 +0100)]
Releasing 1.0.12.

13 years agoEnsure peers with a meta connection always have our key.
Guus Sliepen [Wed, 3 Feb 2010 10:18:46 +0000 (11:18 +0100)]
Ensure peers with a meta connection always have our key.

This keeps UDP probes going, which in turn keeps NAT mappings alive.

13 years agoUpdate copyright notices.
Guus Sliepen [Tue, 2 Feb 2010 21:49:21 +0000 (22:49 +0100)]
Update copyright notices.

13 years agoTry to set DF bit on BSDs as well.
Guus Sliepen [Tue, 2 Feb 2010 21:22:27 +0000 (22:22 +0100)]
Try to set DF bit on BSDs as well.

Every operating system seems to have its own, slightly different way to disable
packet fragmentation. Emit a compiler warning when no suitable way is found.
On OpenBSD, it seems impossible to do it for IPv4.

13 years agoImmediately exchange keys when establishing a meta connection.
Guus Sliepen [Tue, 2 Feb 2010 00:02:40 +0000 (01:02 +0100)]
Immediately exchange keys when establishing a meta connection.

This in turn will trigger PMTU discovery, and ensures nodes know each others
reflexive UDP address and port.

13 years agoDetermine peer's reflexive address and port when exchanging keys.
Guus Sliepen [Mon, 1 Feb 2010 23:51:44 +0000 (00:51 +0100)]
Determine peer's reflexive address and port when exchanging keys.

To help peers that are behind NAT connect to each other directly via UDP, they
need to know the exact external address and port that they use. Keys exchanged
between NATted peers necessarily go via a third node, which knows this address
and port, and can append this information to the keys, which is in turned used
by the peers.

Since PMTU discovery will immediately trigger UDP communication from both sides
to each other, this should allow direct communication between peers behind
full, address-restricted and port-restricted cone NAT.

13 years agoBe liberal in accepting KEY_CHANGED/REQ_KEY/ANS_KEY requests.
Guus Sliepen [Sat, 23 Jan 2010 17:48:01 +0000 (18:48 +0100)]
Be liberal in accepting KEY_CHANGED/REQ_KEY/ANS_KEY requests.

When we got a key request for or from a node we don't know, we disconnected the
node that forwarded us that request.  However, especially in TunnelServer mode,
disconnecting does not help. We now ignore such requests, but since there is no
way of telling the original sender that the request was dropped, we now retry
sending REQ_KEY requests when we don't get an ANS_KEY back.

13 years agoRun subnet-up/down scripts for local MAC addresses as well.
Guus Sliepen [Fri, 22 Jan 2010 20:59:40 +0000 (21:59 +0100)]
Run subnet-up/down scripts for local MAC addresses as well.

13 years agoFix subnet-up/down scripts being called with an empty SUBNET.
Guus Sliepen [Fri, 22 Jan 2010 20:47:26 +0000 (21:47 +0100)]
Fix subnet-up/down scripts being called with an empty SUBNET.

Commit 052ff8b2c598358d1c5febaa9f9f5fc5d384cfd3 contained a bug that causes
scripts to be called with an empty, or possibly corrupted SUBNET variable when
a Subnet is added or removed while the owner is still online. In router mode,
this normally does not happen, but in switch mode this is normal.

13 years agoMake MSS clamping configurable, but enabled by default.
Guus Sliepen [Sat, 16 Jan 2010 19:16:33 +0000 (20:16 +0100)]
Make MSS clamping configurable, but enabled by default.

It can either be set globally in tinc.conf, or per-node in host config files.

13 years agoAlso clamp MSS of TCP over IPv6 packets.
Guus Sliepen [Sat, 16 Jan 2010 18:32:33 +0000 (19:32 +0100)]
Also clamp MSS of TCP over IPv6 packets.

13 years agoOptimise handling of select() returning <= 0.
Guus Sliepen [Fri, 15 Jan 2010 22:41:14 +0000 (23:41 +0100)]
Optimise handling of select() returning <= 0.

Before, we immediately retried select() if it returned -1 and errno is EAGAIN
or EINTR, and if it returned 0 it would check for network events even if we
know there are none.  Now, if -1 or 0 is returned we skip checking network
events, but we do check for timer and signal events.

13 years agoPing nodes immediately when receiving SIGALRM.
Guus Sliepen [Fri, 15 Jan 2010 22:19:08 +0000 (23:19 +0100)]
Ping nodes immediately when receiving SIGALRM.

One reason to send the ALRM signal is to let tinc immediately try to connect to
outgoing nodes, for example when PPP or DHCP configuration of the outgoing
interface finished.  Conversely, when the outgoing interface goes down one can
now send this signal to let tinc quickly detect that links are down too.

13 years agoClamp MSS of IPv4 SYN packets.
Guus Sliepen [Fri, 15 Jan 2010 12:42:37 +0000 (13:42 +0100)]
Clamp MSS of IPv4 SYN packets.

Some ISPs block the ICMP Fragmentation Needed packets that tinc sends.  We
clamp the MSS of IPv4 SYN packets to prevent hosts behind those ISPs from
sending too large packets.

13 years agoAllow Port and PMTUDiscovery options in tinc.conf, always enable PMTUDiscovery by...
Guus Sliepen [Thu, 24 Dec 2009 11:42:21 +0000 (12:42 +0100)]
Allow Port and PMTUDiscovery options in tinc.conf, always enable PMTUDiscovery by default.

13 years agoUse xstrdup() instead of xasprintf() to copy static strings.
Guus Sliepen [Wed, 23 Dec 2009 18:51:55 +0000 (19:51 +0100)]
Use xstrdup() instead of xasprintf() to copy static strings.

13 years agoAllow port to be specified in Address statements.
Guus Sliepen [Wed, 23 Dec 2009 18:49:38 +0000 (19:49 +0100)]
Allow port to be specified in Address statements.

This allows one to connect to use more than one port number to connect to
another node. The syntax is now:

Address = <hostname> [<port>]

13 years agoDo not fragment packets smaller than RFC defined minimum MTUs.
Guus Sliepen [Wed, 23 Dec 2009 18:22:06 +0000 (19:22 +0100)]
Do not fragment packets smaller than RFC defined minimum MTUs.

For IPv6, the minimum MTU is 1280 (RFC 2460), for IPv4 the minimum is actually
68, but this is such a low limit that it will probably hurt performance, so we
do as if it is 576 (the minimum packet size hosts should be able to handle, RFC
791). If we detect a path MTU smaller than those minima, and we have to handle
a packet that is bigger than the PMTU but smaller than those minima, we forward
them via TCP instead of fragmenting or returning ICMP packets.

13 years agoForget addresses of unreachable nodes.
Guus Sliepen [Tue, 8 Dec 2009 22:18:37 +0000 (22:18 +0000)]
Forget addresses of unreachable nodes.

We clear the cached address used for UDP connections when a node becomes
unreachable. This also prevents host-up scripts from passing the old, cached
address from when the host becomes reachable again from a different address.

14 years agoRemove unused variable in lookup_subnet_*() functions.
Guus Sliepen [Sat, 28 Nov 2009 11:56:13 +0000 (11:56 +0000)]
Remove unused variable in lookup_subnet_*() functions.

14 years agoWhen learning MAC addresses, only check our own Subnets for previous entries.
Guus Sliepen [Sat, 28 Nov 2009 11:52:23 +0000 (11:52 +0000)]
When learning MAC addresses, only check our own Subnets for previous entries.

Before it would check all addresses, and not learn an address if another node
already claimed that address. This caused fast roaming to fail, the code from
commit 6f6f426b353596edca77829c0477268fc2fc1925 was never triggered.

14 years agoReleasing 1.0.11. release-1.0.11
Guus Sliepen [Sun, 1 Nov 2009 15:24:39 +0000 (16:24 +0100)]
Releasing 1.0.11.

14 years agoStart a tinc service if it already exists.
Guus Sliepen [Sun, 1 Nov 2009 14:57:28 +0000 (15:57 +0100)]
Start a tinc service if it already exists.

14 years agoFast handoff of roaming MAC addresses.
Guus Sliepen [Tue, 27 Oct 2009 22:53:49 +0000 (23:53 +0100)]
Fast handoff of roaming MAC addresses.

In switch mode, if a known MAC address is claimed by a second node before it
expired at the first node, it is likely that this is because a computer has
roamed from the LAN of the first node to that of the second node. To ensure
packets for that computer are routed to the second node, the first node should
delete its corresponding Subnet as soon as possible, without waiting for the
normal expiry timeout.

14 years agoMove socket error interpretation to utils.h.
Guus Sliepen [Sat, 24 Oct 2009 23:40:07 +0000 (01:40 +0200)]
Move socket error interpretation to utils.h.

14 years agoUse WSAGetLastError() to determine cause of network errors on Windows.
Guus Sliepen [Sat, 24 Oct 2009 22:50:09 +0000 (00:50 +0200)]
Use WSAGetLastError() to determine cause of network errors on Windows.

This reduces log spam and lets path MTU discovery work faster.

14 years agoRemove localedir leftovers.
Michael Tokarev [Sun, 18 Oct 2009 17:27:24 +0000 (21:27 +0400)]
Remove localedir leftovers.

14 years agoUse IP_DONTFRAGMENT instead of IP_MTU_DISCOVER on Windows.
Guus Sliepen [Sat, 24 Oct 2009 20:32:35 +0000 (22:32 +0200)]
Use IP_DONTFRAGMENT instead of IP_MTU_DISCOVER on Windows.

This ensures the DF bit on outgoing UDP packets gets set on Windows when path
MTU discovery is enabled, reducing fragmentation.

14 years agoForward packets to not directly reachable hosts via UDP if possible.
Guus Sliepen [Sat, 24 Oct 2009 19:53:01 +0000 (21:53 +0200)]
Forward packets to not directly reachable hosts via UDP if possible.

If MTU probing discovered a node was not reachable via UDP, packets for it were
forwarded to the next hop, but always via TCP, even if the next hop was
reachable via UDP. This is now fixed by retrying to send the packet using
send_packet() if the destination is not the same as the nexthop.

14 years agoMake maxmtu equal to minmtu when fixing the path MTU to a node.
Guus Sliepen [Sat, 24 Oct 2009 19:35:40 +0000 (21:35 +0200)]
Make maxmtu equal to minmtu when fixing the path MTU to a node.

This ensures MTU probes used to ping nodes are not too large, and prevents
restarting MTU probing unnecessarily.

14 years agoAlways reply to MTU probes via UDP.
Guus Sliepen [Sat, 24 Oct 2009 19:32:06 +0000 (21:32 +0200)]
Always reply to MTU probes via UDP.

It could sometime happen that a node would return MTU probes via TCP, which
does not make a lot of sense.

14 years agoAllow UDP packets with an address different from the corresponding TCP connection.
Guus Sliepen [Sat, 24 Oct 2009 18:54:44 +0000 (20:54 +0200)]
Allow UDP packets with an address different from the corresponding TCP connection.

14 years agoUse uint32_t instead of long int for connection options.
Guus Sliepen [Sat, 24 Oct 2009 14:15:24 +0000 (16:15 +0200)]
Use uint32_t instead of long int for connection options.

Options should have a fixed width anyway, but this also fixes a possible MinGW
compiler bug where %lx tries to print a 64 bit value, even though a long int is
only 32 bits.

14 years agoAdd dummy device.
Guus Sliepen [Sat, 24 Oct 2009 14:05:12 +0000 (16:05 +0200)]
Add dummy device.

14 years agoClarify and increase level of log message about MTU probes to unreachable nodes.
Guus Sliepen [Tue, 20 Oct 2009 20:39:07 +0000 (22:39 +0200)]
Clarify and increase level of log message about MTU probes to unreachable nodes.

14 years agoHandle weighted Subnets in switch and hub modes.
Guus Sliepen [Tue, 20 Oct 2009 20:33:16 +0000 (22:33 +0200)]
Handle weighted Subnets in switch and hub modes.

We now handle MAC Subnets in exactly the same way as IPv4 and IPv6 Subnets.
This also fixes a problem that causes unncessary broadcasting of unicast
packets in VPNs where some daemons run 1.0.10 and some run other versions.

14 years agoStarting to work towards 1.0.11.
Guus Sliepen [Tue, 20 Oct 2009 20:22:59 +0000 (22:22 +0200)]
Starting to work towards 1.0.11.

14 years agoFix a possible crash when sending the HUP signal.
Guus Sliepen [Tue, 20 Oct 2009 20:14:47 +0000 (22:14 +0200)]
Fix a possible crash when sending the HUP signal.

When the HUP signal is sent while some outgoing connections have not been made
yet, or are being retried, a NULL pointer could be dereferenced resulting in
tinc crashing. We fix this by more careful handling of outgoing_ts, and by
deleting all connections that have not been fully activated yet at the HUP
signal is received.

14 years agoReleasing 1.0.10. release-1.0.10
Guus Sliepen [Sun, 18 Oct 2009 14:45:13 +0000 (16:45 +0200)]
Releasing 1.0.10.

14 years agoFix description of the WEIGHT environment variable.
Guus Sliepen [Sun, 18 Oct 2009 14:44:32 +0000 (16:44 +0200)]
Fix description of the WEIGHT environment variable.

14 years agoInclude missing header.
Guus Sliepen [Sun, 18 Oct 2009 12:22:20 +0000 (14:22 +0200)]
Include missing header.

14 years agoRemove debugging message when reading packets from a BSD device.
Guus Sliepen [Mon, 12 Oct 2009 21:51:57 +0000 (23:51 +0200)]
Remove debugging message when reading packets from a BSD device.

This was inadvertently introduced by commit

14 years agoAllow the cloning /dev/tap interface to be used on FreeBSD and NetBSD.
Guus Sliepen [Mon, 12 Oct 2009 20:14:47 +0000 (22:14 +0200)]
Allow the cloning /dev/tap interface to be used on FreeBSD and NetBSD.

This device works like /dev/tun on Linux, automatically creating a new tap
interface when a program opens it. We now pass the actual name of the newly
created interface in $INTERFACE.

14 years agoUse MTU probes to regularly ping other nodes over UDP.
Guus Sliepen [Sun, 11 Oct 2009 16:57:58 +0000 (18:57 +0200)]
Use MTU probes to regularly ping other nodes over UDP.

This keeps NAT mappings for UDP alive, and will also detect when a node is not
reachable via UDP anymore or if the path MTU is decreasing. Tinc will fall back
to TCP if the node has become unreachable.

If UDP communication is impossible, we stop sending probes, but we retry if it
changes its keys.

We also decouple the UDP and TCP ping mechanisms completely, to ensure tinc
properly detects failure of either method.

14 years agoSmall updates to the documentation.
Guus Sliepen [Sun, 11 Oct 2009 13:46:52 +0000 (15:46 +0200)]
Small updates to the documentation.

Mention that TCPOnly is not necessary anymore since tinc will autodetect
whether it can send via UDP or not. Also mention the WEIGHT environment
variable and the new default value (2048 bits) of RSA keys.

14 years agoEnsure that the texinfo manual can be converted to HTML.
Guus Sliepen [Sun, 11 Oct 2009 12:20:14 +0000 (14:20 +0200)]
Ensure that the texinfo manual can be converted to HTML.

The top node was made conditional with the @iftex command, since it should not
appear in PostScript and PDF output. However, it is still necessary for
texi2html, so we have to use @ifnottex instead.

Texi2html also complains about the use of @cindex in the copyright statement,
so we remove that.

14 years agoRevert "Raise default crypto algorithms to AES256 and SHA256."
Guus Sliepen [Sun, 11 Oct 2009 11:56:04 +0000 (13:56 +0200)]
Revert "Raise default crypto algorithms to AES256 and SHA256."

Although it would be better to have the new defaults, only the most recent
releases of most of the platforms supported by tinc come with a version of
OpenSSL that supports SHA256. To ensure people can compile tinc and that nodes
can interact with each other, we revert the default back to Blowfish and SHA1.

This reverts commit 4bb3793e38b7c7f24dd308801e7f6dbb02cf02d2.

14 years agoRemove code duplication when checking ADD_EDGE/DEL_EDGE messages.
Guus Sliepen [Sun, 11 Oct 2009 11:54:05 +0000 (13:54 +0200)]
Remove code duplication when checking ADD_EDGE/DEL_EDGE messages.

14 years agoDon't disconnect clients in TunnelServer mode who send unauthorised ADD_SUBNETs.
Guus Sliepen [Sun, 11 Oct 2009 11:51:10 +0000 (13:51 +0200)]
Don't disconnect clients in TunnelServer mode who send unauthorised ADD_SUBNETs.

So that we are liberal in what we accept.

14 years agoRemoved last gettext function.
Borg [Sat, 3 Oct 2009 11:06:00 +0000 (13:06 +0200)]
Removed last gettext function.

14 years agoRemove autogenerated files from EXTRA_DIST.
Guus Sliepen [Tue, 29 Sep 2009 14:25:20 +0000 (16:25 +0200)]
Remove autogenerated files from EXTRA_DIST.

Apparently they were once necessary, but autoconf now includes them
automatically.  Some of them are not used anymore, and this caused make dist to

14 years agoUpdate the NEWS.
Guus Sliepen [Sat, 26 Sep 2009 10:51:52 +0000 (12:51 +0200)]
Update the NEWS.

14 years agoAdd more authors to the copyright headers.
Guus Sliepen [Fri, 25 Sep 2009 19:14:56 +0000 (21:14 +0200)]
Add more authors to the copyright headers.

Git's log and blame tools were used to find out which files had significant
contributions from authors who sent in patches that were applied before we used

14 years agoDrop support for localisation.
Guus Sliepen [Thu, 24 Sep 2009 22:54:07 +0000 (00:54 +0200)]
Drop support for localisation.

Localised messages don't make much sense for a daemon, and there is only the
Dutch translation which costs time to maintain.

14 years agoRemove checkpoint tracing.
Guus Sliepen [Thu, 24 Sep 2009 22:33:04 +0000 (00:33 +0200)]
Remove checkpoint tracing.

This feature is not necessary anymore since we have tools like valgrind today
that can catch stack overflow errors before they make a backtrace in gdb

14 years agoK&R style braces.
Guus Sliepen [Thu, 24 Sep 2009 22:14:03 +0000 (00:14 +0200)]
K&R style braces.

This is essentially commit f02d3ed3e135b5326003e7f69f8331ff6a3cc219 from the
1.1 branch, making it easier to merge between master and 1.1.

14 years agoUpdate the address of the Free Software Foundation in all copyright headers.
Guus Sliepen [Thu, 24 Sep 2009 22:01:00 +0000 (00:01 +0200)]
Update the address of the Free Software Foundation in all copyright headers.

14 years agoRemove Ivo's old email addresses.
Guus Sliepen [Thu, 24 Sep 2009 21:42:30 +0000 (23:42 +0200)]
Remove Ivo's old email addresses.

14 years agoRemove all occurences of $Id$.
Guus Sliepen [Thu, 24 Sep 2009 21:39:16 +0000 (23:39 +0200)]
Remove all occurences of $Id$.

14 years agoUpdate copyright information.
Guus Sliepen [Thu, 24 Sep 2009 21:29:46 +0000 (23:29 +0200)]
Update copyright information.

- Update year numbers in copyright headers.
- Add copyright information for Michael Tokarev and Florian Forster to the
  copyright headers of files to which they have contributed significantly.
- Mention Michael and Florian in AUTHORS.
- Mention that tinc is GPLv3 or later if compiled with the --enable-tunemu

14 years agoSend large packets we cannot handle properly via TCP.
Guus Sliepen [Tue, 15 Sep 2009 21:22:13 +0000 (23:22 +0200)]
Send large packets we cannot handle properly via TCP.

During the path MTU discovery phase, we might not know the maximum MTU yet, but
we do know a safe minimum.  If we encounter a packet that is larger than that
the minimum, we now send it via TCP instead to ensure it arrives.  We also
allow large packets that we cannot fragment or create ICMP replies for to be
sent via TCP.

14 years agoRaise default RSA key length to 2048 bits.
Guus Sliepen [Tue, 15 Sep 2009 21:04:52 +0000 (23:04 +0200)]
Raise default RSA key length to 2048 bits.

14 years agoUse a mutex to allow the TAP reader to process packets faster on Windows.
Guus Sliepen [Tue, 15 Sep 2009 20:59:01 +0000 (22:59 +0200)]
Use a mutex to allow the TAP reader to process packets faster on Windows.

The TAP-Win32 device is not a socket, and select() under Windows only works
with sockets.  Tinc used a separate thread to read from the TAP-Win32 device,
and passed this via a local socket to the main thread which could then select()
from it. We now use a global mutex, which is only unlocked when the main thread
is waiting for select(), to allow the TAP reader thread to process packets

14 years agoRemove extra {.
Guus Sliepen [Tue, 15 Sep 2009 20:58:16 +0000 (22:58 +0200)]
Remove extra {.

14 years agoRaise default crypto algorithms to AES256 and SHA256.
Guus Sliepen [Tue, 15 Sep 2009 10:08:05 +0000 (12:08 +0200)]
Raise default crypto algorithms to AES256 and SHA256.

In light of the recent improvements of attacks on SHA1, the default hash
algorithm in tinc is now SHA256. At the same time, the default symmetric
encryption algorithm has been changed to AES256.

14 years agoUse access() instead of stat() for checking whether scripts exist.
Guus Sliepen [Mon, 14 Sep 2009 22:36:07 +0000 (00:36 +0200)]
Use access() instead of stat() for checking whether scripts exist.

14 years agoRemove dropin random() function, as it is not used anymore.
Guus Sliepen [Mon, 14 Sep 2009 22:28:20 +0000 (00:28 +0200)]
Remove dropin random() function, as it is not used anymore.

14 years agoAllow compiling for Windows XP and higher.
Guus Sliepen [Mon, 14 Sep 2009 22:24:31 +0000 (00:24 +0200)]
Allow compiling for Windows XP and higher.

This allows us to use getaddrinfo(), getnameinfo() and related functions, which
allow tinc to make connections over existing IPv6 networks. These functions are
not available on Windows 2000 however. By default, support is enabled, but when
compiling for Windows 2000 the configure switch --with-windows2000 should be

Since getaddrinfo() et al. are not functions but macros on Windows, we have to
use AC_CHECK_DECLS() instead of AC_CHECK_FUNCS() in configure.in.

14 years agoAlso do not use drand48(), it is not available on Windows.
Guus Sliepen [Mon, 14 Sep 2009 21:28:28 +0000 (23:28 +0200)]
Also do not use drand48(), it is not available on Windows.

14 years agoUse only rand(), not random().
Guus Sliepen [Mon, 14 Sep 2009 21:06:00 +0000 (23:06 +0200)]
Use only rand(), not random().

We used both rand() and random() in our code. Since it returns an int, we have
to use %x in our format strings instead of %lx. This fixes a crash under
Windows when cross-compiling tinc with a recent version of MinGW.

14 years agoApparently it's impolite to ask GCC to subtract two pointers.
Guus Sliepen [Sun, 13 Sep 2009 12:08:59 +0000 (14:08 +0200)]
Apparently it's impolite to ask GCC to subtract two pointers.

If two pointers do not belong to the same array, pointer subtraction gives
nonsensical results, depending on the level of optimisation and the
architecture one is compiling for. It is apparently not just subtracting the
pointer values and dividing by the size of the object, but uses some kind of
higher magic not intended for mere mortals. GCC will not warn about this at
all. Casting to void * is also a no-no, because then GCC does warn that strict
aliasing rules are being broken. The only safe way to query the ordering of two
pointers is to use the (in)equality operators.

The unsafe implementation of connection_compare() has probably caused the "old
connection_t for ... still lingering" messages. Our implementation of AVL trees
is augmented with a doubly linked list, which is normally what is traversed.
Only when deleting an old connection the tree itself is traversed.

14 years agoRemove superfluous call to avl_delete().
Guus Sliepen [Sun, 13 Sep 2009 12:07:40 +0000 (14:07 +0200)]
Remove superfluous call to avl_delete().

14 years agoHandle unicast packets larger than PMTU in switch mode.
Guus Sliepen [Sat, 12 Sep 2009 12:19:36 +0000 (14:19 +0200)]
Handle unicast packets larger than PMTU in switch mode.

If PMTUDiscovery is enabled, and we see a unicast packet that is larger than
the path MTU in switch mode, treat it just like we would do in router mode.

14 years agoAllow PMTUDiscovery in switch and hub modes again.
Guus Sliepen [Sat, 12 Sep 2009 11:40:32 +0000 (13:40 +0200)]
Allow PMTUDiscovery in switch and hub modes again.

PMTUDiscovery was disabled in commit d5b56bbba56480b5565ffb38496175a7c1df60ac
because tinc did not handle packets larger than the path MTU in switch and hub
modes. We now allow it again in preparation of proper support, but default to

14 years agoPut Subnet weight in a separate environment variable.
Guus Sliepen [Sat, 12 Sep 2009 11:34:11 +0000 (13:34 +0200)]
Put Subnet weight in a separate environment variable.

Commit 5674bba5c54c1aee3a4ac5b3aba6b3ebded91bbc introduced weighted Subnets,
but the weight was included in the SUBNET variable passed to subnet-up/down
scripts. This makes it harder to use in those scripts. The weight is now
stripped from the SUBNET variable and put in the WEIGHT variabel.