bugfix: initialize pid (as read from pidfile) to zero
authorMichael Tokarev <mjt@corpit.ru>
Mon, 18 May 2009 12:28:55 +0000 (16:28 +0400)
committerGuus Sliepen <guus@sliepen.eu.org>
Mon, 18 May 2009 12:34:24 +0000 (14:34 +0200)
If we didn't read any number from a pid file, we'll return
an unitialized variable to the caller, and it will treat
that garbage as a pid of a process (possible to kill).

Fix that.

lib/pidfile.c

index 830d3f358d6a08c65404f193b89e1e9a6066b879..426cbf392c10d903add23a1ae130fd9e4b96bfb7 100644 (file)
@@ -37,7 +37,7 @@
 pid_t read_pid (char *pidfile)
 {
   FILE *f;
-  long pid;
+  long pid = 0;
 
   if (!(f=fopen(pidfile,"r")))
     return 0;