Using alloca() for a constant sized buffer is very silly.
authorGuus Sliepen <guus@tinc-vpn.org>
Sat, 10 Nov 2012 22:13:05 +0000 (23:13 +0100)
committerGuus Sliepen <guus@tinc-vpn.org>
Wed, 14 Nov 2012 10:12:55 +0000 (11:12 +0100)
Cppcheck said using alloca() in the 21st century is silly anyway.

src/net_setup.c

index 3e435ddaebfd87b125f016298f10ead62aa1381d..ddb0bcfd7f2fdc32c53ddc598c7577a8cee08bfc 100644 (file)
@@ -299,7 +299,7 @@ char *get_name(void) {
                                fprintf(stderr, "Invalid Name: environment variable %s does not exist\n", name + 1);
                                return false;
                        }
-                       envname = alloca(32);
+                       char envname[32];
                        if(gethostname(envname, 32)) {
                                fprintf(stderr, "Could not get hostname: %s\n", strerror(errno));
                                return false;