instance: Fix instance_config_move_strdup() function

instance_config_move_strdup() previously returned too early in case of
a value being previously unassigned.

Fixes: 153820c ("instance: fix pidfile and seccomp attributes double free")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>

diff --git a/service/instance.c b/service/instance.c
index ee258687c3cf8f1202a01d848c88217b2a793fdb..14da86247c7087f476bcfa6435c81fa006c24eee 100644 (file)
--- a/service/instance.c
+++ b/service/instance.c
@@ -1021,11 +1021,10 @@ instance_config_cleanup(struct service_instance *in)
 static void
 instance_config_move_strdup(char **dst, char *src)
 {
-       if (!*dst)
-               return;
-
-       free(*dst);
-       *dst = NULL;
+       if (*dst) {
+               free(*dst);
+               *dst = NULL;
+       }
 
        if (!src)
                return;