A previous attempt to fix the verison/revision split caused unterminated
strings to get stored in the blob buffer, properly fix this case now.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
int parse_version(pkg_t * pkg, const char *vstr)
{
int parse_version(pkg_t * pkg, const char *vstr)
{
+ char *colon, *dup, *rev;
if (strncmp(vstr, "Version:", 8) == 0)
vstr += 8;
if (strncmp(vstr, "Version:", 8) == 0)
vstr += 8;
- rev = strrchr(vstr, '-');
+
+ dup = xstrdup(vstr);
+ rev = strrchr(dup, '-');
- pkg_set_string(pkg, PKG_REVISION, rev + 1);
- pkg_set_raw(pkg, PKG_VERSION, vstr, rev - vstr - 1);
- } else {
- pkg_set_string(pkg, PKG_VERSION, vstr);
+ *rev++ = '\0';
+ pkg_set_string(pkg, PKG_REVISION, rev);
+ pkg_set_string(pkg, PKG_VERSION, dup);
+ free(dup);
+