X-Git-Url: https://git.librecmc.org/?p=oweals%2Fopkg-lede.git;a=blobdiff_plain;f=libopkg%2Fopkg_conf.c;h=4b2ad03bbb10498af65cdb2e367528d384bddebc;hp=cfee437032ff9c885d0cb83bd1e4620ca438db13;hb=94b0a6bec6a0d3301e28385ee3fdf4c19f67b866;hpb=64aa995bce735d74bf936aae7ae59a104f992ff2 diff --git a/libopkg/opkg_conf.c b/libopkg/opkg_conf.c index cfee437..4b2ad03 100644 --- a/libopkg/opkg_conf.c +++ b/libopkg/opkg_conf.c @@ -17,17 +17,25 @@ #include "includes.h" #include "opkg_conf.h" +#include "opkg_error.h" #include "xregex.h" #include "sprintf_alloc.h" -#include "opkg_conf.h" +#include "args.h" #include "opkg_message.h" #include "file_util.h" #include "str_util.h" #include "xsystem.h" -#include #include "opkg_defines.h" +#include "libbb/libbb.h" + +#include +#include +#include +#include +#include +extern char *conf_file_dir; static int opkg_conf_parse_file(opkg_conf_t *conf, const char *filename, pkg_src_list_t *pkg_src_list, @@ -42,41 +50,55 @@ static int set_and_load_pkg_src_list(opkg_conf_t *conf, static int set_and_load_pkg_dest_list(opkg_conf_t *conf, nv_pair_list_t *nv_pair_list, char * lists_dir); -int opkg_init_options_array(const opkg_conf_t *conf, opkg_option_t **options) +void opkg_init_options_array(const opkg_conf_t *conf, opkg_option_t **options) { opkg_option_t tmp[] = { + { "cache", OPKG_OPT_TYPE_STRING, &conf->cache}, { "force_defaults", OPKG_OPT_TYPE_BOOL, &conf->force_defaults }, + { "force_maintainer", OPKG_OPT_TYPE_BOOL, &conf->force_maintainer }, { "force_depends", OPKG_OPT_TYPE_BOOL, &conf->force_depends }, { "force_overwrite", OPKG_OPT_TYPE_BOOL, &conf->force_overwrite }, { "force_downgrade", OPKG_OPT_TYPE_BOOL, &conf->force_downgrade }, { "force_reinstall", OPKG_OPT_TYPE_BOOL, &conf->force_reinstall }, { "force_space", OPKG_OPT_TYPE_BOOL, &conf->force_space }, + { "check_signature", OPKG_OPT_TYPE_INT, &conf->check_signature }, { "ftp_proxy", OPKG_OPT_TYPE_STRING, &conf->ftp_proxy }, { "http_proxy", OPKG_OPT_TYPE_STRING, &conf->http_proxy }, - { "multiple_providers", OPKG_OPT_TYPE_BOOL, &conf->multiple_providers }, { "no_proxy", OPKG_OPT_TYPE_STRING, &conf->no_proxy }, { "test", OPKG_OPT_TYPE_INT, &conf->noaction }, { "noaction", OPKG_OPT_TYPE_INT, &conf->noaction }, { "nodeps", OPKG_OPT_TYPE_BOOL, &conf->nodeps }, { "offline_root", OPKG_OPT_TYPE_STRING, &conf->offline_root }, + { "offline_root_path", OPKG_OPT_TYPE_STRING, &conf->offline_root_path }, { "offline_root_post_script_cmd", OPKG_OPT_TYPE_STRING, &conf->offline_root_post_script_cmd }, { "offline_root_pre_script_cmd", OPKG_OPT_TYPE_STRING, &conf->offline_root_pre_script_cmd }, { "proxy_passwd", OPKG_OPT_TYPE_STRING, &conf->proxy_passwd }, { "proxy_user", OPKG_OPT_TYPE_STRING, &conf->proxy_user }, { "query-all", OPKG_OPT_TYPE_BOOL, &conf->query_all }, - { "verbose-wget", OPKG_OPT_TYPE_BOOL, &conf->verbose_wget }, { "verbosity", OPKG_OPT_TYPE_BOOL, &conf->verbosity }, +#if defined(HAVE_OPENSSL) + { "signature_ca_file", OPKG_OPT_TYPE_STRING, &conf->signature_ca_file }, + { "signature_ca_path", OPKG_OPT_TYPE_STRING, &conf->signature_ca_path }, +#endif +#if defined(HAVE_PATHFINDER) + { "check_x509_path", OPKG_OPT_TYPE_INT, &conf->check_x509_path }, +#endif +#if defined(HAVE_SSLCURL) && defined(HAVE_CURL) + { "ssl_engine", OPKG_OPT_TYPE_STRING, &conf->ssl_engine }, + { "ssl_cert", OPKG_OPT_TYPE_STRING, &conf->ssl_cert }, + { "ssl_cert_type", OPKG_OPT_TYPE_STRING, &conf->ssl_cert_type }, + { "ssl_key", OPKG_OPT_TYPE_STRING, &conf->ssl_key }, + { "ssl_key_type", OPKG_OPT_TYPE_STRING, &conf->ssl_key_type }, + { "ssl_key_passwd", OPKG_OPT_TYPE_STRING, &conf->ssl_key_passwd }, + { "ssl_ca_file", OPKG_OPT_TYPE_STRING, &conf->ssl_ca_file }, + { "ssl_ca_path", OPKG_OPT_TYPE_STRING, &conf->ssl_ca_path }, + { "ssl_dont_verify_peer", OPKG_OPT_TYPE_BOOL, &conf->ssl_dont_verify_peer }, +#endif { NULL } }; - *options = (opkg_option_t *)malloc(sizeof(tmp)); - if ( options == NULL ){ - fprintf(stderr,"%s: Unable to allocate memory\n",__FUNCTION__); - return -1; - } - + *options = xcalloc(1, sizeof(tmp)); memcpy(*options, tmp, sizeof(tmp)); - return 0; }; static void opkg_conf_override_string(char **conf_str, char *arg_str) @@ -85,7 +107,7 @@ static void opkg_conf_override_string(char **conf_str, char *arg_str) if (*conf_str) { free(*conf_str); } - *conf_str = strdup(arg_str); + *conf_str = xstrdup(arg_str); } } @@ -100,15 +122,20 @@ static void opkg_conf_free_string(char **conf_str) int opkg_conf_init(opkg_conf_t *conf, const args_t *args) { int err; + int errno_copy; char *tmp_dir_base; nv_pair_list_t tmp_dest_nv_pair_list; - char * lists_dir =NULL; + char *lists_dir = NULL, *lock_file = NULL; glob_t globbuf; - char *etc_opkg_conf_pattern = "/etc/opkg/*.conf"; - char *pending_dir =NULL; + char *etc_opkg_conf_pattern; + char *pending_dir = NULL; memset(conf, 0, sizeof(opkg_conf_t)); +#if defined(HAVE_PATHFINDER) + conf->check_x509_path = 1; +#endif + pkg_src_list_init(&conf->pkg_src_list); nv_pair_list_init(&tmp_dest_nv_pair_list); @@ -119,6 +146,29 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) conf->restrict_to_default_dest = 0; conf->default_dest = NULL; + /* check for lock file */ + if (args->offline_root) + sprintf_alloc (&lock_file, "%s/%s/lock", args->offline_root, OPKG_STATE_DIR_PREFIX); + else + sprintf_alloc (&lock_file, "%s/lock", OPKG_STATE_DIR_PREFIX); + + conf->lock_fd = creat (lock_file, S_IRUSR | S_IWUSR | S_IRGRP); + err = lockf (conf->lock_fd, F_TLOCK, 0); + errno_copy = errno; + + free (lock_file); + + if (err) + { + if(args->offline_root) { + opkg_message (conf, OPKG_ERROR, "Could not obtain administrative lock for offline root (ERR: %s) at %s/%s/lock\n", + strerror(errno_copy), args->offline_root, OPKG_STATE_DIR_PREFIX); + } else { + opkg_message (conf, OPKG_ERROR, "Could not obtain administrative lock (ERR: %s) at %s/lock\n", + strerror(errno_copy), OPKG_STATE_DIR_PREFIX); + } + return OPKG_CONF_ERR_LOCK; + } if (args->tmp_dir) tmp_dir_base = args->tmp_dir; @@ -131,36 +181,13 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if (conf->tmp_dir == NULL) { fprintf(stderr, "%s: Failed to create temporary directory `%s': %s\n", __FUNCTION__, conf->tmp_dir, strerror(errno)); - return errno; + return OPKG_CONF_ERR_TMP_DIR; } - conf->force_depends = 0; - conf->force_defaults = 0; - conf->force_overwrite = 0; - conf->force_downgrade = 0; - conf->force_reinstall = 0; - conf->force_space = 0; - conf->force_removal_of_essential_packages = 0; - conf->force_removal_of_dependent_packages = 0; - conf->nodeps = 0; - conf->verbose_wget = 0; - conf->offline_root = NULL; - conf->offline_root_pre_script_cmd = NULL; - conf->offline_root_post_script_cmd = NULL; - conf->multiple_providers = 0; - conf->verbosity = 1; - conf->noaction = 0; - - conf->http_proxy = NULL; - conf->ftp_proxy = NULL; - conf->no_proxy = NULL; - conf->proxy_user = NULL; - conf->proxy_passwd = NULL; - pkg_hash_init("pkg-hash", &conf->pkg_hash, OPKG_CONF_DEFAULT_HASH_LEN); hash_table_init("file-hash", &conf->file_hash, OPKG_CONF_DEFAULT_HASH_LEN); hash_table_init("obs-file-hash", &conf->obs_file_hash, OPKG_CONF_DEFAULT_HASH_LEN); - lists_dir=(char *)malloc(1); + lists_dir=xmalloc(1); lists_dir[0]='\0'; if (args->conf_file) { struct stat stat_buf; @@ -169,34 +196,35 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if (opkg_conf_parse_file(conf, args->conf_file, &conf->pkg_src_list, &tmp_dest_nv_pair_list,&lists_dir)<0) { /* Memory leakage from opkg_conf_parse-file */ - return -1; + return OPKG_CONF_ERR_PARSE; } - } - /* if (!lists_dir ){*/ if (strlen(lists_dir)<=1 ){ - lists_dir = realloc(lists_dir,strlen(OPKG_CONF_LISTS_DIR)+2); + lists_dir = xrealloc(lists_dir,strlen(OPKG_CONF_LISTS_DIR)+2); sprintf (lists_dir,"%s",OPKG_CONF_LISTS_DIR); } if (args->offline_root) { - char *tmp = malloc(strlen(lists_dir) + strlen(args->offline_root) + 1); + char *tmp; sprintf_alloc(&tmp, "%s/%s",args->offline_root,lists_dir); free(lists_dir); lists_dir = tmp; } - pending_dir = malloc(strlen(lists_dir)+strlen("/pending")+5); + pending_dir = xcalloc(1, strlen(lists_dir)+strlen("/pending")+5); snprintf(pending_dir,strlen(lists_dir)+strlen("/pending") ,"%s%s",lists_dir,"/pending"); - conf->lists_dir = strdup(lists_dir); - conf->pending_dir = strdup(pending_dir); + conf->lists_dir = xstrdup(lists_dir); + conf->pending_dir = xstrdup(pending_dir); if (args->offline_root) sprintf_alloc(&etc_opkg_conf_pattern, "%s/etc/opkg/*.conf", args->offline_root); + else + sprintf_alloc(&etc_opkg_conf_pattern, "%s/*.conf", conf_file_dir); memset(&globbuf, 0, sizeof(globbuf)); err = glob(etc_opkg_conf_pattern, 0, NULL, &globbuf); + free (etc_opkg_conf_pattern); if (!err) { int i; for (i = 0; i < globbuf.gl_pathc; i++) { @@ -204,7 +232,7 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if ( opkg_conf_parse_file(conf, globbuf.gl_pathv[i], &conf->pkg_src_list, &tmp_dest_nv_pair_list,&lists_dir)<0) { /* Memory leakage from opkg_conf_parse-file */ - return -1; + return OPKG_CONF_ERR_PARSE; } } } @@ -218,7 +246,7 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) } /* Even if there is no conf file, we'll need at least one dest. */ - if (tmp_dest_nv_pair_list.head == NULL) { + if (nv_pair_list_empty(&tmp_dest_nv_pair_list)) { nv_pair_list_append(&tmp_dest_nv_pair_list, OPKG_CONF_DEFAULT_DEST_NAME, OPKG_CONF_DEFAULT_DEST_ROOT_DIR); @@ -240,12 +268,18 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if (args->force_defaults) { conf->force_defaults = 1; } + if (args->force_maintainer) { + conf->force_maintainer = 1; + } if (args->force_overwrite) { conf->force_overwrite = 1; } if (args->force_downgrade) { conf->force_downgrade = 1; } + if (args->force_space) { + conf->force_space = 1; + } if (args->force_reinstall) { conf->force_reinstall = 1; } @@ -264,23 +298,21 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if (args->query_all) { conf->query_all = 1; } - if (args->verbose_wget) { - conf->verbose_wget = 1; - } - if (args->multiple_providers) { - conf->multiple_providers = 1; - } if (args->verbosity != conf->verbosity) { conf->verbosity = args->verbosity; } opkg_conf_override_string(&conf->offline_root, args->offline_root); + opkg_conf_override_string(&conf->offline_root_path, + args->offline_root_path); opkg_conf_override_string(&conf->offline_root_pre_script_cmd, args->offline_root_pre_script_cmd); opkg_conf_override_string(&conf->offline_root_post_script_cmd, args->offline_root_post_script_cmd); + opkg_conf_override_string(&conf->cache, args->cache); + /* Pigi: added a flag to disable the checking of structures if the command does not need to read anything from there. */ @@ -297,7 +329,7 @@ int opkg_conf_init(opkg_conf_t *conf, const args_t *args) if (args->dest) { err = opkg_conf_set_default_dest(conf, args->dest); if (err) { - return err; + return OPKG_CONF_ERR_DEFAULT_DEST; } } } @@ -332,21 +364,36 @@ void opkg_conf_deinit(opkg_conf_t *conf) #endif /* OPKG_DEBUG_NO_TMP_CLEANUP */ free(conf->tmp_dir); /*XXX*/ + free(conf->lists_dir); + free(conf->pending_dir); pkg_src_list_deinit(&conf->pkg_src_list); pkg_dest_list_deinit(&conf->pkg_dest_list); nv_pair_list_deinit(&conf->arch_list); - if (&conf->pkg_hash) - pkg_hash_deinit(&conf->pkg_hash); - if (&conf->file_hash) - hash_table_deinit(&conf->file_hash); - if (&conf->obs_file_hash) - hash_table_deinit(&conf->obs_file_hash); opkg_conf_free_string(&conf->offline_root); + opkg_conf_free_string(&conf->offline_root_path); opkg_conf_free_string(&conf->offline_root_pre_script_cmd); opkg_conf_free_string(&conf->offline_root_post_script_cmd); + opkg_conf_free_string(&conf->cache); + +#if defined(HAVE_OPENSSL) + opkg_conf_free_string(&conf->signature_ca_file); + opkg_conf_free_string(&conf->signature_ca_path); +#endif + +#if defined(HAVE_SSLCURL) + opkg_conf_free_string(&conf->ssl_engine); + opkg_conf_free_string(&conf->ssl_cert); + opkg_conf_free_string(&conf->ssl_cert_type); + opkg_conf_free_string(&conf->ssl_key); + opkg_conf_free_string(&conf->ssl_key_type); + opkg_conf_free_string(&conf->ssl_key_passwd); + opkg_conf_free_string(&conf->ssl_ca_file); + opkg_conf_free_string(&conf->ssl_ca_path); +#endif + if (conf->verbosity > 1) { int i; hash_table_t *hashes[] = { @@ -372,9 +419,15 @@ void opkg_conf_deinit(opkg_conf_t *conf) } opkg_message(conf, OPKG_DEBUG, "hash_table[%s] n_buckets=%d n_elements=%d max_conflicts=%d n_conflicts=%d\n", hash->name, hash->n_entries, hash->n_elements, c, n_conflicts); - hash_table_deinit(hash); } } + + if (&conf->pkg_hash) + pkg_hash_deinit(&conf->pkg_hash); + if (&conf->file_hash) + hash_table_deinit(&conf->file_hash); + if (&conf->obs_file_hash) + hash_table_deinit(&conf->obs_file_hash); } static int opkg_conf_set_default_dest(opkg_conf_t *conf, @@ -383,8 +436,8 @@ static int opkg_conf_set_default_dest(opkg_conf_t *conf, pkg_dest_list_elt_t *iter; pkg_dest_t *dest; - for (iter = conf->pkg_dest_list.head; iter; iter = iter->next) { - dest = iter->data; + for (iter = void_list_first(&conf->pkg_dest_list); iter; iter = void_list_next(&conf->pkg_dest_list, iter)) { + dest = (pkg_dest_t *)iter->data; if (strcmp(dest->name, default_dest_name) == 0) { conf->default_dest = dest; conf->restrict_to_default_dest = 1; @@ -403,8 +456,8 @@ static int set_and_load_pkg_src_list(opkg_conf_t *conf, pkg_src_list_t *pkg_src_ pkg_src_t *src; char *list_file; - for (iter = pkg_src_list->head; iter; iter = iter->next) { - src = iter->data; + for (iter = void_list_first(pkg_src_list); iter; iter = void_list_next(pkg_src_list, iter)) { + src = (pkg_src_t *)iter->data; if (src == NULL) { continue; } @@ -429,13 +482,13 @@ static int set_and_load_pkg_dest_list(opkg_conf_t *conf, nv_pair_list_t *nv_pair pkg_dest_t *dest; char *root_dir; - for (iter = nv_pair_list->head; iter; iter = iter->next) { - nv_pair = iter->data; + for (iter = nv_pair_list_first(nv_pair_list); iter; iter = nv_pair_list_next(nv_pair_list, iter)) { + nv_pair = (nv_pair_t *)iter->data; if (conf->offline_root) { sprintf_alloc(&root_dir, "%s%s", conf->offline_root, nv_pair->value); } else { - root_dir = strdup(nv_pair->value); + root_dir = xstrdup(nv_pair->value); } dest = pkg_dest_list_append(&conf->pkg_dest_list, nv_pair->name, root_dir, lists_dir); free(root_dir); @@ -466,8 +519,7 @@ static int opkg_conf_parse_file(opkg_conf_t *conf, const char *filename, #define regmatch_size 12 regmatch_t regmatch[regmatch_size]; - if (opkg_init_options_array(conf, &options)<0) - return ENOMEM; + opkg_init_options_array(conf, &options); if (file == NULL) { fprintf(stderr, "%s: failed to open %s: %s\n", @@ -516,29 +568,29 @@ static int opkg_conf_parse_file(opkg_conf_t *conf, const char *filename, /* This has to be so ugly to deal with optional quotation marks */ if (regmatch[2].rm_so > 0) { - type = strndup(line + regmatch[2].rm_so, + type = xstrndup(line + regmatch[2].rm_so, regmatch[2].rm_eo - regmatch[2].rm_so); } else { - type = strndup(line + regmatch[3].rm_so, + type = xstrndup(line + regmatch[3].rm_so, regmatch[3].rm_eo - regmatch[3].rm_so); } if (regmatch[5].rm_so > 0) { - name = strndup(line + regmatch[5].rm_so, + name = xstrndup(line + regmatch[5].rm_so, regmatch[5].rm_eo - regmatch[5].rm_so); } else { - name = strndup(line + regmatch[6].rm_so, + name = xstrndup(line + regmatch[6].rm_so, regmatch[6].rm_eo - regmatch[6].rm_so); } if (regmatch[8].rm_so > 0) { - value = strndup(line + regmatch[8].rm_so, + value = xstrndup(line + regmatch[8].rm_so, regmatch[8].rm_eo - regmatch[8].rm_so); } else { - value = strndup(line + regmatch[9].rm_so, + value = xstrndup(line + regmatch[9].rm_so, regmatch[9].rm_eo - regmatch[9].rm_so); } extra = NULL; if (regmatch[11].rm_so > 0) { - extra = strndup (line + regmatch[11].rm_so, + extra = xstrndup (line + regmatch[11].rm_so, regmatch[11].rm_eo - regmatch[11].rm_so); } @@ -567,20 +619,15 @@ static int opkg_conf_parse_file(opkg_conf_t *conf, const char *filename, } else if (strcmp(type, "dest") == 0) { nv_pair_list_append(tmp_dest_nv_pair_list, name, value); } else if (strcmp(type, "lists_dir") == 0) { - *lists_dir = realloc(*lists_dir,strlen(value)+1); - if (*lists_dir == NULL) { - opkg_message(conf, OPKG_ERROR, "ERROR: Not enough memory\n"); - free(options); - return EINVAL; - } + *lists_dir = xrealloc(*lists_dir,strlen(value)+1); sprintf (*lists_dir,"%s",value); } else if (strcmp(type, "arch") == 0) { opkg_message(conf, OPKG_INFO, "supported arch %s priority (%s)\n", name, value); if (!value) { opkg_message(conf, OPKG_NOTICE, "defaulting architecture %s priority to 10\n", name); - value = strdup("10"); + value = xstrdup("10"); } - nv_pair_list_append(&conf->arch_list, strdup(name), strdup(value)); + nv_pair_list_append(&conf->arch_list, name, value); } else { fprintf(stderr, "WARNING: Ignoring unknown configuration " "parameter: %s %s %s\n", type, name, value); @@ -627,7 +674,7 @@ static int opkg_conf_set_option(const opkg_option_t *options, } case OPKG_OPT_TYPE_STRING: if (value) { - *((char **)options[i].value) = strdup(value); + *((char **)options[i].value) = xstrdup(value); return 0; } else { printf("%s: Option %s need an argument\n", @@ -646,22 +693,21 @@ static int opkg_conf_set_option(const opkg_option_t *options, int opkg_conf_write_status_files(opkg_conf_t *conf) { - pkg_dest_list_elt_t *iter; pkg_dest_t *dest; pkg_vec_t *all; pkg_t *pkg; - register int i; + int i; int err; + FILE * status_file=NULL; if (conf->noaction) return 0; - for (iter = conf->pkg_dest_list.head; iter; iter = iter->next) { - dest = iter->data; - dest->status_file = fopen(dest->status_file_tmp_name, "w"); - if (dest->status_file == NULL) { - fprintf(stderr, "%s: Can't open status file: %s for writing: %s\n", - __FUNCTION__, dest->status_file_name, strerror(errno)); - } + + dest = (pkg_dest_t *)void_list_first(&conf->pkg_dest_list)->data; + status_file = fopen(dest->status_file_tmp_name, "w"); + if (status_file == NULL) { + fprintf(stderr, "%s: Can't open status file: %s for writing: %s\n", + __FUNCTION__, dest->status_file_tmp_name, strerror(errno)); } all = pkg_vec_alloc(); @@ -676,38 +722,31 @@ int opkg_conf_write_status_files(opkg_conf_t *conf) || pkg->state_want == SW_PURGE)) { continue; } - if (!pkg) { - fprintf(stderr, "Null package\n"); - } if (pkg->dest == NULL) { fprintf(stderr, "%s: ERROR: Can't write status for " "package %s since it has a NULL dest\n", __FUNCTION__, pkg->name); continue; } - if (pkg->dest->status_file) { - pkg_print_status(pkg, pkg->dest->status_file); + if (status_file) { + pkg_print_status(pkg, status_file); } } pkg_vec_free(all); - for (iter = conf->pkg_dest_list.head; iter; iter = iter->next) { - dest = iter->data; - if (dest->status_file) { - err = ferror(dest->status_file); - fclose(dest->status_file); - dest->status_file = NULL; - if (!err) { - file_move(dest->status_file_tmp_name, dest->status_file_name); - } else { - fprintf(stderr, "%s: ERROR: An error has occurred writing %s, " - "retaining old %s\n", __FUNCTION__, - dest->status_file_tmp_name, dest->status_file_name); - } - } + if (status_file) { + err = ferror(status_file); + fclose(status_file); + if (!err) { + file_move(dest->status_file_tmp_name, dest->status_file_name); + } else { + fprintf(stderr, "%s: ERROR: An error has occurred writing %s, " + "retaining old %s\n", __FUNCTION__, + dest->status_file_tmp_name, dest->status_file_name); + } + status_file = NULL; } - return 0; }