libopkg: fix merging PKG_CONFFILES in pkg_merge()
[oweals/opkg-lede.git] / libopkg / pkg_hash.c
1 /* opkg_hash.c - the opkg package management system
2
3    Steven M. Ayer
4
5    Copyright (C) 2002 Compaq Computer Corporation
6
7    This program is free software; you can redistribute it and/or
8    modify it under the terms of the GNU General Public License as
9    published by the Free Software Foundation; either version 2, or (at
10    your option) any later version.
11
12    This program is distributed in the hope that it will be useful, but
13    WITHOUT ANY WARRANTY; without even the implied warranty of
14    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
15    General Public License for more details.
16 */
17
18 #include <stdio.h>
19
20 #include "hash_table.h"
21 #include "pkg.h"
22 #include "opkg_message.h"
23 #include "pkg_vec.h"
24 #include "pkg_hash.h"
25 #include "parse_util.h"
26 #include "pkg_parse.h"
27 #include "opkg_utils.h"
28 #include "sprintf_alloc.h"
29 #include "file_util.h"
30 #include "libbb/libbb.h"
31 #include "libbb/gzip.h"
32
33 void pkg_hash_init(void)
34 {
35         hash_table_init("pkg-hash", &conf->pkg_hash,
36                         OPKG_CONF_DEFAULT_HASH_LEN);
37 }
38
39 static void free_pkgs(const char *key, void *entry, void *data)
40 {
41         int i;
42         abstract_pkg_t *ab_pkg;
43
44         /* Each entry in the hash table is an abstract package, which contains
45          * a list of packages that provide the abstract package.
46          */
47
48         ab_pkg = (abstract_pkg_t *) entry;
49
50         if (ab_pkg->pkgs) {
51                 for (i = 0; i < ab_pkg->pkgs->len; i++) {
52                         pkg_deinit(ab_pkg->pkgs->pkgs[i]);
53                         free(ab_pkg->pkgs->pkgs[i]);
54                 }
55         }
56
57         abstract_pkg_vec_free(ab_pkg->provided_by);
58         abstract_pkg_vec_free(ab_pkg->replaced_by);
59         pkg_vec_free(ab_pkg->pkgs);
60         free(ab_pkg->depended_upon_by);
61         free(ab_pkg->name);
62         free(ab_pkg);
63 }
64
65 void pkg_hash_deinit(void)
66 {
67         hash_table_foreach(&conf->pkg_hash, free_pkgs, NULL);
68         hash_table_deinit(&conf->pkg_hash);
69 }
70
71 int dist_hash_add_from_file(const char *lists_dir, pkg_src_t * dist)
72 {
73         nv_pair_list_elt_t *l;
74         char *list_file, *subname;
75
76         list_for_each_entry(l, &conf->arch_list.head, node) {
77                 nv_pair_t *nv = (nv_pair_t *) l->data;
78                 sprintf_alloc(&subname, "%s-%s", dist->name, nv->name);
79                 sprintf_alloc(&list_file, "%s/%s", lists_dir, subname);
80
81                 if (file_exists(list_file)) {
82                         if (pkg_hash_add_from_file(list_file, dist, NULL, 0, 0)) {
83                                 free(list_file);
84                                 return -1;
85                         }
86                         pkg_src_list_append(&conf->pkg_src_list, subname,
87                                             dist->value, "__dummy__", 0);
88                 }
89
90                 free(list_file);
91         }
92
93         return 0;
94 }
95
96 int
97 pkg_hash_add_from_file(const char *file_name,
98                        pkg_src_t * src, pkg_dest_t * dest, int is_status_file, int state_flags)
99 {
100         pkg_t *pkg;
101         FILE *fp;
102         char *buf;
103         const size_t len = 4096;
104         int ret = 0;
105         struct gzip_handle zh;
106
107         if (src && src->gzip) {
108                 fp = gzip_fdopen(&zh, file_name);
109         } else {
110                 fp = fopen(file_name, "r");
111         }
112
113         if (fp == NULL) {
114                 opkg_perror(ERROR, "Failed to open %s", file_name);
115                 return -1;
116         }
117
118         buf = xmalloc(len);
119
120         do {
121                 pkg = pkg_new();
122                 pkg->src = src;
123                 pkg->dest = dest;
124                 pkg->state_flag |= state_flags;
125
126                 ret = parse_from_stream_nomalloc(pkg_parse_line, pkg, fp, 0,
127                                                  &buf, len);
128
129                 if (pkg->name == NULL) {
130                         /* probably just a blank line */
131                         ret = 1;
132                 }
133
134                 if (ret) {
135                         pkg_deinit(pkg);
136                         free(pkg);
137                         if (ret == -1)
138                                 break;
139                         if (ret == 1)
140                                 /* Probably a blank line, continue parsing. */
141                                 ret = 0;
142                         continue;
143                 }
144
145                 if (!pkg_get_architecture(pkg) || !pkg_get_arch_priority(pkg)) {
146                         char *version_str = pkg_version_str_alloc(pkg);
147                         opkg_msg(NOTICE, "Package %s version %s has no "
148                                  "valid architecture, ignoring.\n",
149                                  pkg->name, version_str);
150                         free(version_str);
151                         continue;
152                 }
153
154                 hash_insert_pkg(pkg, is_status_file);
155
156         } while (!feof(fp));
157
158         free(buf);
159         fclose(fp);
160
161         if (src && src->gzip)
162                 gzip_close(&zh);
163
164         return ret;
165 }
166
167 /*
168  * Load in feed files from the cached "src" and/or "src/gz" locations.
169  */
170 int pkg_hash_load_feeds(void)
171 {
172         pkg_src_list_elt_t *iter;
173         pkg_src_t *src, *subdist;
174         char *list_file, *lists_dir;
175
176         opkg_msg(INFO, "\n");
177
178         lists_dir = conf->restrict_to_default_dest ?
179             conf->default_dest->lists_dir : conf->lists_dir;
180
181         for (iter = void_list_first(&conf->pkg_src_list); iter;
182              iter = void_list_next(&conf->pkg_src_list, iter)) {
183
184                 src = (pkg_src_t *) iter->data;
185
186                 sprintf_alloc(&list_file, "%s/%s", lists_dir, src->name);
187
188                 if (file_exists(list_file)) {
189                         if (pkg_hash_add_from_file(list_file, src, NULL, 0, 0)) {
190                                 free(list_file);
191                                 return -1;
192                         }
193                 }
194                 free(list_file);
195         }
196
197         return 0;
198 }
199
200 /*
201  * Load in status files from the configured "dest"s.
202  */
203 int pkg_hash_load_status_files(void)
204 {
205         pkg_dest_list_elt_t *iter;
206         pkg_dest_t *dest;
207
208         opkg_msg(INFO, "\n");
209
210         for (iter = void_list_first(&conf->pkg_dest_list); iter;
211              iter = void_list_next(&conf->pkg_dest_list, iter)) {
212
213                 dest = (pkg_dest_t *) iter->data;
214
215                 if (file_exists(dest->status_file_name)) {
216                         if (pkg_hash_add_from_file
217                             (dest->status_file_name, NULL, dest, 1, SF_NEED_DETAIL))
218                                 return -1;
219                 }
220         }
221
222         return 0;
223 }
224
225 pkg_t *pkg_hash_fetch_best_installation_candidate(abstract_pkg_t * apkg,
226                                                   int (*constraint_fcn) (pkg_t *
227                                                                          pkg,
228                                                                          void
229                                                                          *cdata),
230                                                   void *cdata, int quiet)
231 {
232         int i, j;
233         int nprovides = 0;
234         int nmatching = 0;
235         int wrong_arch_found = 0;
236         int arch_priority;
237         pkg_vec_t *matching_pkgs;
238         abstract_pkg_vec_t *matching_apkgs;
239         abstract_pkg_vec_t *provided_apkg_vec;
240         abstract_pkg_t **provided_apkgs;
241         abstract_pkg_vec_t *providers;
242         pkg_t *latest_installed_parent = NULL;
243         pkg_t *latest_matching = NULL;
244         pkg_t *priorized_matching = NULL;
245         pkg_t *held_pkg = NULL;
246         pkg_t *good_pkg_by_name = NULL;
247
248         if (apkg == NULL || apkg->provided_by == NULL
249             || (apkg->provided_by->len == 0))
250                 return NULL;
251
252         matching_pkgs = pkg_vec_alloc();
253         matching_apkgs = abstract_pkg_vec_alloc();
254         providers = abstract_pkg_vec_alloc();
255
256         opkg_msg(DEBUG, "Best installation candidate for %s:\n", apkg->name);
257
258         provided_apkg_vec = apkg->provided_by;
259         nprovides = provided_apkg_vec->len;
260         provided_apkgs = provided_apkg_vec->pkgs;
261         if (nprovides > 1)
262                 opkg_msg(DEBUG, "apkg=%s nprovides=%d.\n", apkg->name,
263                          nprovides);
264
265         /* accumulate all the providers */
266         for (i = 0; i < nprovides; i++) {
267                 abstract_pkg_t *provider_apkg = provided_apkgs[i];
268                 opkg_msg(DEBUG, "Adding %s to providers.\n",
269                          provider_apkg->name);
270                 abstract_pkg_vec_insert(providers, provider_apkg);
271         }
272         nprovides = providers->len;
273
274         for (i = 0; i < nprovides; i++) {
275                 abstract_pkg_t *provider_apkg =
276                     abstract_pkg_vec_get(providers, i);
277                 abstract_pkg_t *replacement_apkg = NULL;
278                 pkg_vec_t *vec;
279
280                 if (provider_apkg->replaced_by
281                     && provider_apkg->replaced_by->len) {
282                         replacement_apkg = provider_apkg->replaced_by->pkgs[0];
283                         if (provider_apkg->replaced_by->len > 1) {
284                                 opkg_msg(NOTICE, "Multiple replacers for %s, "
285                                          "using first one (%s).\n",
286                                          provider_apkg->name,
287                                          replacement_apkg->name);
288                         }
289                 }
290
291                 if (replacement_apkg)
292                         opkg_msg(DEBUG,
293                                  "replacement_apkg=%s for provider_apkg=%s.\n",
294                                  replacement_apkg->name, provider_apkg->name);
295
296                 if (replacement_apkg && (replacement_apkg != provider_apkg)) {
297                         if (abstract_pkg_vec_contains
298                             (providers, replacement_apkg))
299                                 continue;
300                         else
301                                 provider_apkg = replacement_apkg;
302                 }
303
304                 if (!(vec = provider_apkg->pkgs)) {
305                         opkg_msg(DEBUG, "No pkgs for provider_apkg %s.\n",
306                                  provider_apkg->name);
307                         continue;
308                 }
309
310                 /* now check for supported architecture */
311                 {
312                         int max_count = 0;
313
314                         /* count packages matching max arch priority and keep track of last one */
315                         for (j = 0; j < vec->len; j++) {
316                                 pkg_t *maybe = vec->pkgs[j];
317                                 arch_priority = pkg_get_arch_priority(maybe);
318
319                                 opkg_msg(DEBUG,
320                                          "%s arch=%s arch_priority=%d version=%s.\n",
321                                          maybe->name, pkg_get_architecture(maybe),
322                                          arch_priority, pkg_get_string(maybe, PKG_VERSION));
323                                 /* We make sure not to add the same package twice. Need to search for the reason why
324                                    they show up twice sometimes. */
325                                 if ((arch_priority > 0)
326                                     &&
327                                     (!pkg_vec_contains(matching_pkgs, maybe))) {
328                                         max_count++;
329                                         abstract_pkg_vec_insert(matching_apkgs,
330                                                                 maybe->parent);
331                                         pkg_vec_insert(matching_pkgs, maybe);
332                                 }
333                         }
334
335                         if (vec->len > 0 && matching_pkgs->len < 1)
336                                 wrong_arch_found = 1;
337                 }
338         }
339
340         if (matching_pkgs->len < 1) {
341                 if (wrong_arch_found)
342                         opkg_msg(ERROR, "Packages for %s found, but"
343                                  " incompatible with the architectures configured\n",
344                                  apkg->name);
345                 pkg_vec_free(matching_pkgs);
346                 abstract_pkg_vec_free(matching_apkgs);
347                 abstract_pkg_vec_free(providers);
348                 return NULL;
349         }
350
351         if (matching_pkgs->len > 1)
352                 pkg_vec_sort(matching_pkgs,
353                              pkg_name_version_and_architecture_compare);
354         if (matching_apkgs->len > 1)
355                 abstract_pkg_vec_sort(matching_pkgs, abstract_pkg_name_compare);
356
357         for (i = 0; i < matching_pkgs->len; i++) {
358                 pkg_t *matching = matching_pkgs->pkgs[i];
359                 if (constraint_fcn(matching, cdata)) {
360                         opkg_msg(DEBUG, "Candidate: %s %s.\n",
361                                  matching->name, pkg_get_string(matching, PKG_VERSION));
362                         good_pkg_by_name = matching;
363                         /* It has been provided by hand, so it is what user want */
364                         if (matching->provided_by_hand == 1)
365                                 break;
366                 }
367         }
368
369         for (i = 0; i < matching_pkgs->len; i++) {
370                 pkg_t *matching = matching_pkgs->pkgs[i];
371                 latest_matching = matching;
372                 if (matching->parent->state_status == SS_INSTALLED
373                     || matching->parent->state_status == SS_UNPACKED)
374                         latest_installed_parent = matching;
375                 if (matching->state_flag & (SF_HOLD | SF_PREFER)) {
376                         if (held_pkg)
377                                 opkg_msg(NOTICE,
378                                          "Multiple packages (%s and %s) providing"
379                                          " same name marked HOLD or PREFER. "
380                                          "Using latest.\n", held_pkg->name,
381                                          matching->name);
382                         held_pkg = matching;
383                 }
384         }
385
386         if (!good_pkg_by_name && !held_pkg && !latest_installed_parent
387             && matching_apkgs->len > 1 && !quiet) {
388                 int prio = 0;
389                 for (i = 0; i < matching_pkgs->len; i++) {
390                         pkg_t *matching = matching_pkgs->pkgs[i];
391                         arch_priority = pkg_get_arch_priority(matching);
392                         if (arch_priority > prio) {
393                                 priorized_matching = matching;
394                                 prio = arch_priority;
395                                 opkg_msg(DEBUG, "Match %s with priority %i.\n",
396                                          matching->name, prio);
397                         }
398                 }
399
400         }
401
402         if (conf->verbosity >= INFO && matching_apkgs->len > 1) {
403                 opkg_msg(INFO, "%d matching pkgs for apkg=%s:\n",
404                          matching_pkgs->len, apkg->name);
405                 for (i = 0; i < matching_pkgs->len; i++) {
406                         pkg_t *matching = matching_pkgs->pkgs[i];
407                         opkg_msg(INFO, "%s %s %s\n",
408                                  matching->name, pkg_get_string(matching, PKG_VERSION),
409                                  pkg_get_architecture(matching));
410                 }
411         }
412
413         nmatching = matching_apkgs->len;
414
415         pkg_vec_free(matching_pkgs);
416         abstract_pkg_vec_free(matching_apkgs);
417         abstract_pkg_vec_free(providers);
418
419         if (good_pkg_by_name) { /* We found a good candidate, we will install it */
420                 return good_pkg_by_name;
421         }
422         if (held_pkg) {
423                 opkg_msg(INFO, "Using held package %s.\n", held_pkg->name);
424                 return held_pkg;
425         }
426         if (latest_installed_parent) {
427                 opkg_msg(INFO,
428                          "Using latest version of installed package %s.\n",
429                          latest_installed_parent->name);
430                 return latest_installed_parent;
431         }
432         if (priorized_matching) {
433                 opkg_msg(INFO, "Using priorized matching %s %s %s.\n",
434                          priorized_matching->name, pkg_get_string(priorized_matching, PKG_VERSION),
435                          pkg_get_architecture(priorized_matching));
436                 return priorized_matching;
437         }
438         if (nmatching > 1) {
439                 opkg_msg(INFO, "No matching pkg out of %d matching_apkgs.\n",
440                          nmatching);
441                 return NULL;
442         }
443         if (latest_matching) {
444                 opkg_msg(INFO, "Using latest matching %s %s %s.\n",
445                          latest_matching->name, pkg_get_string(latest_matching, PKG_VERSION),
446                          pkg_get_architecture(latest_matching));
447                 return latest_matching;
448         }
449         return NULL;
450 }
451
452 static int pkg_name_constraint_fcn(pkg_t * pkg, void *cdata)
453 {
454         const char *name = (const char *)cdata;
455
456         if (strcmp(pkg->name, name) == 0)
457                 return 1;
458         else
459                 return 0;
460 }
461
462 static pkg_vec_t *pkg_vec_fetch_by_name(const char *pkg_name)
463 {
464         abstract_pkg_t *ab_pkg;
465
466         if (!(ab_pkg = abstract_pkg_fetch_by_name(pkg_name)))
467                 return NULL;
468
469         if (ab_pkg->pkgs)
470                 return ab_pkg->pkgs;
471
472         if (ab_pkg->provided_by) {
473                 abstract_pkg_t *abpkg =
474                     abstract_pkg_vec_get(ab_pkg->provided_by, 0);
475                 if (abpkg != NULL)
476                         return abpkg->pkgs;
477                 else
478                         return ab_pkg->pkgs;
479         }
480
481         return NULL;
482 }
483
484 pkg_t *pkg_hash_fetch_best_installation_candidate_by_name(const char *name)
485 {
486         abstract_pkg_t *apkg = NULL;
487
488         if (!(apkg = abstract_pkg_fetch_by_name(name)))
489                 return NULL;
490
491         return pkg_hash_fetch_best_installation_candidate(apkg,
492                                                           pkg_name_constraint_fcn,
493                                                           apkg->name, 0);
494 }
495
496 pkg_t *pkg_hash_fetch_by_name_version(const char *pkg_name, const char *version)
497 {
498         pkg_vec_t *vec;
499         int i;
500         char *version_str = NULL;
501
502         if (!(vec = pkg_vec_fetch_by_name(pkg_name)))
503                 return NULL;
504
505         for (i = 0; i < vec->len; i++) {
506                 version_str = pkg_version_str_alloc(vec->pkgs[i]);
507                 if (!strcmp(version_str, version)) {
508                         free(version_str);
509                         break;
510                 }
511                 free(version_str);
512         }
513
514         if (i == vec->len)
515                 return NULL;
516
517         return vec->pkgs[i];
518 }
519
520 pkg_t *pkg_hash_fetch_installed_by_name_dest(const char *pkg_name,
521                                              pkg_dest_t * dest)
522 {
523         pkg_vec_t *vec;
524         int i;
525
526         if (!(vec = pkg_vec_fetch_by_name(pkg_name))) {
527                 return NULL;
528         }
529
530         for (i = 0; i < vec->len; i++)
531                 if ((vec->pkgs[i]->state_status == SS_INSTALLED
532                      || vec->pkgs[i]->state_status == SS_UNPACKED)
533                     && vec->pkgs[i]->dest == dest) {
534                         return vec->pkgs[i];
535                 }
536
537         return NULL;
538 }
539
540 pkg_t *pkg_hash_fetch_installed_by_name(const char *pkg_name)
541 {
542         pkg_vec_t *vec;
543         int i;
544
545         if (!(vec = pkg_vec_fetch_by_name(pkg_name))) {
546                 return NULL;
547         }
548
549         for (i = 0; i < vec->len; i++) {
550                 if (vec->pkgs[i]->state_status == SS_INSTALLED
551                     || vec->pkgs[i]->state_status == SS_UNPACKED) {
552                         return vec->pkgs[i];
553                 }
554         }
555
556         return NULL;
557 }
558
559 static void
560 pkg_hash_fetch_available_helper(const char *pkg_name, void *entry, void *data)
561 {
562         int j;
563         abstract_pkg_t *ab_pkg = (abstract_pkg_t *) entry;
564         pkg_vec_t *all = (pkg_vec_t *) data;
565         pkg_vec_t *pkg_vec = ab_pkg->pkgs;
566
567         if (!pkg_vec)
568                 return;
569
570         for (j = 0; j < pkg_vec->len; j++) {
571                 pkg_t *pkg = pkg_vec->pkgs[j];
572                 pkg_vec_insert(all, pkg);
573         }
574 }
575
576 void pkg_hash_fetch_available(pkg_vec_t * all)
577 {
578         hash_table_foreach(&conf->pkg_hash, pkg_hash_fetch_available_helper,
579                            all);
580 }
581
582 static void
583 pkg_hash_fetch_all_installed_helper(const char *pkg_name, void *entry,
584                                     void *data)
585 {
586         abstract_pkg_t *ab_pkg = (abstract_pkg_t *) entry;
587         pkg_vec_t *all = (pkg_vec_t *) data;
588         pkg_vec_t *pkg_vec = ab_pkg->pkgs;
589         int j;
590
591         if (!pkg_vec)
592                 return;
593
594         for (j = 0; j < pkg_vec->len; j++) {
595                 pkg_t *pkg = pkg_vec->pkgs[j];
596                 if (pkg->state_status == SS_INSTALLED
597                     || pkg->state_status == SS_UNPACKED)
598                         pkg_vec_insert(all, pkg);
599         }
600 }
601
602 void pkg_hash_fetch_all_installed(pkg_vec_t * all)
603 {
604         hash_table_foreach(&conf->pkg_hash, pkg_hash_fetch_all_installed_helper,
605                            all);
606 }
607
608 /*
609  * This assumes that the abstract pkg doesn't exist.
610  */
611 static abstract_pkg_t *add_new_abstract_pkg_by_name(const char *pkg_name)
612 {
613         abstract_pkg_t *ab_pkg;
614
615         ab_pkg = abstract_pkg_new();
616
617         ab_pkg->name = xstrdup(pkg_name);
618         hash_table_insert(&conf->pkg_hash, pkg_name, ab_pkg);
619
620         return ab_pkg;
621 }
622
623 abstract_pkg_t *ensure_abstract_pkg_by_name(const char *pkg_name)
624 {
625         abstract_pkg_t *ab_pkg;
626
627         if (!(ab_pkg = abstract_pkg_fetch_by_name(pkg_name)))
628                 ab_pkg = add_new_abstract_pkg_by_name(pkg_name);
629
630         return ab_pkg;
631 }
632
633 void hash_insert_pkg(pkg_t * pkg, int set_status)
634 {
635         abstract_pkg_t *ab_pkg;
636
637         ab_pkg = ensure_abstract_pkg_by_name(pkg->name);
638         if (!ab_pkg->pkgs)
639                 ab_pkg->pkgs = pkg_vec_alloc();
640
641         if (pkg->state_status == SS_INSTALLED) {
642                 ab_pkg->state_status = SS_INSTALLED;
643         } else if (pkg->state_status == SS_UNPACKED) {
644                 ab_pkg->state_status = SS_UNPACKED;
645         }
646
647         buildDepends(pkg);
648
649         buildProvides(ab_pkg, pkg);
650
651         init_providelist(pkg, NULL);
652
653         /* Need to build the conflicts graph before replaces for correct
654          * calculation of replaced_by relation.
655          */
656         buildConflicts(pkg);
657
658         buildReplaces(ab_pkg, pkg);
659
660         buildDependedUponBy(pkg, ab_pkg);
661
662         pkg_vec_insert_merge(ab_pkg->pkgs, pkg, set_status);
663         pkg->parent = ab_pkg;
664 }
665
666 static const char *strip_offline_root(const char *file_name)
667 {
668         unsigned int len;
669
670         if (conf->offline_root) {
671                 len = strlen(conf->offline_root);
672                 if (strncmp(file_name, conf->offline_root, len) == 0)
673                         file_name += len;
674         }
675
676         return file_name;
677 }
678
679 void file_hash_remove(const char *file_name)
680 {
681         file_name = strip_offline_root(file_name);
682         hash_table_remove(&conf->file_hash, file_name);
683 }
684
685 pkg_t *file_hash_get_file_owner(const char *file_name)
686 {
687         file_name = strip_offline_root(file_name);
688         return hash_table_get(&conf->file_hash, file_name);
689 }
690
691 void file_hash_set_file_owner(const char *file_name, pkg_t * owning_pkg)
692 {
693         pkg_t *old_owning_pkg;
694         int file_name_len = strlen(file_name);
695
696         if (file_name[file_name_len - 1] == '/')
697                 return;
698
699         file_name = strip_offline_root(file_name);
700
701         old_owning_pkg = hash_table_get(&conf->file_hash, file_name);
702         hash_table_insert(&conf->file_hash, file_name, owning_pkg);
703
704         if (old_owning_pkg) {
705                 pkg_get_installed_files(old_owning_pkg);
706                 str_list_remove_elt(old_owning_pkg->installed_files, file_name);
707                 pkg_free_installed_files(old_owning_pkg);
708
709                 /* mark this package to have its filelist written */
710                 old_owning_pkg->state_flag |= SF_FILELIST_CHANGED;
711                 owning_pkg->state_flag |= SF_FILELIST_CHANGED;
712         }
713 }