openssl, wolfssl: match mbedTLS ciphersuite list
[oweals/openwrt-ustream-ssl.git] / ustream-openssl.c
index 678e3c43c20f6d6556d91b1439e7b0b3de35302b..7c72ce1851f7257881584e616a7d95e3c69ff4eb 100644 (file)
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
+#include <string.h>
 #include <ctype.h>
 #include <openssl/x509v3.h>
 #include "ustream-ssl.h"
 #include "ustream-internal.h"
 
+
+/* Ciphersuite preference:
+ * - key exchange: prefer ECDHE, then DHE(client only), then RSA
+ * - prefer AEAD ciphers:
+ *     chacha20-poly1305, the fastest in software, 256-bits
+ *     aes128-gcm, 128-bits
+ *     aes256-gcm, 256-bits
+ * - CBC ciphers
+ *     aes128, aes256, 3DES(client only)
+ */
+
+#define ecdhe_ciphers                                                  \
+                               "ECDHE-ECDSA-CHACHA20-POLY1305:"        \
+                               "ECDHE-ECDSA-AES128-GCM-SHA256:"        \
+                               "ECDHE-ECDSA-AES256-GCM-SHA384:"        \
+                               "ECDHE-ECDSA-AES128-SHA:"               \
+                               "ECDHE-ECDSA-AES256-SHA:"               \
+                               "ECDHE-RSA-CHACHA20-POLY1305:"          \
+                               "ECDHE-RSA-AES128-GCM-SHA256:"          \
+                               "ECDHE-RSA-AES256-GCM-SHA384:"          \
+                               "ECDHE-RSA-AES128-SHA:"                 \
+                               "ECDHE-RSA-AES256-SHA"
+
+#define dhe_ciphers                                                    \
+                               "DHE-RSA-CHACHA20-POLY1305:"            \
+                               "DHE-RSA-AES128-GCM-SHA256:"            \
+                               "DHE-RSA-AES256-GCM-SHA384:"            \
+                               "DHE-RSA-AES128-SHA:"                   \
+                               "DHE-RSA-AES256-SHA:"                   \
+                               "DHE-DES-CBC3-SHA"
+
+#define non_pfs_aes                                                    \
+                               "AES128-GCM-SHA256:"                    \
+                               "AES256-GCM-SHA384:"                    \
+                               "AES128-SHA:"                           \
+                               "AES256-SHA"
+
+#define server_cipher_list                                             \
+                               ecdhe_ciphers ":"                       \
+                               non_pfs_aes
+
+#define client_cipher_list                                             \
+                               ecdhe_ciphers ":"                       \
+                               dhe_ciphers ":"                         \
+                               non_pfs_aes ":"                         \
+                               "DES-CBC3-SHA"
+
 __hidden struct ustream_ssl_ctx *
 __ustream_ssl_context_new(bool server)
 {
-       static bool _init = false;
        const void *m;
        SSL_CTX *c;
 
+#if OPENSSL_VERSION_NUMBER < 0x10100000L
+       static bool _init = false;
+
        if (!_init) {
                SSL_load_error_strings();
                SSL_library_init();
                _init = true;
        }
-
-#ifdef CYASSL_OPENSSL_H_
-       if (server)
-               m = SSLv23_server_method();
-       else
-               m = SSLv23_client_method();
-#else
-       if (server)
-               m = TLSv1_server_method();
-       else
-               m = TLSv1_client_method();
+# define TLS_server_method TLSv1_2_server_method
+# define TLS_client_method SSLv23_client_method
 #endif
 
+       if (server) {
+               m = TLS_server_method();
+       } else
+               m = TLS_client_method();
+
        c = SSL_CTX_new((void *) m);
        if (!c)
                return NULL;
 
        SSL_CTX_set_verify(c, SSL_VERIFY_NONE, NULL);
+       SSL_CTX_set_options(c, SSL_OP_NO_COMPRESSION | SSL_OP_SINGLE_ECDH_USE |
+                              SSL_OP_CIPHER_SERVER_PREFERENCE);
+#if defined(SSL_CTX_set_ecdh_auto) && OPENSSL_VERSION_NUMBER < 0x10100000L
+       SSL_CTX_set_ecdh_auto(c, 1);
+#endif
+       if (server) {
+#if OPENSSL_VERSION_NUMBER >= 0x10100000L
+               SSL_CTX_set_min_proto_version(c, TLS1_2_VERSION);
+#endif
+               SSL_CTX_set_cipher_list(c, server_cipher_list);
+       } else {
+               SSL_CTX_set_cipher_list(c, client_cipher_list);
+       }
+       SSL_CTX_set_quiet_shutdown(c, 1);
 
        return (void *) c;
 }
@@ -99,6 +159,12 @@ __hidden void __ustream_ssl_context_free(struct ustream_ssl_ctx *ctx)
        SSL_CTX_free((void *) ctx);
 }
 
+void __ustream_ssl_session_free(void *ssl)
+{
+       SSL_shutdown(ssl);
+       SSL_free(ssl);
+}
+
 static void ustream_ssl_error(struct ustream_ssl *us, int ret)
 {
        us->error = ret;
@@ -107,109 +173,15 @@ static void ustream_ssl_error(struct ustream_ssl *us, int ret)
 
 #ifndef CYASSL_OPENSSL_H_
 
-static bool host_pattern_match(const unsigned char *pattern, const char *cn)
-{
-       char c;
-
-       for (; (c = tolower(*pattern++)) != 0; cn++) {
-               if (c != '*') {
-                       if (c != *cn)
-                               return false;
-                       continue;
-               }
-
-               do {
-                       c = tolower(*pattern++);
-               } while (c == '*');
-
-               while (*cn) {
-                       if (c == tolower(*cn) &&
-                           host_pattern_match(pattern, cn))
-                               return true;
-                       if (*cn == '.')
-                               return false;
-                       cn++;
-               }
-
-               return !c;
-       }
-       return !*cn;
-}
-
-static bool host_pattern_match_asn1(ASN1_STRING *asn1, const char *cn)
-{
-       unsigned char *pattern;
-       bool ret = false;
-
-       if (ASN1_STRING_to_UTF8(&pattern, asn1) < 0)
-               return false;
-
-       if (!pattern)
-               return false;
-
-       if (strlen((char *) pattern) == ASN1_STRING_length(asn1))
-               ret = host_pattern_match(pattern, cn);
-
-       OPENSSL_free(pattern);
-
-       return ret;
-}
-
-static bool ustream_ssl_verify_cn_alt(struct ustream_ssl *us, X509 *cert)
-{
-       GENERAL_NAMES *alt_names;
-       int i, n_alt;
-
-       alt_names = X509_get_ext_d2i (cert, NID_subject_alt_name, NULL, NULL);
-       if (!alt_names)
-               return false;
-
-       n_alt = sk_GENERAL_NAME_num(alt_names);
-       for (i = 0; i < n_alt; i++) {
-               const GENERAL_NAME *name = sk_GENERAL_NAME_value(alt_names, i);
-
-               if (!name)
-                       continue;
-
-               if (name->type != GEN_DNS)
-                       continue;
-
-               if (host_pattern_match_asn1(name->d.dNSName, us->peer_cn))
-                       return true;
-       }
-
-       return false;
-}
-
 static bool ustream_ssl_verify_cn(struct ustream_ssl *us, X509 *cert)
 {
-       ASN1_STRING *astr;
-       X509_NAME *xname;
-       int i, last;
+       int ret;
 
        if (!us->peer_cn)
                return false;
 
-       if (ustream_ssl_verify_cn_alt(us, cert))
-               return true;
-
-       xname = X509_get_subject_name(cert);
-
-       last = -1;
-       while (1) {
-               i = X509_NAME_get_index_by_NID(xname, NID_commonName, last);
-               if (i < 0)
-                       break;
-
-               last = i;
-       }
-
-       if (last < 0)
-               return false;
-
-       astr = X509_NAME_ENTRY_get_data(X509_NAME_get_entry(xname, last));
-
-       return host_pattern_match_asn1(astr, us->peer_cn);
+       ret = X509_check_host(cert, us->peer_cn, 0, X509_CHECK_FLAG_NO_PARTIAL_WILDCARDS, NULL);
+       return ret == 1;
 }
 
 
@@ -219,10 +191,6 @@ static void ustream_ssl_verify_cert(struct ustream_ssl *us)
        X509 *cert;
        int res;
 
-       cert = SSL_get_peer_certificate(ssl);
-       if (!cert)
-               return;
-
        res = SSL_get_verify_result(ssl);
        if (res != X509_V_OK) {
                if (us->notify_verify_error)
@@ -230,8 +198,13 @@ static void ustream_ssl_verify_cert(struct ustream_ssl *us)
                return;
        }
 
+       cert = SSL_get_peer_certificate(ssl);
+       if (!cert)
+               return;
+
        us->valid_cert = true;
        us->valid_cn = ustream_ssl_verify_cn(us, cert);
+       X509_free(cert);
 }
 
 #endif