Improve BIO_socket_wait(), BIO_wait(), BIO_connect_retry(), and their docs
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Thu, 28 May 2020 13:16:45 +0000 (15:16 +0200)
committerDr. David von Oheimb <David.von.Oheimb@siemens.com>
Tue, 16 Jun 2020 16:51:39 +0000 (18:51 +0200)
commite98c7350bfaf0ae1f2b72d68d4c5721de24a478f
treec98d71a7215e057d2c1fea65f741a4bf58648d28
parent3f528d0899e8fe850c63d600ee29146bc8a9c125
Improve BIO_socket_wait(), BIO_wait(), BIO_connect_retry(), and their docs

Add/extend range check for 'fd' argument of BIO_socket_wait() and bio_wait()
Correct nap time calculations in bio_wait(), thus correcting also BIO_wait()
Update a type cast from 'unsigned long' to 'unsigned int'
Extend the comments and documentation of BIO_wait()

Rename BIO_connect_retry() to BIO_do_connect_retry()
Make its 'timeout' argument < 0 lead to BIO_do_connect() tried only once
Add optional 'nap_milliseconds' parameter determining the polling granularity
Correct and generalize the retry case checking
Extend the comments and documentation of BIO_do_connect_retry()

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/11986)
crypto/bio/b_sock.c
crypto/bio/bio_lib.c
crypto/http/http_client.c
doc/man3/BIO_socket_wait.pod
doc/man3/OSSL_CMP_CTX_new.pod
doc/man3/OSSL_HTTP_transfer.pod
include/openssl/bio.h
util/libcrypto.num