Restore clearing of init_lock after free
authorBenjamin Kaduk <bkaduk@akamai.com>
Fri, 26 Jan 2018 15:32:40 +0000 (09:32 -0600)
committerBen Kaduk <kaduk@mit.edu>
Wed, 31 Jan 2018 18:25:28 +0000 (12:25 -0600)
commitadeb4bc7a03aa61b6b26c3857dd91b05164daa60
tree1f90ef66be82c5c5bd629dde4aae367e0013e274
parent63ab5ea13b671cb60dd4b7cfde2bcae9d14c5a60
Restore clearing of init_lock after free

The behavior of resetting the init_lock value to NULL after
freeing it during OPENSSL_cleanup() was added as part of the
global lock commits that were just reverted, but there is desire
to retain this behavior for clarity.

It is unclear that the library would actually remain usable in
any form after OPENSSL_cleanup(), since the required re-initialization
occurs under a CRYPTO_ONCE check that cannot be reset at cleanup time.
That said, a NULL dereference is probably more friendly behavior
in these treacherous waters than using freed memory would be.

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from https://github.com/openssl/openssl/pull/5089)
crypto/init.c