Revert "Delay setting the sig algs until after the cert_cb has been called"
authorBenjamin Kaduk <bkaduk@akamai.com>
Thu, 13 Jun 2019 19:04:52 +0000 (12:04 -0700)
committerBenjamin Kaduk <kaduk@mit.edu>
Wed, 26 Jun 2019 17:20:55 +0000 (12:20 -0500)
commit6f34d7bc7d0c7fcd86c6f2772f26e42c925d8505
tree6f9e4c13e53ff19a3296f92e4de570000f5c854c
parent7cb8fb07e8b71dc1fdcb0de10af7fed4347f6ea4
Revert "Delay setting the sig algs until after the cert_cb has been called"

This reverts commit 524006dd1b80c1a86a20119ad988666a80d8d8f5.

While this change did prevent the sigalgs from getting inadvertently
clobbered by SSL_set_SSL_CTX(), it also caused the sigalgs to not be
set when the cert_cb runs.  This, in turn, caused significant breakage,
such as SSL_check_chain() failing to find any valid chain.  An alternate
approach to fixing the issue from #7244 will follow.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9157)
ssl/statem/statem_srvr.c