netifd: fix resource leak on error in netifd_add_dynamic()

[oweals/netifd.git] / vlan.c

diff --git a/vlan.c b/vlan.c
index 785cc9e6f01ab1940ef817ec5ad06193fd61c4a7..8748b3040d511f554ec335071f39b4b0a120df63 100644 (file)
--- a/vlan.c
+++ b/vlan.c
@@ -50,7 +50,7 @@ static int vlan_set_device_state(struct device *dev, bool up)
        }
 
        ret = device_claim(&vldev->dep);
-       if (ret)
+       if (ret < 0)
                return ret;
 
        system_vlan_add(vldev->dep.dev, vldev->id);
@@ -61,6 +61,17 @@ static int vlan_set_device_state(struct device *dev, bool up)
        return ret;
 }
 
+static int vlan_dev_set_name(struct vlan_device *vldev, struct device *dev)
+{
+       char *name;
+
+       name = alloca(strlen(dev->ifname) + sizeof(".2147483647\0"));
+       vldev->dev.hidden = dev->hidden;
+       sprintf(name, "%s.%d", dev->ifname, vldev->id);
+
+       return device_set_ifname(&vldev->dev, name);
+}
+
 static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
 {
        struct vlan_device *vldev;
@@ -73,6 +84,14 @@ static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
        case DEV_EVENT_REMOVE:
                device_set_present(&vldev->dev, false);
                break;
+       case DEV_EVENT_UPDATE_IFNAME:
+               if (vlan_dev_set_name(vldev, dep->dev) < 0)
+                       free_vlan_if(&vldev->dev);
+               break;
+       case DEV_EVENT_TOPO_CHANGE:
+               /* Propagate topo changes */
+               device_broadcast_event(&vldev->dev, DEV_EVENT_TOPO_CHANGE);
+               break;
        default:
                break;
        }
@@ -80,7 +99,7 @@ static void vlan_dev_cb(struct device_user *dep, enum device_event ev)
 
 static struct device *get_vlan_device(struct device *dev, int id, bool create)
 {
-       static const struct device_type vlan_type = {
+       static struct device_type vlan_type = {
                .name = "VLAN",
                .config_params = &device_attr_list,
                .free = free_vlan_if,
@@ -89,7 +108,7 @@ static struct device *get_vlan_device(struct device *dev, int id, bool create)
        struct device_user *dep;
 
        /* look for an existing interface before creating a new one */
-       list_for_each_entry(dep, &dev->users, list) {
+       list_for_each_entry(dep, &dev->users.list, list.list) {
                if (dep->cb != vlan_dev_cb)
                        continue;
 
@@ -103,21 +122,34 @@ static struct device *get_vlan_device(struct device *dev, int id, bool create)
        if (!create)
                return NULL;
 
+       D(DEVICE, "Create vlan device '%s.%d'\n", dev->ifname, id);
+
        vldev = calloc(1, sizeof(*vldev));
-       snprintf(vldev->dev.ifname, IFNAMSIZ, "%s.%d", dev->ifname, id);
+       if (!vldev)
+               return NULL;
+
+       vldev->id = id;
+
+       if (device_init(&vldev->dev, &vlan_type, NULL) < 0)
+               goto error;
+
+       if (vlan_dev_set_name(vldev, dev) < 0)
+               goto error;
 
-       device_init(&vldev->dev, &vlan_type, NULL);
        vldev->dev.default_config = true;
 
        vldev->set_state = vldev->dev.set_state;
        vldev->dev.set_state = vlan_set_device_state;
 
-       vldev->id = id;
-
        vldev->dep.cb = vlan_dev_cb;
        device_add_user(&vldev->dep, dev);
 
        return &vldev->dev;
+
+error:
+       device_cleanup(&vldev->dev);
+       free(vldev);
+       return NULL;
 }
 
 static char *split_vlan(char *s)