zones: do not check conntrack state in zone_*_dest_ACCEPT chains
authorJo-Philipp Wich <jo@mein.io>
Fri, 13 Jan 2017 17:19:43 +0000 (18:19 +0100)
committerJo-Philipp Wich <jo@mein.io>
Fri, 13 Jan 2017 17:25:50 +0000 (18:25 +0100)
Packets which are merely forwarded by the router and which are neither
involved in any DNAT/SNAT nor originate locally, are considered INVALID
from a conntrack point of view, causing them to get dropped in the
zone_*_dest_ACCEPT chains, since those only allow stream with state NEW
or UNTRACKED.

Remove the ctstate restriction on dest accept chains to properly pass-
through unrelated 3rd party traffic.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
zones.c

diff --git a/zones.c b/zones.c
index 8b4bbcd09879b7cf76db5b5f3ac9c1a9f74a6f1f..520d00cf1e2775b9e3ab0b022b6fe3aace4db824 100644 (file)
--- a/zones.c
+++ b/zones.c
@@ -357,11 +357,6 @@ print_interface_rule(struct fw3_ipt_handle *handle, struct fw3_state *state,
                                r = fw3_ipt_rule_create(handle, NULL, NULL, dev, NULL, sub);
                                fw3_ipt_rule_target(r, jump_target(t));
                                fw3_ipt_rule_extra(r, zone->extra_dest);
-
-                               if (t == FW3_FLAG_ACCEPT && !state->defaults.drop_invalid)
-                                       fw3_ipt_rule_extra(r,
-                                                          "-m conntrack --ctstate NEW,UNTRACKED");
-
                                fw3_ipt_rule_replace(r, "zone_%s_dest_%s", zone->name,
                                                     fw3_flag_names[t]);
                        }