target/linux/generic/pending-4.14/499-mtd-parser-cmdline-Fix-parsing-of-part-names-with-co.patch

   1 From: Sven Eckelmann <sven@narfation.org>
   2 Date: Sun, 22 Nov 2020 00:48:33 +0100
   3 Subject: [PATCH RFC] mtd: parser: cmdline: Fix parsing of part-names with colons
   4
   5 Some devices (especially QCA ones) are already using hardcoded partition
   6 names with colons in it. The OpenMesh A62 for example provides following
   7 mtd relevant information via cmdline:
   8
   9   root=31:11 mtdparts=spi0.0:256k(0:SBL1),128k(0:MIBIB),384k(0:QSEE),64k(0:CDT),64k(0:DDRPARAMS),64k(0:APPSBLENV),512k(0:APPSBL),64k(0:ART),64k(custom),64k(0:KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive) rootfsname=rootfs rootwait
  10
  11 The change to split only on the last colon between mtd-id and partitions
  12 will cause newpart to see following string for the first partition:
  13
  14   KEYS),0x002b0000(kernel),0x00c80000(rootfs),15552k(inactive)
  15
  16 Such a partition list cannot be parsed and thus the device fails to boot.
  17
  18 Avoid this behavior by making sure that the start of the first part-name
  19 ("(") will also be the last byte the mtd-id split algorithm is using for
  20 its colon search.
  21
  22 Forwarded: https://patchwork.ozlabs.org/project/linux-mtd/patch/20201122001533.985641-1-sven@narfation.org/
  23 Fixes: eb13fa022741 ("mtd: parser: cmdline: Support MTD names containing one or more colons")
  24 Signed-off-by: Sven Eckelmann <sven@narfation.org>
  25
  26 --- a/drivers/mtd/cmdlinepart.c
  27 +++ b/drivers/mtd/cmdlinepart.c
  28 @@ -228,7 +228,7 @@ static int mtdpart_setup_real(char *s)
  29                 struct cmdline_mtd_partition *this_mtd;
  30                 struct mtd_partition *parts;
  31                 int mtd_id_len, num_parts;
  32 -               char *p, *mtd_id, *semicol;
  33 +               char *p, *mtd_id, *semicol, *open_parenth;
  34
  35                 /*
  36                  * Replace the first ';' by a NULL char so strrchr can work
  37 @@ -238,6 +238,13 @@ static int mtdpart_setup_real(char *s)
  38                 if (semicol)
  39                         *semicol = '\0';
  40
  41 +               /* make sure that part-names with ":" will not be handled as
  42 +                * part of the mtd-id with an ":"
  43 +                */
  44 +               open_parenth = strchr(s, '(');
  45 +               if (open_parenth)
  46 +                       *open_parenth = '\0';
  47 +
  48                 mtd_id = s;
  49
  50                 /*
  51 @@ -247,6 +254,10 @@ static int mtdpart_setup_real(char *s)
  52                  */
  53                 p = strrchr(s, ':');
  54
  55 +               /* Restore the '(' now. */
  56 +               if (open_parenth)
  57 +                       *open_parenth = '(';
  58 +
  59                 /* Restore the ';' now. */
  60                 if (semicol)
  61                         *semicol = ';';