From dd5b0fad8f295c6e786f1528d09f03fa546289cd Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Fri, 22 May 2020 16:32:40 -0600 Subject: [PATCH] checkpatch.pl: Request if() instead #ifdef There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, suggest using the compile-time construct. Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index cf620c8614..17d41825c5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2261,6 +2261,12 @@ sub u_boot_line { WARN("CMD_TEST", "Possible new command - make sure you add a test\n" . $herecurr); } + + # use if instead of #if + if ($line =~ /^\+#if.*CONFIG.*/) { + WARN("PREFER_IF", + "Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible\n" . $herecurr); + } } sub process { -- 2.25.1