From 2383ba9ae03e54041f0bc6a54c93bf27b595c555 Mon Sep 17 00:00:00 2001
From: Davin McCall <davmac@davmac.org>
Date: Thu, 21 Nov 2019 18:43:48 +0000
Subject: [PATCH] dinitcheck: support specifying services to check on command
 line

---
 src/dinitcheck.cc | 45 +++++++++++++++++++++++++++++----------------
 1 file changed, 29 insertions(+), 16 deletions(-)

diff --git a/src/dinitcheck.cc b/src/dinitcheck.cc
index 0237fd9..4abb7ae 100644
--- a/src/dinitcheck.cc
+++ b/src/dinitcheck.cc
@@ -71,35 +71,47 @@ int main(int argc, char **argv)
     if (argc > 1) {
         for (int i = 1; i < argc; i++) {
             if (argv[i][0] == '-') {
-                if (argv[i][0] == '-') {
-                    // An option...
-                    if (strcmp(argv[i], "--services-dir") == 0 || strcmp(argv[i], "-d") == 0) {
-                        if (++i < argc) {
-                            service_dir_opts.set_specified_service_dir(argv[i]);
-                        }
-                        else {
-                            cerr << "dinitcheck: '--services-dir' (-d) requires an argument" << endl;
-                            return 1;
-                        }
+                // An option...
+                if (strcmp(argv[i], "--services-dir") == 0 || strcmp(argv[i], "-d") == 0) {
+                    if (++i < argc) {
+                        service_dir_opts.set_specified_service_dir(argv[i]);
                     }
+                    else {
+                        cerr << "dinitcheck: '--services-dir' (-d) requires an argument" << endl;
+                        return 1;
+                    }
+                }
+                else if (strcmp(argv[i], "--help")) {
+                    cout << "dinitcheck: check dinit service descriptions\n"
+                            " --help                       display help\n"
+                            " --services-dir <dir>, -d <dir>\n"
+                            "                              set base directory for service description\n"
+                            "                              files\n"
+                            " <service-name>               check service with name <service-name>\n";
+                    return EXIT_SUCCESS;
+                }
+                else {
+                    std::cerr << "dinitcheck: Unrecognized option: '" << argv[i] << "' (use '--help' for help)\n";
+                    return EXIT_FAILURE;
                 }
-                // TODO handle other options, err if unrecognized
+            }
+            else {
+                services_to_check.push_back(argv[i]);
             }
         }
     }
 
     service_dir_opts.build_paths(am_system_init);
 
-    // Temporary, for testing:
-    services_to_check.push_back("boot");
+    if (services_to_check.empty()) {
+        services_to_check.push_back("boot");
+    }
 
     // Load named service(s)
-    std::map<std::string, service_record *> service_set;
-
     // - load the service, store dependencies as strings
     // - recurse
 
-    // TODO additional: check chain-to, other lint
+    std::map<std::string, service_record *> service_set;
 
     for (size_t i = 0; i < services_to_check.size(); ++i) {
         const std::string &name = services_to_check[i];
@@ -120,6 +132,7 @@ int main(int argc, char **argv)
     }
 
     // TODO check for circular dependencies
+    // TODO additional: check chain-to, other lint
 
     return 0;
 }
-- 
2.25.1