From 8f8957f90f2c593e233d867cab48519a2215b8a0 Mon Sep 17 00:00:00 2001 From: Hannu Nyman Date: Tue, 2 Feb 2016 14:22:16 +0200 Subject: [PATCH] luci-app-statistics: Remove usually empty std.dev. graph from ping page Remove the usually empty standard deviation graph from the ping page. The graph is empty for most users as collectd measures standard deviation of individual pings inside the general interval of statistics collection. Default setting for both ping interval and general collection interval is 30s in Luci statistics, meaning just 1 ping per interval, which leads to empty graph. (To provide relveant data, the ping interval should be 1/4-1/5 of the general collection interval. Even then the graph does not look very informative due to different scaling than the latency graph.) Note that this commit does not change collectd itself, which continues to collect and calculate also the std.dev. data, which can be fetched with 'rrdtool' if needed. Signed-off-by: Hannu Nyman --- .../luasrc/statistics/rrdtool/definitions/ping.lua | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua b/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua index f0a594816..6ecdb5c8a 100644 --- a/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua +++ b/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua @@ -23,16 +23,6 @@ function rrdargs( graph, plugin, plugin_instance, dtype ) types = { "ping_droprate" }, options = { ping_droprate = { noarea = true, overlay = true, title = "%di" } } - } }, - - -- Ping standard deviation - { title = "%H: ICMP Standard Deviation", - vlabel = "ms", - number_format = "%5.2lf ms", - data = { - types = { "ping_stddev" }, - options = { ping_stddev = { - noarea = true, overlay = true, title = "%di" } } - } }, + } } } end -- 2.25.1