From 34f3bce133ea352f329bbe42f8903826859ee8c7 Mon Sep 17 00:00:00 2001 From: Stan Grishin Date: Sat, 11 Apr 2020 02:30:14 +0000 Subject: [PATCH] luci-app-https-dns-proxy: improve i18n Signed-off-by: Stan Grishin --- .../luci-app-https-dns-proxy/Makefile | 2 +- .../luasrc/model/cbi/https-dns-proxy.lua | 39 +++++++------- .../po/templates/https-dns-proxy.pot | 51 ++++++++----------- 3 files changed, 40 insertions(+), 52 deletions(-) diff --git a/applications/luci-app-https-dns-proxy/Makefile b/applications/luci-app-https-dns-proxy/Makefile index 918d8b085..1fe188185 100644 --- a/applications/luci-app-https-dns-proxy/Makefile +++ b/applications/luci-app-https-dns-proxy/Makefile @@ -10,7 +10,7 @@ LUCI_TITLE:=DNS Over HTTPS Proxy Web UI LUCI_DESCRIPTION:=Provides Web UI for DNS Over HTTPS Proxy LUCI_DEPENDS:=+luci-compat +luci-mod-admin-full +https-dns-proxy LUCI_PKGARCH:=all -PKG_RELEASE:=3 +PKG_RELEASE:=4 include ../../luci.mk diff --git a/applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua b/applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua index d914bf09a..14e1b5434 100644 --- a/applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua +++ b/applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua @@ -49,24 +49,22 @@ function get_provider_name(value) return translate("Unknown Provider") end -local tmpfsStatus, tmpfsStatusCode +local packageStatus, packageStatusCode local ubusStatus = util.ubus("service", "list", { name = packageName }) -local tmpfsVersion = tostring(util.trim(sys.exec("opkg list-installed " .. packageName .. " | awk '{print $3}'"))) +local packageVersion = tostring(util.trim(sys.exec("opkg list-installed " .. packageName .. " | awk '{print $3}'"))) or "" -if not tmpfsVersion or tmpfsVersion == "" then - tmpfsStatusCode = -1 - tmpfsVersion = "" - tmpfsStatus = packageName .. " " .. translate("is not installed or not found") +if packageVersion == "" then + packageStatusCode = -1 + packageStatus = translatef("%s is not installed or not found", packageName) else - tmpfsVersion = " [" .. packageName .. " " .. tmpfsVersion .. "]" if not ubusStatus or not ubusStatus[packageName] then - tmpfsStatusCode = 0 - tmpfsStatus = translate("Stopped") - if not luci.sys.init.enabled(packageName) then - tmpfsStatus = tmpfsStatus .. " (" .. translate("disabled") .. ")" + packageStatusCode = 0 + packageStatus = translate("Stopped") + if not sys.init.enabled(packageName) then + packageStatus = packageStatus .. " (" .. translate("disabled") .. ")" end else - tmpfsStatusCode, tmpfsStatus = 1, "" + packageStatusCode, packageStatus = 1, "" for n = 1,1000 do if ubusStatus and ubusStatus[packageName] and ubusStatus[packageName]["instances"] and @@ -83,7 +81,7 @@ else end la = la or "127.0.0.1" lp = lp or n + 5053 - tmpfsStatus = tmpfsStatus .. translate("Running") .. ": " .. get_provider_name(url) .. " " .. translate("DoH") .. " " .. translate("at") .. " " .. la .. ":" .. lp .. "\n" + packageStatus = packageStatus .. translatef("Running: %s DoH at %s:%s", get_provider_name(url), la, lp) .. "\n" else break end @@ -93,27 +91,26 @@ end m = Map("https-dns-proxy", translate("DNS Over HTTPS Proxy Settings")) -h = m:section(TypedSection, "_dummy", translate("Service Status") .. tmpfsVersion) +h = m:section(TypedSection, "_dummy", translatef("Service Status [%s %s]", packageName, packageVersion)) h.template = "cbi/nullsection" ss = h:option(DummyValue, "_dummy", translate("Service Status")) -if tmpfsStatusCode == -1 then +if packageStatusCode == -1 then ss.template = packageName .. "/status" - ss.value = tmpfsStatus + ss.value = packageStatus else - if tmpfsStatusCode == 0 then + if packageStatusCode == 0 then ss.template = packageName .. "/status" else ss.template = packageName .. "/status-textarea" end - ss.value = tmpfsStatus + ss.value = packageStatus buttons = h:option(DummyValue, "_dummy") buttons.template = packageName .. "/buttons" end create_helper_text() -s3 = m:section(TypedSection, "https-dns-proxy", translate("Instances"), translate("When you add/remove any instances below, they will be used to override the 'DNS forwardings' section of ") - .. [[ ]] - .. translate("DHCP and DNS") .. [[]] .. "." .. helperText) +s3 = m:section(TypedSection, "https-dns-proxy", translate("Instances"), + translatef("When you add/remove any instances below, they will be used to override the 'DNS forwardings' section of DHCP and DNS.", dispatcher.build_url("admin/network/dhcp")) .. helperText) s3.template = "cbi/tblsection" s3.sortable = false s3.anonymous = true diff --git a/applications/luci-app-https-dns-proxy/po/templates/https-dns-proxy.pot b/applications/luci-app-https-dns-proxy/po/templates/https-dns-proxy.pot index 6b7877f26..3a2a3306e 100644 --- a/applications/luci-app-https-dns-proxy/po/templates/https-dns-proxy.pot +++ b/applications/luci-app-https-dns-proxy/po/templates/https-dns-proxy.pot @@ -1,6 +1,10 @@ msgid "" msgstr "Content-Type: text/plain; charset=UTF-8" +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:59 +msgid "%s is not installed or not found" +msgstr "" + #: applications/luci-app-https-dns-proxy/luasrc/https-dns-proxy/providers/com.adguard.dns-family.lua:3 msgid "AdGuard (Family Protection)" msgstr "" @@ -25,15 +29,11 @@ msgstr "" msgid "Cloudflare" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:116 -msgid "DHCP and DNS" -msgstr "" - #: applications/luci-app-https-dns-proxy/luasrc/controller/https-dns-proxy.lua:4 msgid "DNS Over HTTPS Proxy" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:94 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:93 msgid "DNS Over HTTPS Proxy Settings" msgstr "" @@ -49,11 +49,7 @@ msgstr "" msgid "Disable" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:86 -msgid "DoH" -msgstr "" - -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:166 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:164 msgid "EDNS client subnet" msgstr "" @@ -69,7 +65,7 @@ msgstr "" msgid "Google" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:114 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:113 msgid "Instances" msgstr "" @@ -81,11 +77,11 @@ msgstr "" msgid "LibreDNS (No Ads)" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:149 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:147 msgid "Listen address" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:162 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:160 msgid "Listen port" msgstr "" @@ -97,7 +93,7 @@ msgstr "" msgid "ODVR (nic.cz)" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:169 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:167 msgid "Proxy server" msgstr "" @@ -121,19 +117,22 @@ msgstr "" msgid "Reload" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:122 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:120 msgid "Resolver" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:86 -msgid "Running" +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:85 +msgid "Running: %s DoH at %s:%s" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:96 -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:98 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:97 msgid "Service Status" msgstr "" +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:95 +msgid "Service Status [%s %s]" +msgstr "" + #: applications/luci-app-https-dns-proxy/luasrc/view/https-dns-proxy/buttons.htm:41 msgid "Start" msgstr "" @@ -142,7 +141,7 @@ msgstr "" msgid "Stop" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:64 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:63 msgid "Stopped" msgstr "" @@ -153,25 +152,17 @@ msgstr "" #: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:114 msgid "" "When you add/remove any instances below, they will be used to override the " -"'DNS forwardings' section of" +"'DNS forwardings' section of DHCP and DNS." msgstr "" #: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:34 msgid "and" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:86 -msgid "at" -msgstr "" - -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:66 +#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:65 msgid "disabled" msgstr "" -#: applications/luci-app-https-dns-proxy/luasrc/model/cbi/https-dns-proxy.lua:59 -msgid "is not installed or not found" -msgstr "" - #: applications/luci-app-https-dns-proxy/luasrc/https-dns-proxy/providers.disabled/cn.rubyfish.dns.lua:3 msgid "rubyfish.cn" msgstr "" -- 2.25.1