From fe876984a428cc0058bdb536ac948397762f3c0d Mon Sep 17 00:00:00 2001 From: Ralph Siemsen Date: Fri, 28 Jun 2019 10:42:02 -0400 Subject: [PATCH] usb: gadget: f_dfu.c: fix memory leak dfu_prepare_function() allocates N+1 descriptor header structures, the last one being the "DFU Functional Descriptor". dfu_unbind() handles de-allocation, but fails to free the final one (eg. "DFU Functional Descriptor"), leading to memory leak. Fixed by incrementing counter, as in dfu_prepare_function(). Signed-off-by: Ralph Siemsen --- drivers/usb/gadget/f_dfu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 30ece524a8..e27f146605 100644 --- a/drivers/usb/gadget/f_dfu.c +++ b/drivers/usb/gadget/f_dfu.c @@ -748,6 +748,7 @@ static void dfu_unbind(struct usb_configuration *c, struct usb_function *f) if (f_dfu->function) { i = alt_num; + i++; /* free DFU Functional Descriptor */ while (i) { free(f_dfu->function[--i]); f_dfu->function[i] = NULL; -- 2.25.1