From fe82bb9b921be34370e6b71a1c6f062c20999ae0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Timo=20Ter=C3=A4s?= Date: Fri, 20 Jun 2014 13:53:23 +0300 Subject: [PATCH] fix gethostby*_r result pointer value on error according to the documentation in the man pages, the GNU extension functions gethostbyaddr_r, gethostbyname_r and gethostbyname2_r are guaranteed to set the result pointer to NULL in case of error or no result. --- src/network/gethostbyaddr_r.c | 2 ++ src/network/gethostbyname2_r.c | 1 + 2 files changed, 3 insertions(+) diff --git a/src/network/gethostbyaddr_r.c b/src/network/gethostbyaddr_r.c index 73e76447..66e03309 100644 --- a/src/network/gethostbyaddr_r.c +++ b/src/network/gethostbyaddr_r.c @@ -18,6 +18,8 @@ int gethostbyaddr_r(const void *a, socklen_t l, int af, socklen_t sl = af==AF_INET6 ? sizeof sa.sin6 : sizeof sa.sin; int i; + *res = 0; + /* Load address argument into sockaddr structure */ if (af==AF_INET6 && l==16) memcpy(&sa.sin6.sin6_addr, a, 16); else if (af==AF_INET && l==4) memcpy(&sa.sin.sin_addr, a, 4); diff --git a/src/network/gethostbyname2_r.c b/src/network/gethostbyname2_r.c index aa8b0a9e..81f71d21 100644 --- a/src/network/gethostbyname2_r.c +++ b/src/network/gethostbyname2_r.c @@ -17,6 +17,7 @@ int gethostbyname2_r(const char *name, int af, int i, cnt; size_t align, need; + *res = 0; cnt = __lookup_name(addrs, canon, name, af, AI_CANONNAME); if (cnt<0) switch (cnt) { case EAI_NONAME: -- 2.25.1