From f980ca3411bac50aa64be3c8fd4c436adfa7cb13 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Wed, 16 Mar 2016 07:45:33 -0600 Subject: [PATCH] mkimage: Correct file being closed twice in fit_extract_data() The code flows through to the end of the function, so we don't need another close() before this. Remove it. Reported-by: Coverity (CID: 138503) Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- tools/fit_image.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/fit_image.c b/tools/fit_image.c index 31aa43cab3..8a93ea33f9 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -446,8 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname) ret = -EIO; goto err; } - close(fd); - ret = 0; err: -- 2.25.1