From f8fcc184b6e05cbf5f88aa4f4e716e137a69f97e Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Sun, 4 Apr 2010 22:36:34 +0200 Subject: [PATCH] udhcpd: note missing sanity checks on INFORM message handling Signed-off-by: Denys Vlasenko --- networking/udhcp/dhcpd.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/networking/udhcp/dhcpd.c b/networking/udhcp/dhcpd.c index 2d1d5deba..e48473389 100644 --- a/networking/udhcp/dhcpd.c +++ b/networking/udhcp/dhcpd.c @@ -247,11 +247,23 @@ static void send_inform(struct dhcp_packet *oldpacket) { struct dhcp_packet packet; - /* "The server responds to a DHCPINFORM message by sending a DHCPACK + /* "If a client has obtained a network address through some other means + * (e.g., manual configuration), it may use a DHCPINFORM request message + * to obtain other local configuration parameters. Servers receiving a + * DHCPINFORM message construct a DHCPACK message with any local + * configuration parameters appropriate for the client without: + * allocating a new address, checking for an existing binding, filling + * in 'yiaddr' or including lease time parameters. The servers SHOULD + * unicast the DHCPACK reply to the address given in the 'ciaddr' field + * of the DHCPINFORM message. + * ... + * The server responds to a DHCPINFORM message by sending a DHCPACK * message directly to the address given in the 'ciaddr' field * of the DHCPINFORM message. The server MUST NOT send a lease * expiration time to the client and SHOULD NOT fill in 'yiaddr'." */ +//TODO: do a few sanity checks: is ciaddr set? +//Better yet: is ciaddr == IP source addr? init_packet(&packet, oldpacket, DHCPACK); add_server_options(&packet); -- 2.25.1