From f3439c40d85967c4f66eeefbc325f9ebf94d75e1 Mon Sep 17 00:00:00 2001 From: kwolekr Date: Sun, 1 Dec 2013 08:57:35 -0500 Subject: [PATCH] Cavegen: Fix possible out-of-bounds heightmap access --- src/cavegen.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cavegen.cpp b/src/cavegen.cpp index 71f005d5b..f04c02db9 100644 --- a/src/cavegen.cpp +++ b/src/cavegen.cpp @@ -518,7 +518,8 @@ void CaveV7::carveRoute(v3f vec, float f, bool randomize_xz, bool is_ravine) { v3s16 p(cp.X + x0, cp.Y + y0, cp.Z + z0); p += of; - if (!is_ravine && mg->heightmap && should_make_cave_hole) { + if (!is_ravine && mg->heightmap && should_make_cave_hole && + p.X <= node_max.X && p.Z <= node_max.Z) { int maplen = node_max.X - node_min.X + 1; int idx = (p.Z - node_min.Z) * maplen + (p.X - node_min.X); if (p.Y >= mg->heightmap[idx] - 2) -- 2.25.1