From f31d5e10058115679ba553d53bc0ee9bd17ea646 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Mon, 21 Nov 2016 17:11:51 +0000 Subject: [PATCH] Add a TLS1.3 TODO for the msg callback At the moment the msg callback only received the record header with the outer record type in it. We never pass the inner record type - we probably need to at some point. Reviewed-by: Rich Salz --- ssl/record/ssl3_record.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ssl/record/ssl3_record.c b/ssl/record/ssl3_record.c index bf6967624c..d8e2552dbf 100644 --- a/ssl/record/ssl3_record.c +++ b/ssl/record/ssl3_record.c @@ -209,6 +209,11 @@ int ssl3_get_record(SSL *s) } } else { /* SSLv3+ style record */ + /* + * TODO(TLS1.3): This callback only provides the "outer" record + * type to the callback. Somehow we need to pass the "inner" + * record type + */ if (s->msg_callback) s->msg_callback(0, 0, SSL3_RT_HEADER, p, 5, s, s->msg_callback_arg); -- 2.25.1