From f17227d3f5000cb28385c6e065246937326437fb Mon Sep 17 00:00:00 2001 From: Florian Eckert Date: Wed, 26 Jun 2019 13:04:47 +0200 Subject: [PATCH] luci-proto-qmi: only show password and username if auth is selected Only show username and password if we use PAP/CHAP, PAP or CHAP authentication. Signed-off-by: Florian Eckert --- .../model/cbi/admin_network/proto_qmi.lua | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/protocols/luci-proto-qmi/luasrc/model/cbi/admin_network/proto_qmi.lua b/protocols/luci-proto-qmi/luasrc/model/cbi/admin_network/proto_qmi.lua index a7a1c6727..9cc1ae0cf 100644 --- a/protocols/luci-proto-qmi/luasrc/model/cbi/admin_network/proto_qmi.lua +++ b/protocols/luci-proto-qmi/luasrc/model/cbi/admin_network/proto_qmi.lua @@ -26,18 +26,26 @@ apn = section:taboption("general", Value, "apn", translate("APN")) pincode = section:taboption("general", Value, "pincode", translate("PIN")) +auth = section:taboption("general", Value, "auth", translate("Authentication Type")) +auth:value("both", "PAP/CHAP (both)") +auth:value("pap", "PAP") +auth:value("chap", "CHAP") +auth:value("none", "NONE") +auth.default = "none" + + username = section:taboption("general", Value, "username", translate("PAP/CHAP username")) +username:depends("auth", "pap") +username:depends("auth", "chap") +username:depends("auth", "both") password = section:taboption("general", Value, "password", translate("PAP/CHAP password")) +password:depends("auth", "pap") +password:depends("auth", "chap") +password:depends("auth", "both") password.password = true -auth = section:taboption("general", Value, "auth", translate("Authentication Type")) -auth:value("", translate("-- Please choose --")) -auth:value("both", "PAP/CHAP (both)") -auth:value("pap", "PAP") -auth:value("chap", "CHAP") -auth:value("none", "NONE") if luci.model.network:has_ipv6() then ipv6 = section:taboption("advanced", Flag, "ipv6", translate("Enable IPv6 negotiation")) -- 2.25.1