From eed8e77dcf5b9ce9c21919ea6d549b5dd92bb18a Mon Sep 17 00:00:00 2001 From: Gabor Juhos Date: Fri, 19 Jul 2013 08:21:17 +0200 Subject: [PATCH] early: remove superfluous close of stdio file descriptors 'man dup2' says: dup2() makes newfd be the copy of oldfd, closing newfd first if necessary, but note the following: * If oldfd is not a valid file descriptor, then the call fails, and newfd is not closed. * If oldfd is a valid file descriptor, and newfd has the same value as oldfd, then dup2() does nothing, and returns newfd. Signed-off-by: Gabor Juhos --- early.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/early.c b/early.c index 204623b..f9e3277 100644 --- a/early.c +++ b/early.c @@ -53,10 +53,6 @@ static void early_console(const char *dev) mkdev("*console", 0600); dd = open(dev, O_RDWR); - close(STDIN_FILENO); - close(STDOUT_FILENO); - close(STDERR_FILENO); - if (dd < 0) { ERROR("Failed to open %s\n", dev); return; -- 2.25.1