From ee6e6a4b5aaf37ab556cf42602d26a6aed3da327 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Fri, 31 Jan 2020 09:43:35 +0000 Subject: [PATCH] Don't ignore ASN1 when checking for undocumented symbols When we run "make doc-nits" (which happens during travis runs) it will complain if we add any new symbols that aren't documented. However it was suppressing anything starting with ASN1. There's no reason why we should allow ASN1 symbols to go undocumented any more than any others. Therefore we remove that exception. Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/10980) --- util/find-doc-nits | 3 - util/missingcrypto.txt | 150 +++++++++++++++++++++++++++++++++++++ util/missingcrypto111.txt | 152 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 302 insertions(+), 3 deletions(-) diff --git a/util/find-doc-nits b/util/find-doc-nits index 25cd6296e9..3f33c670f3 100755 --- a/util/find-doc-nits +++ b/util/find-doc-nits @@ -677,9 +677,6 @@ sub printem { $func .= '(3)'; # We know they're all in section 3 next if exists $name_map{$func} || defined $seen{$func}; - # Skip ASN1 utilities - next if $func =~ /^ASN1_/; - # Skip functions known to be missing. next if $opt_v && grep( /^\Q$func\E$/, @missing); diff --git a/util/missingcrypto.txt b/util/missingcrypto.txt index 05a8bbf18e..be5c6da34f 100644 --- a/util/missingcrypto.txt +++ b/util/missingcrypto.txt @@ -19,8 +19,158 @@ AES_wrap_key(3) ASIdOrRange_it(3) ASIdentifierChoice_it(3) ASIdentifiers_it(3) +ASN1_ANY_it(3) +ASN1_BIT_STRING_check(3) +ASN1_BIT_STRING_free(3) +ASN1_BIT_STRING_get_bit(3) +ASN1_BIT_STRING_it(3) +ASN1_BIT_STRING_name_print(3) +ASN1_BIT_STRING_new(3) +ASN1_BIT_STRING_num_asc(3) +ASN1_BIT_STRING_set(3) +ASN1_BIT_STRING_set_asc(3) +ASN1_BIT_STRING_set_bit(3) +ASN1_BMPSTRING_free(3) +ASN1_BMPSTRING_it(3) +ASN1_BMPSTRING_new(3) +ASN1_BOOLEAN_it(3) +ASN1_ENUMERATED_free(3) +ASN1_ENUMERATED_it(3) +ASN1_ENUMERATED_new(3) +ASN1_FBOOLEAN_it(3) +ASN1_GENERALIZEDTIME_free(3) +ASN1_GENERALIZEDTIME_it(3) +ASN1_GENERALIZEDTIME_new(3) +ASN1_GENERALSTRING_free(3) +ASN1_GENERALSTRING_it(3) +ASN1_GENERALSTRING_new(3) +ASN1_IA5STRING_free(3) +ASN1_IA5STRING_it(3) +ASN1_IA5STRING_new(3) +ASN1_INTEGER_cmp(3) +ASN1_INTEGER_dup(3) +ASN1_INTEGER_free(3) +ASN1_INTEGER_it(3) +ASN1_INTEGER_new(3) +ASN1_NULL_free(3) +ASN1_NULL_it(3) +ASN1_NULL_new(3) +ASN1_OBJECT_create(3) +ASN1_OBJECT_it(3) +ASN1_OCTET_STRING_NDEF_it(3) +ASN1_OCTET_STRING_cmp(3) +ASN1_OCTET_STRING_dup(3) +ASN1_OCTET_STRING_free(3) +ASN1_OCTET_STRING_it(3) +ASN1_OCTET_STRING_new(3) +ASN1_OCTET_STRING_set(3) +ASN1_PCTX_free(3) +ASN1_PCTX_get_cert_flags(3) +ASN1_PCTX_get_flags(3) +ASN1_PCTX_get_nm_flags(3) +ASN1_PCTX_get_oid_flags(3) +ASN1_PCTX_get_str_flags(3) +ASN1_PCTX_new(3) +ASN1_PCTX_set_cert_flags(3) +ASN1_PCTX_set_flags(3) +ASN1_PCTX_set_nm_flags(3) +ASN1_PCTX_set_oid_flags(3) +ASN1_PCTX_set_str_flags(3) +ASN1_PRINTABLESTRING_free(3) +ASN1_PRINTABLESTRING_it(3) +ASN1_PRINTABLESTRING_new(3) +ASN1_PRINTABLE_free(3) +ASN1_PRINTABLE_it(3) +ASN1_PRINTABLE_new(3) +ASN1_PRINTABLE_type(3) +ASN1_SCTX_free(3) +ASN1_SCTX_get_app_data(3) +ASN1_SCTX_get_flags(3) +ASN1_SCTX_get_item(3) +ASN1_SCTX_get_template(3) +ASN1_SCTX_new(3) +ASN1_SCTX_set_app_data(3) +ASN1_SEQUENCE_ANY_it(3) +ASN1_SEQUENCE_it(3) +ASN1_SET_ANY_it(3) +ASN1_STRING_clear_free(3) +ASN1_STRING_copy(3) +ASN1_STRING_get_default_mask(3) +ASN1_STRING_length_set(3) +ASN1_STRING_set0(3) +ASN1_STRING_set_by_NID(3) +ASN1_STRING_set_default_mask(3) +ASN1_STRING_set_default_mask_asc(3) +ASN1_T61STRING_free(3) +ASN1_T61STRING_it(3) +ASN1_T61STRING_new(3) +ASN1_TBOOLEAN_it(3) +ASN1_TIME_free(3) +ASN1_TIME_it(3) +ASN1_TIME_new(3) +ASN1_TYPE_free(3) +ASN1_TYPE_get_int_octetstring(3) +ASN1_TYPE_get_octetstring(3) +ASN1_TYPE_new(3) +ASN1_TYPE_set_int_octetstring(3) +ASN1_TYPE_set_octetstring(3) +ASN1_UNIVERSALSTRING_free(3) +ASN1_UNIVERSALSTRING_it(3) +ASN1_UNIVERSALSTRING_new(3) +ASN1_UNIVERSALSTRING_to_string(3) +ASN1_UTCTIME_free(3) +ASN1_UTCTIME_it(3) +ASN1_UTCTIME_new(3) +ASN1_UTF8STRING_free(3) +ASN1_UTF8STRING_it(3) +ASN1_UTF8STRING_new(3) +ASN1_VISIBLESTRING_free(3) +ASN1_VISIBLESTRING_it(3) +ASN1_VISIBLESTRING_new(3) +ASN1_add_stable_module(3) +ASN1_bn_print(3) +ASN1_buf_print(3) +ASN1_check_infinite_end(3) +ASN1_const_check_infinite_end(3) +ASN1_d2i_bio(3) +ASN1_d2i_fp(3) +ASN1_digest(3) +ASN1_dup(3) +ASN1_get_object(3) +ASN1_i2d_bio(3) +ASN1_i2d_fp(3) +ASN1_item_d2i(3) +ASN1_item_d2i_bio(3) +ASN1_item_d2i_fp(3) +ASN1_item_digest(3) +ASN1_item_dup(3) +ASN1_item_ex_d2i(3) +ASN1_item_ex_free(3) +ASN1_item_ex_i2d(3) +ASN1_item_ex_new(3) +ASN1_item_free(3) +ASN1_item_i2d(3) +ASN1_item_i2d_bio(3) +ASN1_item_i2d_fp(3) +ASN1_item_ndef_i2d(3) +ASN1_item_new(3) +ASN1_item_pack(3) +ASN1_item_print(3) ASN1_item_sign(3) +ASN1_item_sign_ctx(3) +ASN1_item_unpack(3) ASN1_item_verify(3) +ASN1_mbstring_copy(3) +ASN1_mbstring_ncopy(3) +ASN1_object_size(3) +ASN1_parse(3) +ASN1_parse_dump(3) +ASN1_put_eoc(3) +ASN1_put_object(3) +ASN1_sign(3) +ASN1_str2mask(3) +ASN1_tag2bit(3) +ASN1_verify(3) ASRange_it(3) AUTHORITY_INFO_ACCESS_it(3) AUTHORITY_KEYID_it(3) diff --git a/util/missingcrypto111.txt b/util/missingcrypto111.txt index 3942297f57..77a7295246 100644 --- a/util/missingcrypto111.txt +++ b/util/missingcrypto111.txt @@ -30,6 +30,158 @@ ASIdentifiers_it(3) ASIdentifiers_it(3) ASRange_it(3) ASRange_it(3) +ASN1_ANY_it(3) +ASN1_BIT_STRING_check(3) +ASN1_BIT_STRING_free(3) +ASN1_BIT_STRING_get_bit(3) +ASN1_BIT_STRING_it(3) +ASN1_BIT_STRING_name_print(3) +ASN1_BIT_STRING_new(3) +ASN1_BIT_STRING_num_asc(3) +ASN1_BIT_STRING_set(3) +ASN1_BIT_STRING_set_asc(3) +ASN1_BIT_STRING_set_bit(3) +ASN1_BMPSTRING_free(3) +ASN1_BMPSTRING_it(3) +ASN1_BMPSTRING_new(3) +ASN1_BOOLEAN_it(3) +ASN1_ENUMERATED_free(3) +ASN1_ENUMERATED_it(3) +ASN1_ENUMERATED_new(3) +ASN1_FBOOLEAN_it(3) +ASN1_GENERALIZEDTIME_free(3) +ASN1_GENERALIZEDTIME_it(3) +ASN1_GENERALIZEDTIME_new(3) +ASN1_GENERALSTRING_free(3) +ASN1_GENERALSTRING_it(3) +ASN1_GENERALSTRING_new(3) +ASN1_IA5STRING_free(3) +ASN1_IA5STRING_it(3) +ASN1_IA5STRING_new(3) +ASN1_INTEGER_cmp(3) +ASN1_INTEGER_dup(3) +ASN1_INTEGER_free(3) +ASN1_INTEGER_it(3) +ASN1_INTEGER_new(3) +ASN1_NULL_free(3) +ASN1_NULL_it(3) +ASN1_NULL_new(3) +ASN1_OBJECT_create(3) +ASN1_OBJECT_it(3) +ASN1_OCTET_STRING_NDEF_it(3) +ASN1_OCTET_STRING_cmp(3) +ASN1_OCTET_STRING_dup(3) +ASN1_OCTET_STRING_free(3) +ASN1_OCTET_STRING_it(3) +ASN1_OCTET_STRING_new(3) +ASN1_OCTET_STRING_set(3) +ASN1_PCTX_free(3) +ASN1_PCTX_get_cert_flags(3) +ASN1_PCTX_get_flags(3) +ASN1_PCTX_get_nm_flags(3) +ASN1_PCTX_get_oid_flags(3) +ASN1_PCTX_get_str_flags(3) +ASN1_PCTX_new(3) +ASN1_PCTX_set_cert_flags(3) +ASN1_PCTX_set_flags(3) +ASN1_PCTX_set_nm_flags(3) +ASN1_PCTX_set_oid_flags(3) +ASN1_PCTX_set_str_flags(3) +ASN1_PRINTABLESTRING_free(3) +ASN1_PRINTABLESTRING_it(3) +ASN1_PRINTABLESTRING_new(3) +ASN1_PRINTABLE_free(3) +ASN1_PRINTABLE_it(3) +ASN1_PRINTABLE_new(3) +ASN1_PRINTABLE_type(3) +ASN1_SCTX_free(3) +ASN1_SCTX_get_app_data(3) +ASN1_SCTX_get_flags(3) +ASN1_SCTX_get_item(3) +ASN1_SCTX_get_template(3) +ASN1_SCTX_new(3) +ASN1_SCTX_set_app_data(3) +ASN1_SEQUENCE_ANY_it(3) +ASN1_SEQUENCE_it(3) +ASN1_SET_ANY_it(3) +ASN1_STRING_clear_free(3) +ASN1_STRING_copy(3) +ASN1_STRING_get_default_mask(3) +ASN1_STRING_length_set(3) +ASN1_STRING_set0(3) +ASN1_STRING_set_by_NID(3) +ASN1_STRING_set_default_mask(3) +ASN1_STRING_set_default_mask_asc(3) +ASN1_T61STRING_free(3) +ASN1_T61STRING_it(3) +ASN1_T61STRING_new(3) +ASN1_TBOOLEAN_it(3) +ASN1_TIME_free(3) +ASN1_TIME_it(3) +ASN1_TIME_new(3) +ASN1_TYPE_free(3) +ASN1_TYPE_get_int_octetstring(3) +ASN1_TYPE_get_octetstring(3) +ASN1_TYPE_new(3) +ASN1_TYPE_set_int_octetstring(3) +ASN1_TYPE_set_octetstring(3) +ASN1_UNIVERSALSTRING_free(3) +ASN1_UNIVERSALSTRING_it(3) +ASN1_UNIVERSALSTRING_new(3) +ASN1_UNIVERSALSTRING_to_string(3) +ASN1_UTCTIME_free(3) +ASN1_UTCTIME_it(3) +ASN1_UTCTIME_new(3) +ASN1_UTF8STRING_free(3) +ASN1_UTF8STRING_it(3) +ASN1_UTF8STRING_new(3) +ASN1_VISIBLESTRING_free(3) +ASN1_VISIBLESTRING_it(3) +ASN1_VISIBLESTRING_new(3) +ASN1_add_stable_module(3) +ASN1_bn_print(3) +ASN1_buf_print(3) +ASN1_check_infinite_end(3) +ASN1_const_check_infinite_end(3) +ASN1_d2i_bio(3) +ASN1_d2i_fp(3) +ASN1_digest(3) +ASN1_dup(3) +ASN1_get_object(3) +ASN1_i2d_bio(3) +ASN1_i2d_fp(3) +ASN1_item_d2i(3) +ASN1_item_d2i_bio(3) +ASN1_item_d2i_fp(3) +ASN1_item_digest(3) +ASN1_item_dup(3) +ASN1_item_ex_d2i(3) +ASN1_item_ex_free(3) +ASN1_item_ex_i2d(3) +ASN1_item_ex_new(3) +ASN1_item_free(3) +ASN1_item_i2d(3) +ASN1_item_i2d_bio(3) +ASN1_item_i2d_fp(3) +ASN1_item_ndef_i2d(3) +ASN1_item_new(3) +ASN1_item_pack(3) +ASN1_item_print(3) +ASN1_item_sign(3) +ASN1_item_sign_ctx(3) +ASN1_item_unpack(3) +ASN1_item_verify(3) +ASN1_mbstring_copy(3) +ASN1_mbstring_ncopy(3) +ASN1_object_size(3) +ASN1_parse(3) +ASN1_parse_dump(3) +ASN1_put_eoc(3) +ASN1_put_object(3) +ASN1_sign(3) +ASN1_str2mask(3) +ASN1_tag2bit(3) +ASN1_verify(3) AUTHORITY_INFO_ACCESS_it(3) AUTHORITY_INFO_ACCESS_it(3) AUTHORITY_KEYID_it(3) -- 2.25.1