From ee26d83e983f93333b9d5147285cb902bb6cc737 Mon Sep 17 00:00:00 2001 From: Yousong Zhou Date: Mon, 21 Oct 2019 12:59:24 +0000 Subject: [PATCH] main: exec_self: make clang analyzer happy Prevent a theoretical leak of the args memory when the executable path cannot be found. Signed-off-by: Yousong Zhou [fix whitespace, commit description] Signed-off-by: Jo-Philipp Wich --- main.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/main.c b/main.c index 1db3241..9a177cf 100644 --- a/main.c +++ b/main.c @@ -47,10 +47,15 @@ static void exec_self(int argc, char **argv) { int i; - const char *cmd = rpc_exec_lookup(argv[0]); - char **args = calloc(argc + 1, sizeof(char *)); + const char *cmd; + char **args; - if (!cmd || !args) + cmd = rpc_exec_lookup(argv[0]); + if (!cmd) + return; + + args = calloc(argc + 1, sizeof(char *)); + if (!args) return; for (i = 0; i < argc; i++) -- 2.25.1