From ed0c8249825161036356a3616e8c5247c15d0927 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Tue, 26 May 2015 02:31:04 -0400 Subject: [PATCH] fix incorrect application of visibility to Scrt1.o commit de2b67f8d41e08caa56bf6540277f6561edb647f attempted to avoid having vis.h affect crt files, but the Makefile variable used, CRT_LIBS, refers to the final output copies in the lib directory, not the copies in the crt build directory, and thus the -DCRT was not applied. while unlikely to be noticed, this regression probably broke production of PIE executables whose main functions are not in the executable but rather a shared library. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6559295e..b9668b43 100644 --- a/Makefile +++ b/Makefile @@ -104,7 +104,7 @@ NOSSP_SRCS = $(wildcard crt/*.c) \ src/ldso/dlstart.c src/ldso/dynlink.c $(NOSSP_SRCS:%.c=%.o) $(NOSSP_SRCS:%.c=%.lo): CFLAGS += $(CFLAGS_NOSSP) -$(CRT_LIBS): CFLAGS += -DCRT +$(CRT_LIBS:lib/%=crt/%): CFLAGS += -DCRT # This incantation ensures that changes to any subarch asm files will # force the corresponding object file to be rebuilt, even if the implicit -- 2.25.1