From e939856c8724e357b3a7ba878563bfc957605504 Mon Sep 17 00:00:00 2001 From: Ron Yorston Date: Fri, 30 Oct 2015 19:05:55 +0000 Subject: [PATCH] ash: add tests for failures of the exec and command builtins The exec builtin should return an exit status of 127 if the command can't be found. It doesn't: it returns 2. If the command builtin is used to source a script that runs a second script that doesn't exist ash should issue an error. Instead it seg faults. Signed-off-by: Ron Yorston Signed-off-by: Denys Vlasenko --- shell/ash_test/ash-misc/command2.right | 2 ++ shell/ash_test/ash-misc/command2.tests | 6 ++++++ shell/ash_test/ash-misc/exec.right | 2 ++ shell/ash_test/ash-misc/exec.tests | 3 +++ 4 files changed, 13 insertions(+) create mode 100644 shell/ash_test/ash-misc/command2.right create mode 100755 shell/ash_test/ash-misc/command2.tests create mode 100644 shell/ash_test/ash-misc/exec.right create mode 100755 shell/ash_test/ash-misc/exec.tests diff --git a/shell/ash_test/ash-misc/command2.right b/shell/ash_test/ash-misc/command2.right new file mode 100644 index 000000000..8d2165f69 --- /dev/null +++ b/shell/ash_test/ash-misc/command2.right @@ -0,0 +1,2 @@ +test1 +./command2.tests: ./test1.sh: line 1: ./test2.sh: Permission denied diff --git a/shell/ash_test/ash-misc/command2.tests b/shell/ash_test/ash-misc/command2.tests new file mode 100755 index 000000000..9d9de9a89 --- /dev/null +++ b/shell/ash_test/ash-misc/command2.tests @@ -0,0 +1,6 @@ +echo "echo test1; ./test2.sh" >test1.sh +echo "echo test2" >test2.sh + +command . ./test1.sh + +rm -f test1.sh test2.sh diff --git a/shell/ash_test/ash-misc/exec.right b/shell/ash_test/ash-misc/exec.right new file mode 100644 index 000000000..1741a38dd --- /dev/null +++ b/shell/ash_test/ash-misc/exec.right @@ -0,0 +1,2 @@ +./exec.tests: exec: line 2: ./test1.sh: not found +127 diff --git a/shell/ash_test/ash-misc/exec.tests b/shell/ash_test/ash-misc/exec.tests new file mode 100755 index 000000000..624915de1 --- /dev/null +++ b/shell/ash_test/ash-misc/exec.tests @@ -0,0 +1,3 @@ +rm -f test1.sh +(exec ./test1.sh) +echo $? -- 2.25.1