From e9087d1be7e24557a268e77b3005052058d89adb Mon Sep 17 00:00:00 2001
From: rubenwardy <rubenwardy@gmail.com>
Date: Sat, 19 Aug 2017 19:43:02 +0100
Subject: [PATCH] Fix empty legacy meta being persisted

---
 src/itemstackmetadata.cpp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/itemstackmetadata.cpp b/src/itemstackmetadata.cpp
index 65829fd68..f63671425 100644
--- a/src/itemstackmetadata.cpp
+++ b/src/itemstackmetadata.cpp
@@ -13,11 +13,10 @@ void ItemStackMetadata::serialize(std::ostream &os) const
 {
 	std::ostringstream os2;
 	os2 << DESERIALIZE_START;
-	for (StringMap::const_iterator
-			it = m_stringvars.begin();
-			it != m_stringvars.end(); ++it) {
-		os2 << it->first << DESERIALIZE_KV_DELIM
-		    << it->second << DESERIALIZE_PAIR_DELIM;
+	for (const auto &stringvar : m_stringvars) {
+		if (!stringvar.first.empty() || !stringvar.second.empty())
+			os2 << stringvar.first << DESERIALIZE_KV_DELIM
+				<< stringvar.second << DESERIALIZE_PAIR_DELIM;
 	}
 	os << serializeJsonStringIfNeeded(os2.str());
 }
-- 
2.25.1