From e2b055edf26419c183f4bdc3aa47da789081f72e Mon Sep 17 00:00:00 2001 From: Hauke Mehrtens Date: Wed, 19 Dec 2018 10:51:57 +0100 Subject: [PATCH] hotplug.c: Make sure hotplug buffer is NULL terminated Sets the final byte explicitly to NULL because we later do string operations on this buffer. Fixes Coverity issue 1430926 String not null terminated Signed-off-by: Hauke Mehrtens --- plug/hotplug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plug/hotplug.c b/plug/hotplug.c index 80e6e4d..799123d 100644 --- a/plug/hotplug.c +++ b/plug/hotplug.c @@ -545,11 +545,13 @@ static void hotplug_handler(struct uloop_fd *u, unsigned int ev) { int i = 0; static char buf[4096]; - int len = recv(u->fd, buf, sizeof(buf), MSG_DONTWAIT); + int len = recv(u->fd, buf, sizeof(buf) - 1, MSG_DONTWAIT); void *index; if (len < 1) return; + buf[len] = '\0'; + blob_buf_init(&b, 0); index = blobmsg_open_table(&b, NULL); while (i < len) { -- 2.25.1