From e04a38c0c91c17ce27fb11d83f6767614b7d6b59 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Sat, 31 Mar 2018 00:46:07 +0200 Subject: [PATCH] hush: fix a signedness bug Testcase: set -- a ""; space=" "; printf "<%s>\n" "$@"$space Before: After: <> It usually does not bite since bbox forces -funsigned-char build. Signed-off-by: Denys Vlasenko --- shell/hush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/hush.c b/shell/hush.c index b76b8fda4..e69903d10 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -6015,7 +6015,7 @@ static NOINLINE int expand_vars_to_list(o_string *output, int n, char *arg) } else /* If EXP_FLAG_SINGLEWORD, we handle assignment 'a=....$@.....' * and in this case should treat it like '$*' - see 'else...' below */ - if (first_ch == ('@'|0x80) /* quoted $@ */ + if (first_ch == (char)('@'|0x80) /* quoted $@ */ && !(output->o_expflags & EXP_FLAG_SINGLEWORD) /* not v="$@" case */ ) { while (1) { -- 2.25.1