From df439e938ceb5165297c3e34b6485af0238608ef Mon Sep 17 00:00:00 2001 From: Peng Fan Date: Mon, 5 Nov 2018 09:53:25 +0000 Subject: [PATCH] tools: imx8image: fix coverity CID 184234 Fix: CID 184234: (TAINTED_SCALAR) Using tainted variable "header.num_images - 1" as an index into an array "header.img". Reported-by: Coverity Signed-off-by: Peng Fan --- tools/imx8image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/imx8image.c b/tools/imx8image.c index 03debe547e..019b875773 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -666,8 +666,10 @@ static int get_container_image_start_pos(image_t *image_stack, uint32_t align) } ret = fread(&header, sizeof(header), 1, fd); - if (ret != 1) + if (ret != 1) { printf("Failure Read header %d\n", ret); + exit(EXIT_FAILURE); + } fclose(fd); -- 2.25.1