From dbbc3f2e644c38e9b4993a674269478792195127 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Mon, 7 Aug 2017 23:30:22 +0200 Subject: [PATCH] dumpleases: make NOEXEC Signed-off-by: Denys Vlasenko --- NOFORK_NOEXEC.lst | 8 ++++---- networking/udhcp/dumpleases.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst index acbe29e6f..cd83ff1d6 100644 --- a/NOFORK_NOEXEC.lst +++ b/NOFORK_NOEXEC.lst @@ -68,7 +68,7 @@ chattr - noexec. runner chgrp - noexec. runner chmod - noexec. runner chown - noexec. runner -chpasswd - runner (list of "user:password"s from stdin) +chpasswd - longterm (list of "user:password"s from stdin) chpst - noexec. spawner chroot - noexec. spawner chrt - noexec. spawner @@ -86,7 +86,7 @@ cryptpw - noexec. changes state: with --password-fd=N, moves N to stdin cttyhack - noexec. spawner cut - noexec. runner date - noexec. nofork candidate(needs to stop messing up env, free xasprintf result, not use xfuncs after xasprintf) -dc - runner (eats stdin if no params) +dc - longterm (eats stdin if no params) dd - noexec. runner deallocvt - noexec. leaks: get_console_fd_or_die() may open a new fd, or return one of stdio fds delgroup - noexec. leaks @@ -104,7 +104,7 @@ dos2unix - noexec. runner dpkg - runner du - runner dumpkmap - noexec. leaks: get_console_fd_or_die() may open a new fd, or return one of stdio fds -dumpleases - leaks: open+xread +dumpleases - noexec. leaks: open+xread echo - NOFORK ed - interactive, longterm egrep - longterm runner ("CMD | egrep ..." may run indefinitely, better to exec to conserve memory) @@ -114,7 +114,7 @@ envdir - noexec. spawner envuidgid - noexec. spawner expand - runner expr - noexec. leaks: nested allocs -factor - runner (eats stdin if no params) +factor - longterm (eats stdin if no params) fakeidentd - daemon false - NOFORK fatattr - noexec. leaks: open+xioctl, complex diff --git a/networking/udhcp/dumpleases.c b/networking/udhcp/dumpleases.c index dce9084b3..8aafc0d57 100644 --- a/networking/udhcp/dumpleases.c +++ b/networking/udhcp/dumpleases.c @@ -2,7 +2,7 @@ /* * Licensed under GPLv2 or later, see file LICENSE in this source tree. */ -//applet:IF_DUMPLEASES(APPLET(dumpleases, BB_DIR_USR_BIN, BB_SUID_DROP)) +//applet:IF_DUMPLEASES(APPLET_NOEXEC(dumpleases, dumpleases, BB_DIR_USR_BIN, BB_SUID_DROP, dumpleases)) //kbuild:lib-$(CONFIG_DUMPLEASES) += dumpleases.o -- 2.25.1