From da25dc2985a93ffade1f3467b496eb53577a1f8c Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Fri, 2 Mar 2018 09:27:39 +0100 Subject: [PATCH] Fix a possible memory leak in engine_table_register Reviewed-by: Rich Salz (Merged from https://github.com/openssl/openssl/pull/5489) (cherry picked from commit 55a7f77d72930f9aee1a51e0af9658b2728be127) --- crypto/engine/eng_table.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crypto/engine/eng_table.c b/crypto/engine/eng_table.c index 27d31f70c8..5049fd679e 100644 --- a/crypto/engine/eng_table.c +++ b/crypto/engine/eng_table.c @@ -159,6 +159,11 @@ int engine_table_register(ENGINE_TABLE **table, ENGINE_CLEANUP_CB *cleanup, } fnd->funct = NULL; (void)lh_ENGINE_PILE_insert(&(*table)->piles, fnd); + if (lh_ENGINE_PILE_retrieve(&(*table)->piles, &tmplate) != fnd) { + sk_ENGINE_free(fnd->sk); + OPENSSL_free(fnd); + goto end; + } } /* A registration shouldn't add duplciate entries */ (void)sk_ENGINE_delete_ptr(fnd->sk, e); -- 2.25.1