From d97c6d9f097f91bc3c283afe15983a0a7867f2b0 Mon Sep 17 00:00:00 2001 From: David Bauer Date: Sun, 11 Aug 2019 23:37:24 +0200 Subject: [PATCH] lantiq: unify Fritz!Box LED mappings This commit unifies the LED mapping of the AVM Fritz!Box routers, which have a combined Power/DSL LED. With the stock firmware, the Power LED has the following characteristics: - Blink when DSL sync is being established - Solid when DSL sync is present We can't completely resemble this behavior in OpenWrt. Currently, the Power LED is completely off, when DSL sync is missing. This is not really helpful, as a user might have the impression, that he bricked his device. Instead, map the Info-LED to the state of the DSL connection. There is no consistent behavior for the Info-LED in the stock firmware, as the user can set it's function by himself. The DSL connection state is one possible option for the Info LED there. Also use the red Power LED to indicate a running upgrade, in case the board has a two-color Power LED. Signed-off-by: David Bauer (cherry picked from commit 3032bf7f89e8ad5b69ab2f031287f475e5d2b829) --- .../lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi | 2 +- .../linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts | 3 +-- .../linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts | 3 +-- .../linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi | 3 ++- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi index 9a0359d1cc..e86e544945 100644 --- a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi +++ b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ3370-REV2.dtsi @@ -15,7 +15,7 @@ led-boot = &power_green; led-failsafe = &power_red; led-running = &power_green; - led-upgrade = &power_green; + led-upgrade = &power_red; led-dsl = &dsl; led-internet = &info_green; diff --git a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts index 796b941ede..29da0fb8e5 100644 --- a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts +++ b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7312.dts @@ -18,8 +18,7 @@ led-running = &power; led-upgrade = &power; - led-internet = &info_green; - led-dsl = &power; + led-dsl = &info_green; led-wifi = &wlan; }; diff --git a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts index a4afca11fa..89fc3858b7 100644 --- a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts +++ b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ7320.dts @@ -18,8 +18,7 @@ led-running = &power; led-upgrade = &power; - led-internet = &info_green; - led-dsl = &power; + led-dsl = &info_green; led-wifi = &wlan; }; diff --git a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi index 9c1d2db8fa..8ed23deb44 100644 --- a/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi +++ b/target/linux/lantiq/files-4.14/arch/mips/boot/dts/FRITZ736X.dtsi @@ -17,7 +17,8 @@ led-boot = &power_green; led-failsafe = &power_red; led-running = &power_green; - led-upgrade = &power_green; + led-upgrade = &power_red; + led-dsl = &info_green; led-wifi = &wifi; }; -- 2.25.1