From d6bb4f1a1ddab325024966cd79abd34364dfdd15 Mon Sep 17 00:00:00 2001 From: Denis Osvald Date: Thu, 25 Aug 2016 13:54:52 +0200 Subject: [PATCH] ubusd: don't check ACL when object is NULL If there are any ACLs present other than global wildcard "*", the AVL tree comparator will compare ACL key to object name. However, object name can be NULL in cases where ACL check is done on call to internal ubus objects (e.g. ubus monitor). With this change we skip checking ACLs on such NULL objects. Signed-off-by: Denis Osvald --- ubusd_acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ubusd_acl.c b/ubusd_acl.c index 85ada5d..2700c86 100644 --- a/ubusd_acl.c +++ b/ubusd_acl.c @@ -101,7 +101,7 @@ ubusd_acl_check(struct ubus_client *cl, const char *obj, struct blob_attr *cur; int rem; - if (!cl->uid) + if (!cl->uid || !obj) return 0; acl = avl_find_ge_element(&ubusd_acls, obj, acl, avl); -- 2.25.1