From d4f28d94bedd64b3cd0426db44b02130ebd49184 Mon Sep 17 00:00:00 2001 From: Davin McCall Date: Wed, 4 Nov 2015 22:14:58 +0000 Subject: [PATCH] Improve comments - remove no longer relevant comment, add some new comments. --- load_service.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/load_service.cc b/load_service.cc index a45316a..c336a7a 100644 --- a/load_service.cc +++ b/load_service.cc @@ -193,7 +193,6 @@ ServiceRecord * ServiceSet::loadServiceRecord(const char * name) std::list depends_soft; string logfile; - // TODO catch I/O exceptions, wrap & re-throw? string line; bool auto_restart = false; ifstream service_file; @@ -206,7 +205,7 @@ ServiceRecord * ServiceSet::loadServiceRecord(const char * name) throw ServiceNotFound(name); } - // Add a dummy service record now to prevent cyclic dependencies + // Add a dummy service record now to prevent infinite recursion in case of cyclic dependency rval = new ServiceRecord(this, string(name)); records.push_back(rval); @@ -232,6 +231,7 @@ ServiceRecord * ServiceSet::loadServiceRecord(const char * name) if (setting == "command") { command = read_setting_value(i, end); + // TODO check for valid command } else if (setting == "depends-on") { string dependency_name = read_setting_value(i, end); -- 2.25.1