From d3dce35aabf1a0f3359c1129cc668850c00f95ea Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 15 Sep 2018 20:43:46 +0200 Subject: [PATCH] efi_loader: check parameter new_handle of efi_file_open() We should not check parameter file twice. We should check parameter new_handle. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf --- lib/efi_loader/efi_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c index e090cf017c..0753a36a20 100644 --- a/lib/efi_loader/efi_file.c +++ b/lib/efi_loader/efi_file.c @@ -218,7 +218,7 @@ static efi_status_t EFIAPI efi_file_open(struct efi_file_handle *file, open_mode, attributes); /* Check parameters */ - if (!file || !file || !file_name) { + if (!file || !new_handle || !file_name) { ret = EFI_INVALID_PARAMETER; goto out; } -- 2.25.1