From d116b53f873c2cba861a7a83f4693d65140989b6 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 6 Mar 2016 19:28:25 -0700 Subject: [PATCH] x86: Add comments to the SIPI vector The Intel SIPI (start-up inter-processor interrupt) vector is the entry point for each secondary CPU (also called an AP - applications processor). The assembler and C code are linked, so add comments to indicate this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- arch/x86/cpu/sipi_vector.S | 1 + arch/x86/include/asm/sipi.h | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/cpu/sipi_vector.S b/arch/x86/cpu/sipi_vector.S index 0c4a157f38..94c0f5a702 100644 --- a/arch/x86/cpu/sipi_vector.S +++ b/arch/x86/cpu/sipi_vector.S @@ -193,6 +193,7 @@ load_msr: mov c_handler, %esi call *%esi + /* This matches struct sipi_param */ .align 4 .globl sipi_params sipi_params: diff --git a/arch/x86/include/asm/sipi.h b/arch/x86/include/asm/sipi.h index 25d7d311d2..da91a485d8 100644 --- a/arch/x86/include/asm/sipi.h +++ b/arch/x86/include/asm/sipi.h @@ -42,6 +42,7 @@ struct __packed sipi_params_16bit { * struct sipi_params - 32-bit SIP entry-point parameters * * These are used by the AP init code and must be set up before the APs start. + * The members must match with the sipi_params layout in sipi_vector.S. * * The stack area extends down from @stack_top, with @stack_size allocated * for each AP. -- 2.25.1