From d06c715477ddc90c32f2f3d1cf79825e58a42167 Mon Sep 17 00:00:00 2001 From: Andy Polyakov Date: Tue, 6 Mar 2018 23:33:06 +0100 Subject: [PATCH] Configurations/10-main.conf: add -fno-common back to darwin-ppc-cc. -fno-common was removed for all Darwin targets in 0c8734198d4282f6997965a03cd2e0ceaf207549 with rationale "it's either 'ranlib -c' or '-fno-common'." However, it's still absolutely required in 32-bit darwin-ppc-cc. And when trying things out I didn't quite see why it was formulated as one-or-another choice, as 'ranlib -c' shouldn't [and doesn't] have problems with object modules without commons. [Well, to be frank, I didn't manage to reproduce the problem the modification was meaning to resolve either...] (backport of 107783d9c56e7dcb338c011fa202ffa8f066dbca) Reviewed-by: Richard Levitte --- Configurations/10-main.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/Configurations/10-main.conf b/Configurations/10-main.conf index 1508ff4c0f..b49f04b5d7 100644 --- a/Configurations/10-main.conf +++ b/Configurations/10-main.conf @@ -1583,6 +1583,7 @@ sub vms_info { inherit_from => [ "darwin-common", asm("ppc32_asm") ], cflags => add("-arch ppc -std=gnu9x -DB_ENDIAN -Wa,-force_cpusubtype_ALL"), perlasm_scheme => "osx32", + shared_cflag => add("-fno-common"), shared_ldflag => "-arch ppc -dynamiclib", }, "darwin64-ppc-cc" => { -- 2.25.1