From cd785fb716769228082ab1fd690d7916e3cc9cee Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Thu, 14 Aug 2008 21:57:43 +0000 Subject: [PATCH] nmeter: fix read past the end if a buffer. Closes 4594 --- procps/nmeter.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/procps/nmeter.c b/procps/nmeter.c index 48a5b4e26..cded67e56 100644 --- a/procps/nmeter.c +++ b/procps/nmeter.c @@ -786,8 +786,10 @@ int nmeter_main(int argc, char **argv) if (argc != 2) bb_show_usage(); - if (open_read_close("version", buf, sizeof(buf)) > 0) - is26 = (strstr(buf, " 2.4.")==NULL); + if (open_read_close("version", buf, sizeof(buf)-1) > 0) { + buf[sizeof(buf)-1] = '\0'; + is26 = (strstr(buf, " 2.4.") == NULL); + } // Can use argv[1] directly, but this will mess up // parameters as seen by e.g. ps. Making a copy... -- 2.25.1