From cc27bec2b40ca6741125cbeef6a214dfbe1f85f9 Mon Sep 17 00:00:00 2001 From: Matt Caswell Date: Wed, 11 Mar 2015 15:31:16 +0000 Subject: [PATCH] Fix error handling in bn_exp In the event of an error |rr| could be NULL. Therefore don't assume you can use |rr| in the error handling code. Reviewed-by: Andy Polyakov (cherry picked from commit 8c5a7b33c6269c3bd6bc0df6b4c22e4fba03b485) --- crypto/bn/bn_exp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/bn/bn_exp.c b/crypto/bn/bn_exp.c index fca401450a..27146c89e7 100644 --- a/crypto/bn/bn_exp.c +++ b/crypto/bn/bn_exp.c @@ -168,10 +168,10 @@ int BN_exp(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx) goto err; } } - ret = 1; - err: if (r != rr) BN_copy(r, rr); + ret = 1; + err: BN_CTX_end(ctx); bn_check_top(r); return (ret); -- 2.25.1