From c2eeb2f69ab1f0aa248781bebf04617cf9908e4b Mon Sep 17 00:00:00 2001 From: "Schanzenbach, Martin" Date: Wed, 5 Jun 2019 21:11:51 +0200 Subject: [PATCH] fix use after free; fix memleak --- src/reclaim/plugin_rest_reclaim.c | 4 ---- src/reclaim/reclaim_api.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/reclaim/plugin_rest_reclaim.c b/src/reclaim/plugin_rest_reclaim.c index 18309e68c..3f2577802 100644 --- a/src/reclaim/plugin_rest_reclaim.c +++ b/src/reclaim/plugin_rest_reclaim.c @@ -283,10 +283,6 @@ cleanup_handle (struct RequestHandle *handle) GNUNET_free (ego_tmp->keystring); GNUNET_free (ego_tmp); } - if (NULL != handle->attr_it) - { - GNUNET_free (handle->attr_it); - } GNUNET_free (handle); } diff --git a/src/reclaim/reclaim_api.c b/src/reclaim/reclaim_api.c index 00ab69579..8c97ba9a2 100644 --- a/src/reclaim/reclaim_api.c +++ b/src/reclaim/reclaim_api.c @@ -509,6 +509,7 @@ handle_consume_ticket_result (void *cls, } GNUNET_CONTAINER_DLL_remove (h->op_head, h->op_tail, op); free_op (op); + GNUNET_free_non_null (attrs); return; } GNUNET_assert (0); -- 2.25.1