From bebdf68c0680860c619cb95c16d014f27c55de14 Mon Sep 17 00:00:00 2001 From: Marcello Stanisci Date: Wed, 24 Oct 2018 12:52:58 +0200 Subject: [PATCH] Remove unnecessary (and perilous) function pointer cast. --- src/curl/curl_reschedule.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/curl/curl_reschedule.c b/src/curl/curl_reschedule.c index 0b5b85687..cc3c1db95 100644 --- a/src/curl/curl_reschedule.c +++ b/src/curl/curl_reschedule.c @@ -77,6 +77,18 @@ GNUNET_CURL_gnunet_rc_create_with_parser (struct GNUNET_CURL_Context *ctx, return rctx; } + +/** + * Just a wrapper to avoid casting of function pointers. + * + * @param response the (JSON) response to clean. + */ +static void +clean_result (void *response) +{ + json_decref (response); +} + /** * Initialize reschedule context. * @@ -90,8 +102,8 @@ GNUNET_CURL_gnunet_rc_create (struct GNUNET_CURL_Context *ctx) rc = GNUNET_new (struct GNUNET_CURL_RescheduleContext); rc->ctx = ctx; - rc->parser = (GNUNET_CURL_RawParser) &download_get_result; - rc->cleaner = (GNUNET_CURL_ResponseCleaner) &json_decref; + rc->parser = &download_get_result; + rc->cleaner = &clean_result; return rc; } -- 2.25.1