From bb7fc98c43e29b9169522f6e25aa5988ce931c6c Mon Sep 17 00:00:00 2001 From: "Dr. Stephen Henson" Date: Sun, 18 Oct 2015 00:04:10 +0100 Subject: [PATCH] Fix memory leak with -issuer option. Reviewed-by: Richard Levitte --- apps/ocsp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/ocsp.c b/apps/ocsp.c index 0f8ddcc33f..982eddf20c 100644 --- a/apps/ocsp.c +++ b/apps/ocsp.c @@ -404,13 +404,14 @@ int ocsp_main(int argc, char **argv) path = opt_arg(); break; case OPT_ISSUER: - X509_free(issuer); issuer = load_cert(opt_arg(), FORMAT_PEM, NULL, NULL, "issuer certificate"); if (issuer == NULL) goto end; - if ((issuers = sk_X509_new_null()) == NULL) - goto end; + if (issuers == NULL) { + if ((issuers = sk_X509_new_null()) == NULL) + goto end; + } sk_X509_push(issuers, issuer); break; case OPT_CERT: @@ -750,6 +751,7 @@ int ocsp_main(int argc, char **argv) EVP_PKEY_free(key); EVP_PKEY_free(rkey); X509_free(cert); + sk_X509_pop_free(issuers, X509_free); X509_free(rsigner); X509_free(rca_cert); free_index(rdb); -- 2.25.1