From b2cca32a37b969cce3b3bce693708759d44d3d15 Mon Sep 17 00:00:00 2001 From: Bartosz Golaszewski Date: Mon, 11 May 2015 17:22:10 +0200 Subject: [PATCH] i2c-tools: fix 'i2cdetect -l' Calling 'i2cdetect -l' only displays usage and exits. Fix it by correctly parsing command-line arguments. Signed-off-by: Bartosz Golaszewski Signed-off-by: Denys Vlasenko --- miscutils/i2c_tools.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c index 03bb03974..2805cf3b0 100644 --- a/miscutils/i2c_tools.c +++ b/miscutils/i2c_tools.c @@ -1284,13 +1284,16 @@ int i2cdetect_main(int argc UNUSED_PARAM, char **argv) unsigned opts; opt_complementary = "q--r:r--q:" /* mutually exclusive */ - "-1:?3"; /* from 1 to 3 args */ + "?3"; /* up to 3 args */ opts = getopt32(argv, optstr); argv += optind; if (opts & opt_l) list_i2c_busses_and_exit(); + if (!argv[0]) + bb_show_usage(); + bus_num = i2c_bus_lookup(argv[0]); fd = i2c_dev_open(bus_num); get_funcs_matrix(fd, &funcs); -- 2.25.1